From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id BB3C26B0071 for ; Fri, 19 Nov 2010 09:38:29 -0500 (EST) Received: by gxk7 with SMTP id 7so2951245gxk.14 for ; Fri, 19 Nov 2010 06:38:28 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1290119265.26343.814.camel@calx> References: <1290049259-20108-1-git-send-email-b32542@freescale.com> <1290114908.26343.721.camel@calx> <1290119265.26343.814.camel@calx> Date: Fri, 19 Nov 2010 22:38:27 +0800 Message-ID: Subject: Re: [PATCH] slub: operate cache name memory same to slab and slob From: Zeng Zhaoming Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org To: Matt Mackall Cc: David Rientjes , linux-mm@kvack.org, cl@linux-foundation.org, penberg@cs.helsinki.fi, tytso@mit.edu, linux-kernel@vger.kernel.org List-ID: > - eliminate dynamically-allocated names (mostly useless when we start > merging slabs!) not permit dynamically allocated name. I think this one is better, but as a rule, describe in header is not enough. It is helpful to print out some warning when someone break the rule. > kmem_cache_name() is also a highly suspect function in a > post-merged-slabs kernel. As ext4 is the only user in the kernel, and it > got it wrong, perhaps it's time to rip it out. agree, kmem_cache_name() is ugly. --- Best Regards Zeng Zhaoming -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org