From: Zeng Zhaoming <zengzm.kernel@gmail.com>
To: Matt Mackall <mpm@selenic.com>
Cc: David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, cl@linux-foundation.org,
penberg@cs.helsinki.fi, tytso@mit.edu,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slub: operate cache name memory same to slab and slob
Date: Fri, 19 Nov 2010 22:38:27 +0800 [thread overview]
Message-ID: <AANLkTikSw2X-n7mC0+Mxosn8w-AAuROkSV7V9G+8ZAVS@mail.gmail.com> (raw)
In-Reply-To: <1290119265.26343.814.camel@calx>
> - eliminate dynamically-allocated names (mostly useless when we start
> merging slabs!)
not permit dynamically allocated name. I think this one is better, but
as a rule, describe in header is not enough.
It is helpful to print out some warning when someone break the rule.
> kmem_cache_name() is also a highly suspect function in a
> post-merged-slabs kernel. As ext4 is the only user in the kernel, and it
> got it wrong, perhaps it's time to rip it out.
agree, kmem_cache_name() is ugly.
---
Best Regards
Zeng Zhaoming
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-19 14:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 3:00 b32542
2010-11-18 21:15 ` Matt Mackall
2010-11-18 21:36 ` David Rientjes
2010-11-18 22:27 ` Matt Mackall
2010-11-19 14:38 ` Zeng Zhaoming [this message]
2010-11-21 0:55 ` David Rientjes
2010-11-18 21:41 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikSw2X-n7mC0+Mxosn8w-AAuROkSV7V9G+8ZAVS@mail.gmail.com \
--to=zengzm.kernel@gmail.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox