From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id C45066B004A for ; Mon, 29 Nov 2010 22:55:50 -0500 (EST) Received: by qyk10 with SMTP id 10so5615811qyk.14 for ; Mon, 29 Nov 2010 19:55:48 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20101129103845.GA1195@localhost> References: <20101129103845.GA1195@localhost> Date: Tue, 30 Nov 2010 12:55:48 +0900 Message-ID: Subject: Re: [BUGFIX] vmstat: fix dirty threshold ordering From: Minchan Kim Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org To: Wu Fengguang Cc: Andrew Morton , Michael Rubin , Linux Memory Management List , LKML List-ID: On Mon, Nov 29, 2010 at 7:38 PM, Wu Fengguang wrot= e: > The nr_dirty_[background_]threshold fields are misplaced before the > numa_* fields, and users will read strange values. > > This is the right order. Before patch, nr_dirty_background_threshold > will read as 0 (the value from numa_miss). > > =A0 =A0 =A0 =A0numa_hit 128501 > =A0 =A0 =A0 =A0numa_miss 0 > =A0 =A0 =A0 =A0numa_foreign 0 > =A0 =A0 =A0 =A0numa_interleave 7388 > =A0 =A0 =A0 =A0numa_local 128501 > =A0 =A0 =A0 =A0numa_other 0 > =A0 =A0 =A0 =A0nr_dirty_threshold 144291 > =A0 =A0 =A0 =A0nr_dirty_background_threshold 72145 > > Cc: Michael Rubin > Signed-off-by: Wu Fengguang Reviewed-by: Minchan Kim --=20 Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org