linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michael Rubin <mrubin@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, jack@suse.cz, david@fromorbit.com,
	hch@lst.de, axboe@kernel.dk
Subject: Re: [PATCH 2/2] writeback: Adding pages_dirtied and pages_entered_writeback
Date: Fri, 6 Aug 2010 00:19:00 -0700	[thread overview]
Message-ID: <AANLkTikFM9J9On85N9k6hKPfUz0w4LxZai6xfsHQz+-D@mail.gmail.com> (raw)
In-Reply-To: <AANLkTik9AMf1pmsguB843UC9Qq6KxBcWiN_qyeiDPp1O@mail.gmail.com>

On Thu, Aug 5, 2010 at 1:24 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> Wait.  These counters appear in /proc/vmstat.  So why create standalone
> /proc/sys/vm files as well?

Andrew I was thinking about this today. And I think there is a case
for keeping the proc files.
Christoph was the one who pointed out to me that is their proper home
and I think he's right. Most if not all the tunables for writeback are
there. When one is trying to find the state of the system's writeback
activity that's the directory. Only having these variables in
/proc/vmstat to me feels like a way to make sure that users who would
need them won't find them unless they are reading source. And these
are folks who aren't reading source.

/proc/vmstat _does_ look like a good place to put the thresholds as it
already has similar values as the thresholds suck as
kswapd_low_wmark_hit_quickly.

mrubin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2010-08-06  7:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-05  0:43 [PATCH 0/2] Adding two writeback files in /proc/sys/vm Michael Rubin
2010-08-05  0:43 ` [PATCH 1/2] mm: helper functions for dirty and writeback accounting Michael Rubin
2010-08-05  0:43 ` [PATCH 2/2] writeback: Adding pages_dirtied and pages_entered_writeback Michael Rubin
2010-08-05 20:24   ` Andrew Morton
2010-08-05 22:05     ` Michael Rubin
2010-08-05 23:56       ` KOSAKI Motohiro
2010-08-06  0:11         ` Michael Rubin
2010-08-06  0:18           ` KOSAKI Motohiro
2010-08-06  0:27             ` Andrew Morton
2010-08-06  0:44               ` KOSAKI Motohiro
2010-08-06  7:19       ` Michael Rubin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikFM9J9On85N9k6hKPfUz0w4LxZai6xfsHQz+-D@mail.gmail.com \
    --to=mrubin@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox