Re: [PATCH 2/3] do_migrate_range: exit loop if not_managed is true.

[Bob Liu <lliubbo@gmail.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 2046 bytes --]

On Fri, Oct 22, 2010 at 11:16 AM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Thu, 21 Oct 2010 21:28:20 +0800
> Bob Liu <lliubbo@gmail.com> wrote:
>
>> If not_managed is true all pages will be putback to lru, so
>> break the loop earlier to skip other pages isolate.
>>
>> Signed-off-by: Bob Liu <lliubbo@gmail.com>
>
> please don't skip dump_page().
>

Hi, Kame

I put the check after dump_page() in order to we can still see the
dump message if the loop is broken earlier.

Thanks

> -Kame
>
>> ---
>>  mm/memory_hotplug.c |   10 ++++++----
>>  1 files changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
>> index d4e940a..4f72184 100644
>> --- a/mm/memory_hotplug.c
>> +++ b/mm/memory_hotplug.c
>> @@ -709,15 +709,17 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
>>                                           page_is_file_cache(page));
>>
>>               } else {
>> -                     /* Becasue we don't have big zone->lock. we should
>> -                        check this again here. */
>> -                     if (page_count(page))
>> -                             not_managed++;
>>  #ifdef CONFIG_DEBUG_VM
>>                       printk(KERN_ALERT "removing pfn %lx from LRU failed\n",
>>                              pfn);
>>                       dump_page(page);
>>  #endif
>> +                     /* Becasue we don't have big zone->lock. we should
>> +                        check this again here. */
>> +                     if (page_count(page)) {
>> +                             not_managed++;
>> +                             break;
>> +                     }
>>               }
>>       }
>>       ret = -EBUSY;
-- 
Regards,
--Bob
N‹§²æìr¸›zǧu©ž²Æ {\b­†éì¹»\x1c®&Þ–)îÆi¢žØ^n‡r¶‰šŽŠÝ¢j$½§$¢¸\x05¢¹¨­è§~Š'.)îÄÃ,yèm¶ŸÿÃ\f%Š{±šj+ƒðèž×¦j)Z†·Ÿ