From: Minchan Kim <minchan.kim@gmail.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Shaohua Li <shaohua.li@intel.com>, linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>
Subject: Re: [patch]vmscan: make kswapd use a correct order
Date: Thu, 2 Dec 2010 09:58:18 +0900 [thread overview]
Message-ID: <AANLkTik5HW6XgTNwGk2_Q36T0RpGMaCouZcTT2L5nfCd@mail.gmail.com> (raw)
In-Reply-To: <20101202092921.1570.A69D9226@jp.fujitsu.com>
On Thu, Dec 2, 2010 at 9:29 AM, KOSAKI Motohiro
<kosaki.motohiro@jp.fujitsu.com> wrote:
>> > It might work well. but I don't like such a coding that kswapd_try_to_sleep's
>> > eturn value is order. It doesn't look good to me and even no comment. Hmm..
>> >
>> > How about this?
>> > If you want it, feel free to use it.
>> > If you insist on your coding style, I don't have any objection.
>> > Then add My Reviewed-by.
>> >
>> > Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
>>
>> I'm ok this.
>>
>> Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>>
>>
>> Thanks.
>>
>
> Please consider rensend a patch with full patch description. Of cource,
> you need to rebase this on top Mel's patch.
>
> Plus, please don't remove Shaohua's reported-by tag. It's important line
> than my code. Please respect good bug finder.
I don't have a thought to intercept Shaohua and Your's credit.
Just a review so I hoped you send the patch with adding my signed-off
or reviewed-by.
Okay. I will resend it with full-description and you guys's signed-off.
But before that, We have to discuss Shaohua's argue about _safety_.
> Thanks.
>
>
>
>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-02 0:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 3:08 Shaohua Li
2010-12-01 4:21 ` Minchan Kim
2010-12-01 5:42 ` Shaohua Li
2010-12-01 9:44 ` KOSAKI Motohiro
2010-12-01 15:58 ` Minchan Kim
2010-12-02 0:09 ` KOSAKI Motohiro
2010-12-02 0:29 ` KOSAKI Motohiro
2010-12-02 0:58 ` Minchan Kim [this message]
2010-12-02 0:19 ` Andrew Morton
2010-12-02 9:40 ` Mel Gorman
2010-12-02 0:29 ` Shaohua Li
2010-12-02 0:54 ` Minchan Kim
2010-12-02 1:05 ` Shaohua Li
2010-12-02 1:23 ` Minchan Kim
2010-12-02 1:36 ` Minchan Kim
2010-12-02 9:42 ` Mel Gorman
2010-12-02 15:25 ` Minchan Kim
2010-12-02 2:39 ` Shaohua Li
2010-12-02 1:28 ` KOSAKI Motohiro
2010-12-02 10:12 ` Mel Gorman
2010-12-02 15:35 ` Minchan Kim
2010-12-02 15:42 ` Mel Gorman
2010-12-02 20:53 ` Simon Kirby
2010-12-03 12:00 ` Mel Gorman
2010-12-04 12:07 ` Simon Kirby
2010-12-06 12:03 ` Mel Gorman
2010-12-09 23:44 ` Simon Kirby
2010-12-10 11:32 ` Mel Gorman
2010-12-10 23:42 ` Simon Kirby
2010-12-14 9:52 ` Mel Gorman
2010-12-02 16:00 [PATCH] vmscan: " Minchan Kim
2010-12-03 12:11 ` Mel Gorman
2010-12-09 22:13 ` Andrew Morton
2010-12-10 3:53 ` Minchan Kim
2010-12-10 11:17 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTik5HW6XgTNwGk2_Q36T0RpGMaCouZcTT2L5nfCd@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox