From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id 666508D0039 for ; Wed, 9 Feb 2011 23:44:11 -0500 (EST) Received: by iwc10 with SMTP id 10so907132iwc.14 for ; Wed, 09 Feb 2011 20:44:10 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1297262537-7425-1-git-send-email-ozaki.ryota@gmail.com> <20110210085823.2f99b81c.kamezawa.hiroyu@jp.fujitsu.com> Date: Thu, 10 Feb 2011 13:44:09 +0900 Message-ID: Subject: Re: [PATCH] mm: Fix out-of-date comments which refers non-existent functions From: Minchan Kim Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Ryota Ozaki Cc: KAMEZAWA Hiroyuki , linux-mm@kvack.org, Andrew Morton , Rik van Riel , Andrea Arcangeli , Hugh Dickins , linux-kernel@vger.kernel.org On Thu, Feb 10, 2011 at 12:58 PM, Ryota Ozaki wrote= : > On Thu, Feb 10, 2011 at 8:58 AM, KAMEZAWA Hiroyuki > wrote: >> On Wed, =C2=A09 Feb 2011 23:42:17 +0900 >> Ryota Ozaki wrote: >> >>> From: Ryota Ozaki >>> >>> do_file_page and do_no_page don't exist anymore, but some comments >>> still refers them. The patch fixes them by replacing them with >>> existing ones. >>> >>> Signed-off-by: Ryota Ozaki >> >> Acked-by: KAMEZAWA Hiroyuki > > Thanks, Kamezawa-san. > >> >> It seems there are other ones ;) >> =3D=3D >> =C2=A0 =C2=A0Searched full:do_no_page (Results 1 - 3 of 3) sorted by rel= evancy >> >> =C2=A0/linux-2.6-git/arch/alpha/include/asm/ >> H A D =C2=A0 cacheflush.h =C2=A0 =C2=A066 /* This is used only in do_no_= page and do_swap_page. */ >> =C2=A0/linux-2.6-git/arch/avr32/mm/ >> H A D =C2=A0 cache.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 116 * This one is calle= d from do_no_page(), do_swap_page() and install_page(). >> =C2=A0/linux-2.6-git/mm/ >> H A D =C2=A0 memory.c =C2=A0 =C2=A0 =C2=A0 =C2=A02121 * and do_anonymous= _page and do_no_page can safely check later on). >> 2319 * do_no_page is protected similarly. > > Nice catch :-) Cloud I assemble all fixes into one patch? > > =C2=A0ozaki-r > When you resend the patch, Please Cc Jiri Kosina --=20 Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org