From: Minchan Kim <minchan.kim@gmail.com>
To: Ryota Ozaki <ozaki.ryota@gmail.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Fix out-of-date comments which refers non-existent functions
Date: Thu, 10 Feb 2011 13:44:09 +0900 [thread overview]
Message-ID: <AANLkTik36rhvou2Bu99LMkAXx+BYQJysPxZG1gAAJwyv@mail.gmail.com> (raw)
In-Reply-To: <AANLkTikdBhSWAoP6TDRExSV2rHmWDkEc0foSKvqJt=tx@mail.gmail.com>
On Thu, Feb 10, 2011 at 12:58 PM, Ryota Ozaki <ozaki.ryota@gmail.com> wrote:
> On Thu, Feb 10, 2011 at 8:58 AM, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>> On Wed, 9 Feb 2011 23:42:17 +0900
>> Ryota Ozaki <ozaki.ryota@gmail.com> wrote:
>>
>>> From: Ryota Ozaki <ozaki.ryota@gmail.com>
>>>
>>> do_file_page and do_no_page don't exist anymore, but some comments
>>> still refers them. The patch fixes them by replacing them with
>>> existing ones.
>>>
>>> Signed-off-by: Ryota Ozaki <ozaki.ryota@gmail.com>
>>
>> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> Thanks, Kamezawa-san.
>
>>
>> It seems there are other ones ;)
>> ==
>> Searched full:do_no_page (Results 1 - 3 of 3) sorted by relevancy
>>
>> /linux-2.6-git/arch/alpha/include/asm/
>> H A D cacheflush.h 66 /* This is used only in do_no_page and do_swap_page. */
>> /linux-2.6-git/arch/avr32/mm/
>> H A D cache.c 116 * This one is called from do_no_page(), do_swap_page() and install_page().
>> /linux-2.6-git/mm/
>> H A D memory.c 2121 * and do_anonymous_page and do_no_page can safely check later on).
>> 2319 * do_no_page is protected similarly.
>
> Nice catch :-) Cloud I assemble all fixes into one patch?
>
> ozaki-r
>
When you resend the patch, Please Cc Jiri Kosina <trivial@kernel.org>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-10 4:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 14:42 Ryota Ozaki
2011-02-09 23:58 ` KAMEZAWA Hiroyuki
2011-02-10 3:58 ` Ryota Ozaki
2011-02-10 4:16 ` KAMEZAWA Hiroyuki
2011-02-10 4:44 ` Minchan Kim [this message]
2011-02-10 4:56 ` Ryota Ozaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTik36rhvou2Bu99LMkAXx+BYQJysPxZG1gAAJwyv@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ozaki.ryota@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox