From: Minchan Kim <minchan.kim@gmail.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Ben Gamari <bgamari.foss@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Wu Fengguang <fengguang.wu@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Nick Piggin <npiggin@kernel.dk>
Subject: Re: [PATCH v4 4/7] Reclaim invalidated page ASAP
Date: Tue, 14 Dec 2010 11:34:11 +0900 [thread overview]
Message-ID: <AANLkTi=kBwNQjQ0XBo9Fu5dbUtZ4wBy11K4vU1Kfo6QK@mail.gmail.com> (raw)
In-Reply-To: <20101214110711.af70b5b0.kamezawa.hiroyu@jp.fujitsu.com>
On Tue, Dec 14, 2010 at 11:07 AM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Tue, 14 Dec 2010 00:31:05 +0900
> Minchan Kim <minchan.kim@gmail.com> wrote:
>
>> Test Environment :
>> DRAM : 2G, CPU : Intel(R) Core(TM)2 CPU
>> Rsync backup directory size : 16G
>>
>> rsync version is 3.0.7.
>> rsync patch is Ben's fadivse.
>> stress scenario do following jobs with parallel.
>>
>> 1. make all -j4 linux, git clone linux-kernel
>> 2. git clone linux-kernel
>> 3. rsync src dst
>>
>> nrns : no-patched rsync + no stress
>> prns : patched rsync + no stress
>> nrs : no-patched rsync + stress
>> prs : patched rsync + stress
>>
>> pginvalidate : the number of dirty/writeback pages which is invalidated by fadvise
>> pgreclaim : pages moved PG_reclaim trick in inactive's tail
>>
>> In summary, my patch enhances a littie bit about elapsed time in
>> memory pressure environment and enhance reclaim effectivness(reclaim/reclaim)
>> with x2. It means reclaim latency is short and doesn't evict working set
>> pages due to invalidated pages.
>>
>> Look at reclaim effectivness. Patched rsync enhances x2 about reclaim
>> effectiveness and compared to mmotm-12-03, mmotm-12-03-fadvise enhances
>> 3 minute about elapsed time in stress environment.
>> I think it's due to reduce scanning, reclaim overhead.
>>
>> In no-stress enviroment, fadivse makes program little bit slow.
>> I think because there are many pgfault. I don't know why it happens.
>> Could you guess why it happens?
>>
>> Before futher work, I hope listen opinions.
>> Any comment is welcome.
>>
>
> At first, the improvement seems great. Thank you for your effort.
Thanks, Kame.
>
>> In no-stress enviroment, fadivse makes program little bit slow.
>> I think because there are many pgfault. I don't know why it happens.
>> Could you guess why it happens?
>>
>
> Are there no program which accesses a directory rsync'ed ?
Maybe. some programs might have mmaped files.
But although it happens, deactivate_page found that and it does
nothing so the page can't be reclaimed.
>
> Thanks,
> -Kame
>
>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-14 2:34 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 17:29 [PATCH v4 0/7] f/madivse(DONTNEED) support Minchan Kim
2010-12-05 17:29 ` [PATCH v4 1/7] Fix checkpatch's report in swap.c Minchan Kim
2010-12-06 1:47 ` Rik van Riel
2010-12-07 14:37 ` Johannes Weiner
2010-12-05 17:29 ` [PATCH v4 2/7] deactivate invalidated pages Minchan Kim
2010-12-06 14:53 ` Mel Gorman
2010-12-07 14:49 ` Johannes Weiner
2010-12-07 15:07 ` Minchan Kim
2010-12-07 15:19 ` Johannes Weiner
2010-12-07 15:26 ` Minchan Kim
2010-12-07 15:56 ` Johannes Weiner
2010-12-07 22:51 ` Minchan Kim
2010-12-08 0:56 ` KAMEZAWA Hiroyuki
2010-12-08 1:43 ` Minchan Kim
2010-12-08 1:56 ` KAMEZAWA Hiroyuki
2010-12-08 2:15 ` Minchan Kim
2010-12-08 6:56 ` Balbir Singh
2010-12-09 0:19 ` Minchan Kim
2010-12-05 17:29 ` [PATCH v4 3/7] move memcg reclaimable page into tail of inactive list Minchan Kim
2010-12-06 0:04 ` KAMEZAWA Hiroyuki
2010-12-06 3:04 ` Rik van Riel
2010-12-07 0:17 ` Minchan Kim
2010-12-06 3:34 ` Balbir Singh
2010-12-07 0:20 ` Minchan Kim
2010-12-07 14:52 ` Johannes Weiner
2010-12-08 8:08 ` KOSAKI Motohiro
2010-12-05 17:29 ` [PATCH v4 4/7] Reclaim invalidated page ASAP Minchan Kim
2010-12-07 15:05 ` Johannes Weiner
2010-12-07 15:21 ` Minchan Kim
2010-12-08 8:04 ` KOSAKI Motohiro
2010-12-08 8:16 ` Minchan Kim
2010-12-08 13:01 ` Ben Gamari
2010-12-08 23:10 ` Minchan Kim
2010-12-13 15:31 ` Minchan Kim
2010-12-13 20:06 ` Ben Gamari
2010-12-14 2:36 ` Minchan Kim
2011-07-25 3:08 ` Ben Gamari
2011-07-25 3:47 ` Minchan Kim
2010-12-14 2:07 ` KAMEZAWA Hiroyuki
2010-12-14 2:34 ` Minchan Kim [this message]
2010-12-05 17:29 ` [PATCH v4 5/7] add profile information for invalidated page reclaim Minchan Kim
2010-12-06 3:24 ` Rik van Riel
2010-12-08 8:02 ` KOSAKI Motohiro
2010-12-08 8:13 ` Minchan Kim
2010-12-08 8:36 ` KOSAKI Motohiro
2010-12-05 17:29 ` [PATCH v4 6/7] Remove zap_details NULL dependency Minchan Kim
2010-12-06 3:25 ` Rik van Riel
2010-12-07 4:26 ` Hugh Dickins
2010-12-07 5:30 ` Minchan Kim
2010-12-05 17:29 ` [PATCH v4 7/7] Prevent activation of page in madvise_dontneed Minchan Kim
2010-12-07 4:48 ` Hugh Dickins
2010-12-07 5:44 ` Minchan Kim
2010-12-08 7:26 ` Hugh Dickins
2010-12-08 7:55 ` Minchan Kim
[not found] ` <AANLkTim71krrCcmhTTCZTzxeUDkvOdBTOkeYQu6EXt32@mail.gmail.com>
2010-12-07 1:52 ` [PATCH v4 0/7] f/madivse(DONTNEED) support Ben Gamari
2010-12-07 2:16 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=kBwNQjQ0XBo9Fu5dbUtZ4wBy11K4vU1Kfo6QK@mail.gmail.com' \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bgamari.foss@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@kernel.dk \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox