From: Venkatesh Pallipadi <venki@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ying Han <yinghan@google.com>,
Minchan Kim <minchan.kim@gmail.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] vmscan: prevent background aging of anon page in no swap system
Date: Fri, 3 Sep 2010 18:12:03 -0700 [thread overview]
Message-ID: <AANLkTi=gDnMjTfC756wABD_K6evk+hEOtp_7JVvnwjki@mail.gmail.com> (raw)
In-Reply-To: <20100903145646.15063c1d.akpm@linux-foundation.org>
On Fri, Sep 3, 2010 at 2:56 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Fri, 3 Sep 2010 14:47:03 -0700
> Ying Han <yinghan@google.com> wrote:
>
>> > We don't have any quantitative data on the effect of these excess tlb
>> > flushes, which makes it difficult to decide which kernel versions
>> > should receive this patch.
>> >
>> > Help?
>>
>> Andrew:
>>
>> We observed the degradation on 2.6.34 compared to 2.6.26 kernel. The
>> workload we are running is doing 4k-random-write which runs about 3-4
>> minutes. We captured the TLB shootsdowns before/after:
>>
>> Before the change:
>> TLB: 29435 22208 37146 25332 47952 43698 43545 40297 49043 44843 46127
>> 50959 47592 46233 43698 44690 TLB shootdowns [HSUM = 662798 ]
>>
>> After the change:
>> TLB: 2340 3113 1547 1472 2944 4194 2181 1212 2607 4373 1690 1446 2310
>> 3784 1744 1134 TLB shootdowns [HSUM = 38091 ]
>
> Do you have data on how much additional CPU time (and/or wall time) was
> consumed?
>
Just reran the workload to get this data
- after - before of /proc/interrupts:TLB
- after - before of /proc/stat:cpu
(output is: "cpu" user nice sys idle iowait irq softirq steal guest guestnice)
Without this change
TLB: 28550 21232 33876 14300 40661 43118 38227 34887 34376 38208 35735
33591 36305 43649 36558 42013 TLB shootdowns [HSUM = 555286 ]
cpu 41056 381 17945 308706 26447 39 9713 0 0 0
With this change
TLB: 660 1088 761 474 778 1050 697 551 712 1353 651 730 788 1419 574
521 TLB shootdowns [HSUM = 12807 ]
cpu 40375 231 16622 204115 19317 36 9464 0 0 0
This is on a 16 way system, so 16 * 100 count in cpu line above counts as 1s.
I don't think all the reduction in CPU time (especially idle time!)
can be attributed to this change. There is some run to run variation
especially with the setup and teardown of the tests. But, there is a
notable reduction in user, system and irq time. For what its worth,
for this particular workload, throughput number reported by the run is
4% up.
Thanks,
Venki
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-09-04 1:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-29 15:43 Minchan Kim
2010-08-29 15:49 ` Rik van Riel
2010-08-29 17:45 ` Ying Han
2010-08-29 20:03 ` Rik van Riel
2010-08-29 20:56 ` Ying Han
2010-08-29 21:23 ` Ying Han
2010-08-29 22:26 ` Rik van Riel
2010-08-30 0:18 ` Minchan Kim
2010-08-30 5:40 ` Ying Han
2010-08-30 6:16 ` Minchan Kim
2010-08-31 0:56 ` KOSAKI Motohiro
2010-08-31 1:10 ` Minchan Kim
2010-08-31 1:18 ` KOSAKI Motohiro
2010-08-31 1:36 ` Minchan Kim
2010-08-31 1:41 ` KOSAKI Motohiro
2010-08-31 0:56 ` KOSAKI Motohiro
2010-08-31 1:23 ` Minchan Kim
2010-08-31 1:38 ` KOSAKI Motohiro
2010-08-31 2:02 ` Minchan Kim
2010-08-31 2:09 ` KOSAKI Motohiro
2010-08-31 3:47 ` Minchan Kim
2010-08-31 2:30 ` Rik van Riel
2010-08-31 3:46 ` Minchan Kim
2010-09-03 21:06 ` Andrew Morton
2010-09-03 21:23 ` Rik van Riel
2010-09-03 21:45 ` Ying Han
2010-09-03 21:47 ` Ying Han
2010-09-03 21:56 ` Andrew Morton
2010-09-04 1:12 ` Venkatesh Pallipadi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=gDnMjTfC756wABD_K6evk+hEOtp_7JVvnwjki@mail.gmail.com' \
--to=venki@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox