From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id 570AD8D0039 for ; Mon, 7 Mar 2011 04:22:25 -0500 (EST) Received: by yxt33 with SMTP id 33so2019218yxt.14 for ; Mon, 07 Mar 2011 01:22:23 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1299343345-3984-9-git-send-email-cesarb@cesarb.net> References: <1299343345-3984-1-git-send-email-cesarb@cesarb.net> <1299343345-3984-9-git-send-email-cesarb@cesarb.net> Date: Mon, 7 Mar 2011 11:22:23 +0200 Message-ID: Subject: Re: [PATCHv2 08/24] sys_swapon: move setting of error nearer use From: Pekka Enberg Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Cesar Eduardo Barros Cc: linux-mm@kvack.org, Andrew Morton , Hugh Dickins , KAMEZAWA Hiroyuki , Minchan Kim , Jens Axboe , linux-kernel@vger.kernel.org, Eric B Munson On Sat, Mar 5, 2011 at 6:42 PM, Cesar Eduardo Barros wrote: > Move the setting of the error variable nearer the goto in a few places. > > Avoids calling PTR_ERR() if not IS_ERR() in two places, and makes the > error condition more explicit in two other places. > > Signed-off-by: Cesar Eduardo Barros > Tested-by: Eric B Munson > Acked-by: Eric B Munson Reviewed-by: Pekka Enberg -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org