From: Greg Thelen <gthelen@google.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] memcg: break out event counters from other stats
Date: Wed, 16 Feb 2011 23:10:03 -0800 [thread overview]
Message-ID: <AANLkTi=UG3HcuvS0VEgUt27EX9rYguzmhRk4NtNeXfci@mail.gmail.com> (raw)
In-Reply-To: <20110217144116.58d71a7d.kamezawa.hiroyu@jp.fujitsu.com>
On Wed, Feb 16, 2011 at 9:41 PM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Thu, 17 Feb 2011 14:33:15 +0900
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>
>> On Wed, 16 Feb 2011 21:34:01 -0800
>> Greg Thelen <gthelen@google.com> wrote:
>>
>> > From: Johannes Weiner <hannes@cmpxchg.org>
>> >
>> > For increasing and decreasing per-cpu cgroup usage counters it makes
>> > sense to use signed types, as single per-cpu values might go negative
>> > during updates. But this is not the case for only-ever-increasing
>> > event counters.
>> >
>> > All the counters have been signed 64-bit so far, which was enough to
>> > count events even with the sign bit wasted.
>> >
>> > The next patch narrows the usage counters type (on 32-bit CPUs, that
>> > is), though, so break out the event counters and make them unsigned
>> > words as they should have been from the start.
>> >
>> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
>> > Signed-off-by: Greg Thelen <gthelen@google.com>
>>
>> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>>
>
> Hmm..but not mentioning the change "s64 -> unsigned long(may 32bit)" clearly
> isn't good behavior.
>
> Could you clarify both of changes in patch description as
> ==
> This patch
> - devides counters to signed and unsigned ones(increase only).
> - makes unsigned one to be 'unsigned long' rather than 'u64'
> and
> - then next patch will make 'signed' part to be 'long'
> ==
> for changelog ?
>
> Thanks,
> -Kame
Thanks for the review.
I will resent patches with the enhanced description.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-17 7:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 5:34 [PATCH v2 0/2] memcg: variable type fixes Greg Thelen
2011-02-17 5:34 ` [PATCH v2 1/2] memcg: break out event counters from other stats Greg Thelen
2011-02-17 5:33 ` KAMEZAWA Hiroyuki
2011-02-17 5:41 ` KAMEZAWA Hiroyuki
2011-02-17 7:10 ` Greg Thelen [this message]
2011-02-17 6:31 ` Balbir Singh
2011-02-17 5:34 ` [PATCH v2 2/2] memcg: use native word page statistics counters Greg Thelen
2011-02-17 5:35 ` KAMEZAWA Hiroyuki
2011-02-17 6:28 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=UG3HcuvS0VEgUt27EX9rYguzmhRk4NtNeXfci@mail.gmail.com' \
--to=gthelen@google.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox