From: Eric B Munson <emunson@mgebm.net>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Petr Holasek <pholasek@redhat.com>,
linux-kernel@vger.kernel.org, anton@redhat.com,
Andi Kleen <ak@linux.intel.com>, Mel Gorman <mel@csn.ul.ie>,
Wu Fengguang <fengguang.wu@intel.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] hugetlb: /proc/meminfo shows data for all sizes of hugepages
Date: Mon, 7 Mar 2011 18:24:58 -0500 [thread overview]
Message-ID: <AANLkTi=NjkQoLQX2ZYxb-oDN7x5TYybe=pMkpOeZDc-Q@mail.gmail.com> (raw)
In-Reply-To: <20110307231448.GA2946@spritzera.linux.bs1.fc.nec.co.jp>
2011/3/7 Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>:
>> >
>> > Could we do something where we keep the default hpage_size looking like
>> > it does now, but append the size explicitly for the new entries?
>> >
>> > HugePages_Total(1G): 2
>> > HugePages_Free(1G): 1
>> > HugePages_Rsvd(1G): 1
>> > HugePages_Surp(1G): 1
>> >
>>
>> Let's not change the existing interface, please.
>>
>> Adding new fields: OK.
>> Changing the way in whcih existing fields are calculated: OKish.
>> Renaming existing fields: not OK.
>
> How about lining up multiple values in each field like this?
>
> HugePages_Total: 5 2
> HugePages_Free: 2 1
> HugePages_Rsvd: 3 1
> HugePages_Surp: 1 1
> Hugepagesize: 2048 1048576 kB
> ...
>
> This doesn't change the field names and the impact for user space
> is still small?
>
> Thanks,
> Naoya
>
I don't like this either, Dave's suggestion impacts userspace the
least, as code that looks for default huge page size pool info will
still find it, but it won't match the sized entries. Your suggestion
means that I need to change how libhugetlbfs, for instance, parses
meminfo.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-07 23:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 13:05 Petr Holasek
2011-03-07 19:46 ` Dave Hansen
2011-03-07 20:13 ` Eric B Munson
2011-03-07 22:51 ` Andrew Morton
2011-03-07 23:14 ` Naoya Horiguchi
2011-03-07 23:24 ` Eric B Munson [this message]
2011-03-07 23:25 ` Andrew Morton
2011-03-07 23:47 ` David Rientjes
2011-03-08 0:57 ` Nishanth Aravamudan
2011-03-08 9:37 ` Mel Gorman
2011-03-08 11:21 ` Petr Holasek
2011-03-08 13:51 ` Eric B Munson
2011-03-08 1:26 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=NjkQoLQX2ZYxb-oDN7x5TYybe=pMkpOeZDc-Q@mail.gmail.com' \
--to=emunson@mgebm.net \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=anton@redhat.com \
--cc=dave@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=pholasek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox