From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id 0C4F16B0087 for ; Wed, 8 Dec 2010 17:27:31 -0500 (EST) Received: by iwn1 with SMTP id 1so2479974iwn.37 for ; Wed, 08 Dec 2010 14:25:18 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20101208164327.GL2356@cmpxchg.org> References: <1291734086-1405-1-git-send-email-minchan.kim@gmail.com> <20101208164327.GL2356@cmpxchg.org> Date: Thu, 9 Dec 2010 07:25:18 +0900 Message-ID: Subject: Re: [PATCH] compaction: Remove mem_cgroup_del_lru From: Minchan Kim Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org To: Johannes Weiner Cc: Andrew Morton , linux-mm , LKML , Balbir Singh , KAMEZAWA Hiroyuki , Mel Gorman List-ID: On Thu, Dec 9, 2010 at 1:43 AM, Johannes Weiner wrote: > On Wed, Dec 08, 2010 at 12:01:26AM +0900, Minchan Kim wrote: >> del_page_from_lru_list alreay called mem_cgroup_del_lru. >> So we need to call it again. It makes wrong stat of memcg and >> even happen VM_BUG_ON hit. >> >> Cc: Balbir Singh >> Cc: KAMEZAWA Hiroyuki >> Cc: Mel Gorman >> Signed-off-by: Minchan Kim > > Reviewed-by: Johannes Weiner > > But regarding the severity of this: shouldn't the second deletion > attempt be caught by the TestClearPageCgroupAcctLRU() early in > mem_cgroup_del_lru_list()? > Right, I missed that. Andrew, I will resend modified description. Thanks for careful review again, Hannes. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org