From: Michel Lespinasse <walken@google.com>
To: Nick Piggin <npiggin@kernel.dk>
Cc: Ying Han <yinghan@google.com>, Mel Gorman <mel@csn.ul.ie>,
Minchan Kim <minchan.kim@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Hugh Dickins <hughd@google.com>,
Nick Piggin <npiggin@gmail.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] Pass priority to shrink_slab
Date: Thu, 18 Nov 2010 02:24:31 -0800 [thread overview]
Message-ID: <AANLkTi=+S25eBw5+-bcFAwRLOH-LPh--Tg72rohZJvzX@mail.gmail.com> (raw)
In-Reply-To: <20101118085921.GA11314@amd>
On Thu, Nov 18, 2010 at 12:59 AM, Nick Piggin <npiggin@kernel.dk> wrote:
> FWIW, we can just add this to the new shrinker API, and convert over
> the users who care about it, so it doesn't have to be done in a big
> patch.
I also don't like that adding a shrinker parameter requires trivial
changes in every place that defines a shrinker.
I was wondering, could we just add a new structure for shrinker
parameters ? Your proposal of having parallel 'old' and 'new' APIs
works if this is a one-time change, but seems awkward if we want to
add additional parameters later on...
--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-18 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 4:34 Ying Han
2010-11-18 8:59 ` Nick Piggin
2010-11-18 10:06 ` Ying Han
2010-11-18 10:24 ` Michel Lespinasse [this message]
2010-11-19 22:25 ` Andrew Morton
2010-11-20 3:23 ` Ying Han
2010-11-22 23:06 ` Andrew Morton
2010-11-23 2:09 ` Michel Lespinasse
2010-11-23 2:26 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=+S25eBw5+-bcFAwRLOH-LPh--Tg72rohZJvzX@mail.gmail.com' \
--to=walken@google.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=npiggin@gmail.com \
--cc=npiggin@kernel.dk \
--cc=riel@redhat.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox