From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ED29E6C5F6 for ; Tue, 3 Dec 2024 03:30:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DB4D6B007B; Mon, 2 Dec 2024 22:30:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 88A1D6B0083; Mon, 2 Dec 2024 22:30:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 778996B0085; Mon, 2 Dec 2024 22:30:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5A4A66B007B for ; Mon, 2 Dec 2024 22:30:01 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CEBD2C058E for ; Tue, 3 Dec 2024 03:30:00 +0000 (UTC) X-FDA: 82852218582.26.BAB0D43 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 2947140007 for ; Tue, 3 Dec 2024 03:29:48 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=LAT8xmvO; spf=pass (imf01.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733196586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iMgSJ91ORzybZ/bsKAB2UtN/3yvFAjfo18ipsdZKQm8=; b=0v/Xwnq0m/1ZU6MU9rjCR/AIGgAhLkC66p//bey31kW79NQyVF0s9rTEtAcEl3B7iaZzm0 Vz8VScXGG59aintWXHSSaMEPLfsf+3H2mkmXHpyavxjPzxRKReEgcCmFoNYw/Qgh8xqbf2 ojuMBlZjNGPoQHNwagQK3GsoMdvPi4s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733196586; a=rsa-sha256; cv=none; b=g6elpOnbhoKvxEMfMV6Sf8sTT5ofSL7PSWKnj8Nzg76Q5DqbaoAXfAYQX6OrTq4tSvzsUM fZqbLk7FNzbxWBYSu2ZBu+fv5vPg0BHw2KW83z6xIHjDu5v7qCRZbTpBKMKYlEt5aepTI9 9jcTu2X4idjCU4DyrmnWeuDaSD8JLd0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=LAT8xmvO; spf=pass (imf01.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1733196597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iMgSJ91ORzybZ/bsKAB2UtN/3yvFAjfo18ipsdZKQm8=; b=LAT8xmvOwCkGv14e2zGAcT75jRE4HmVN8ge+5NwURYf6iEk1qlZlyQaGvN3+qkxFQjS2nK k2MqM8LGkEFb5K76tirZCHOhcv1gMaFoivHWTVjSlUcFuOI+wl4ZVnXUaAWWuxmZyiLs4d O0GtW+f0wxRtG9aBjsZMLUrWhjr8Fqc= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.200.121\)) Subject: Re: [PATCH V2] mm/hugetlb: Make __NR_USED_SUBPAGE check conditional X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20241203023207.123416-1-anshuman.khandual@arm.com> Date: Tue, 3 Dec 2024 11:29:18 +0800 Cc: linux-mm@kvack.org, Andrew Morton , Oscar Salvador , linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20241203023207.123416-1-anshuman.khandual@arm.com> To: Anshuman Khandual X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 2947140007 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: r9eyfitbgk5awqwqa69seeptqegzsiw9 X-HE-Tag: 1733196588-275330 X-HE-Meta: U2FsdGVkX1+vapG3cbiUko811kilj9OjGLerfO4e+eFiw+FqM8p+W4mmmOcBkTeHBU91f9wStGFVKueNWENOTmp7GiKZlnKjLLceqc3VBTVjq7lFDYwbb0Tztq8B/sopELBhOxuS5l67lsiymwfocajW0Bj/78Im7+0o09CAiwrP2esFHKFEoLCoqBNKaqJ1RiRnLKT0EOsuCNzuBrUqvj11MY6tGsWRK09V7FOxRM/JT3BI9AOUba8B/HTRnrJtVbZq8L5eGbQ6sECcVB1y0T9U8NIkOhKBTgtbZfxk5BpCrXpGc4UOY6mgZyUJgccDuYG6IQsgWWMYfzn9a9IuRlcxEeAQ3FYOJzO3PhcC8prar/KIEhsz8kUBw1haQTDigIoDbMmdNTeT8kCsKJvbw7gkq0PJXD/qe6W76GAe3wKCUACxDCi4B1gdkE4vay4cxTFdEXRiTFcMRA1Q9US7mHdso6p2CaD9OQyp1vpC1TizN/28Dw4Y0WgPgqrR+SOirtXo8H9C2w1DTtmMIveiNZtOFaTs/G9AyCEU7jJrLEW/z38OJ8JPOt9KaoPZnSYwzTHclbuveJ41V4y0hHJQLVgsIn/r6SpZdiJ6ezj7WF+aOvxrIK3ajrBizuc3SiP0+B7CV7KofoavUjx9J4mP5yHckwxrZNXFmiWpNILSmV6xg8RKNjku9zGl0Aqor54XdXqXbg5z9cW0MMHjde9H8as+edqbYtbR/bR0M+h5MKQ34axFrTSvbhta+fdzUXtakPSc0Fbv0h9Erb3yNth+DtH2ZTJQxGEQjJSE+4u2OUn4AVfw2bfKAPeoary4WHk8kndODQ0MHF+8IYYQj8F8+r7QTFxfoWsZxzKXVZPkq4c5PtKlQHUzJxkMmnUy/yJWyU3NaqQynAwKbuKQ6y4DD1qfmxAiiE1jyTFJzzXs+1XoR41ZVHUrfUpUucHITLvmI80ext0YnIohRd9PHr2 K+SDxT7y 7n2mZ3s2sx+GV66v84iEJKBn0kPjvvt1pkUPryQf11zJOaWaypJFbLdwGGUbgJT0cNGNBiE5KfGrUBPNfKlYVd3qPCfdFz0RtuSD6nchoU5YQ2uOrv5WsjtRNtBXmss7MfJJ2ZZfNoq+RYndFMVYiykymXeJMJ4h/HEjrvLa4Ezby/2rz3BO9bj5XHofPN/l6mX645QmIJoMx7rA9ztoNQzZ4huz32meTpCC1cT2QVb4nVMl8EaxVdUbO9nLWOp0RJAxRtyxN/siiMYv+1vGIRZXkUu+FoWtLoxAjtNniPkIZtLBBwBzHg4PWNDV2WLLr/l1oHRPGjteq9i/gMIiKhg6nfRSva1UmgWLxv/9n7Q27lkW0GW1WgnwwNqbyaF+eJB4G7eqiLf6mdm1jdouSzo99lNsCDND399LtNeg7bIGCEx4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Dec 3, 2024, at 10:32, Anshuman Khandual = wrote: >=20 > The HugeTLB order check against __NR_USED_SUBPAGE is required only = when > HUGETLB_PAGE_OPTIMIZE_VMEMMAP is enabled. Hence BUG_ON() trigger = should > happen only when applicable. >=20 > Cc: Muchun Song > Cc: Andrew Morton > Cc: Oscar Salvador > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > This patch applies on v6.13-rc1 >=20 > Changes in V2: >=20 > - Fixed #ifdef with CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP per Oscar >=20 > Changes in V1: >=20 > = https://lore.kernel.org/all/20241202090728.78935-1-anshuman.khandual@arm.c= om/ >=20 > mm/hugetlb.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index ea2ed8e301ef..e6a5b21e3578 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -4513,11 +4513,13 @@ void __init hugetlb_add_hstate(unsigned int = order) > struct hstate *h; > unsigned long i; >=20 > - if (size_to_hstate(PAGE_SIZE << order)) { > + if (size_to_hstate(PAGE_SIZE << order)) > return; > - } > + > BUG_ON(hugetlb_max_hstate >=3D HUGE_MAX_HSTATE); > +#ifdef CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP > BUG_ON(order < order_base_2(__NR_USED_SUBPAGE)); Hi Anshuman, __NR_USED_SUBPAGE indicates how many struct pages are used to store extra metadata for a HugeTLB page. So we need to make sure the order of a HugeTLB page should be bigger than or equal to = order_base_2(__NR_USED_SUBPAGE). So It is not related to HVO. I don't think the changes make sense. Thanks. > +#endif > h =3D &hstates[hugetlb_max_hstate++]; > __mutex_init(&h->resize_lock, "resize mutex", &h->resize_key); > h->order =3D order; > --=20 > 2.30.2 >=20