From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97F15C67861 for ; Fri, 5 Apr 2024 16:34:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 039386B0083; Fri, 5 Apr 2024 12:34:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2BA96B0085; Fri, 5 Apr 2024 12:34:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCBDD6B0087; Fri, 5 Apr 2024 12:34:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C14B26B0083 for ; Fri, 5 Apr 2024 12:34:45 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5832C1A11B0 for ; Fri, 5 Apr 2024 16:34:45 +0000 (UTC) X-FDA: 81976026930.15.CAD2646 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2093.outbound.protection.outlook.com [40.107.244.93]) by imf13.hostedemail.com (Postfix) with ESMTP id 868EA2000C for ; Fri, 5 Apr 2024 16:34:42 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=sBt+GLTR; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf13.hostedemail.com: domain of ziy@nvidia.com designates 40.107.244.93 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712334882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zeMWC+EMfUmSx8yNHYZLPq+kjCrwDU7YaKm99KALpuI=; b=si5C+PifnQn13aczr/7xLI8SIknHaO8wV2qzaZd1JeKZBcjfe7HFnKR0Bl+BmM9gyMnZFf hAa3AI43efDXi49723r/89CO0jo1+N/RbtCYZblhBbAPi1kLrubXLCJ6qqd2M1Zj+8UFVR TSxiop5WtpVB1EteZdPdMb3p63h6F20= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=sBt+GLTR; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf13.hostedemail.com: domain of ziy@nvidia.com designates 40.107.244.93 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712334882; a=rsa-sha256; cv=pass; b=u5WFGNoc9kL1NsQV98xVzBKPYmbR+pRDhGtUKmF2MWQ2yDWkYmZ+0Zlpxz/lC8j4hqBRNe 2SFlZeFZETEN2R5DA9stnMusYT1g7i7apEJGpqsyWooSzUfD9j1N891BlsATo/BlC5gGw5 fgirYqv+WH2U95xdAjlts0g1Bl27tBc= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ilx6zk8u5Q8vKBp2uaXg+t/0UV0AK8m7kwd4PFsl8fSvbJpWqud6um43SweTa3aPP3M8tKeF0N0r46z0CH3EzCVfBDHmMwJfZffKkikM4YfBFkXKr+04lckksRhnGa4hGksziF2X52uKCDDAU5aSXGBMVPo8kPXdZBqTCxXhpRYgaeVoHKN+2gu7ohu3zHga9NjsCRZaxVKWU06GBCnSY72fJy8NP8QsK8B0EsDV/bkktdkMICh0A0/X+1y4iXQEdmctIELBfeCxWegCHmx5/EREHkHdByMVL4cW/hlRrLMya85M/MmLpUBTA07GELeUFMM/ZK7d+4ThP2vsknGsLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zeMWC+EMfUmSx8yNHYZLPq+kjCrwDU7YaKm99KALpuI=; b=F9CMpjYBmRRgp56ft9TgAlGGAzwJN4rN3YC22deyDW7a8dBC32AxMYO+DVcdzLe/ZK+k6tXOUS80RKCV3Zz84J1xZL+YfBQ+rOR1pwRtTEFEb/UORxNhGMbn0D3f/NRLaTTazqdjaDVm9RhUr+lPx6RwC0LZe/ufi9dBmqIpGpdYqEoi2pW1XNGTX5NDz6nwzJbhs8xfdd02W5xFm9YjtWkdGsLlVnfUBFC3+dJuh69mE6enrtqWijrhrlyzOtwtKwy7i7ECjAxjBNxjl6YbBQgA1yhrPZW4qIYI7VW5z27UtayOesw/lgPFjeCfuo1o+TQ3QFo2lRO+L+8P8in+zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zeMWC+EMfUmSx8yNHYZLPq+kjCrwDU7YaKm99KALpuI=; b=sBt+GLTRE0sGPTJ2XBjpXJBBzFSDHeusX8ZyKk8K/37we8FB2wSAA7/Qp1GVIiC5ett0Yo5bCT49V5pcAiO2GjdZEE3bDxhljahpEhREY7iN7KWYcyhFt+zxPul23Sv0Jx49iY3gf9VT6zgAsyXc758AKoEZa3fs7SHeh2UutVzFEzi/uqvSEjJqn2FJlFwILbsgbNhjoE26LKk6axhpuma6fzqNUdF5ufkuDacCp83pbxgBppopbngiWJqNK3AQ/RO4VFMfC7B24K0rMmjnjXituYqdSxFe3s8HNiGg0ZI+t2Ei20jztr1Z8JqS/TEm7/nYE8oicQsdtz8z0YFWkg== Received: from DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) by DM6PR12MB4218.namprd12.prod.outlook.com (2603:10b6:5:21b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 5 Apr 2024 16:34:39 +0000 Received: from DS7PR12MB5744.namprd12.prod.outlook.com ([fe80::dc5c:2cf1:d5f5:9753]) by DS7PR12MB5744.namprd12.prod.outlook.com ([fe80::dc5c:2cf1:d5f5:9753%6]) with mapi id 15.20.7409.042; Fri, 5 Apr 2024 16:34:39 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 0/5] Clean up __folio_put() Date: Fri, 05 Apr 2024 12:34:37 -0400 X-Mailer: MailMate (1.14r6028) Message-ID: In-Reply-To: <20240405153228.2563754-1-willy@infradead.org> References: <20240405153228.2563754-1-willy@infradead.org> Content-Type: multipart/signed; boundary="=_MailMate_AC3478F0-2BD2-4FDD-918A-1618C9D49919_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ClientProxiedBy: MN2PR05CA0016.namprd05.prod.outlook.com (2603:10b6:208:c0::29) To DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5744:EE_|DM6PR12MB4218:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G68/FUrC8trMuhQvkdeJTtedqqAUqs83P1gX1cW8HmViXmwnt41iW/gUUUCltTmZyxJVtS91tISKfWiNchDf+MpaFN01zBZUr4nRAajPKvAuB1TMBnr0zsZgSx/ugukQlYjXcCmBfJXtqWxreIY1JzQnAU8Oa2YQUcq2Vmgr+plOjDdnpuZ93+Bla25SMnee8vCO+HAppNqFBaOFg46+CBhDi0sIetQsmFIF9DIaoamnlXn/eDj9cBiijN2bNil3W4M5jAduwTlZDb46jKaIRfQwyUdDRm569BI2J1DnebgPTVA9KduWqWob4CCOWZ3Kic6aWz7+4yyCXe6KAFN1tu9gLZrONNL8nu+l2dnWxTeX31h+yAiuTgcD5f92STt9Jvz6pg7j/QQzTeRbJRtnzfErfj66q8tegK3u0Bjhw21P3KCl8g5qRrCF4VAKbX1jivyPSAP+dGLZbdGtSH0mXuVRqR8ywllUicWGO7+yJ8cY+M0kYN/2Dtlu8WQXL21b6LFsVzxQXfjlYDw3HnBHA9LS0WwrRtNZJuxzk2AsVLm4ieaNQvijsJIsDxDwcJ+gWnQ3MPUb4KojCIEdomNqGfaxEZzgfayjUAfPrbApdTiwUMdwyFndQw1OaaftctcB06egQl8xHDAzanGNJQ05XdpuvfhvOBJJRk0jFxmhzJY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB5744.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+k5hhP+zxo+mJ182MGYWx8JOxuhe1k6KbjxTplFY8efPdPsQDcb9b2QDEDsE?= =?us-ascii?Q?XNqF9kNv3GK366cuRkDd1ht8aldZmpU4gLPBHGyqFT7fL6gM8r9nTIDxT/Ij?= =?us-ascii?Q?P5RlbB4pvjv0oU3KOLa8knnrz7Wog+WzZcCX22A8RI8yDzMPsbSFUmG1NgjP?= =?us-ascii?Q?cv1ggmA7vlZftarCP7Bsex+QH4Y0tD70xr8uwld+Op7IKlPfDSAyv9+breGl?= =?us-ascii?Q?LTvKkU9OERFJlSs3tTcJV08Djj8D+HT3TxHE+g+C0qCmkPiiLCYXtX1hmD54?= =?us-ascii?Q?pHRpT5+Cu9arxPx47VSiVv0dPdESTPQF6b3R9ZJ3lmzEbaXHsN7bRn1yGO79?= =?us-ascii?Q?HxKS6fR+65fRL1H/ZYMaDgpQgrdCIMYoU2T81KieLl1jDLNg1Si6M8Z5vAie?= =?us-ascii?Q?VlcnKRPNhW3HGXlUI5MtVJv6MqpNKu0TUfxFpqhjKoONKtvFSIDxhckac2Jk?= =?us-ascii?Q?SYxLlrpb32IUx3Tl+74iQtYNZyAz71R7vanZ6ZAblnlKZOIHh44q7oz/sJYl?= =?us-ascii?Q?pSeCwzCmA2ppkdvT4Lyq4Vgg9vmmVr56hJNIuUkKBkqtWot8NFLYMjwjhS0g?= =?us-ascii?Q?yQL12O84RLfEahydrZj8mCugxIyO+AhTTlJdthVYbCRmC7+DoNRHicOwjCXH?= =?us-ascii?Q?XPJA8NVOifNId2+cQzxg4pD+1VbPMREd1DLoyqNAXBjZiNRef+3I9amwvCea?= =?us-ascii?Q?q+47o7mIWKCJbWIdxULCHT9MfXoa1dL5eB3HsVNqv6BJYypyvr1yuLBI2+Nf?= =?us-ascii?Q?I+CUwNOLRxAFER2HqoKtv/o+aBMMm4hgT55lNVTOUkzq4F9B+82MuddcbTKM?= =?us-ascii?Q?uaDNCpOsnWfVFJxgrKUOZJ1XZlbYQqq/RN3DYZa8kutjwU99Jn+fhXgcWbOI?= =?us-ascii?Q?G0Kt2ahebPD/l65PIXTNorkg67LN2YnBeXbQ3Qfj1DJJNQpY5CcClaPsafkJ?= =?us-ascii?Q?pic1JYlstjVcKM7SXGkkaDFEoLnAmn2Sj0l0nbwGkPKXw+eCc7ad2puQPmyB?= =?us-ascii?Q?KbdRR3knD1N4bop+Z6ojqXlcPPC6tezQqh7Zcu1l85GhVb5MDku0Wk35Yesh?= =?us-ascii?Q?Ns6SfXEDoP/9UxfMLXlZm5EsGL9bPx/Xn9Laa5A19FydzxEk+OvMR0SnUaAa?= =?us-ascii?Q?rbNEBth+k+MSC9mAeFBKSMRNFwxRb4cc/sZ7ytQngVrUvmr4RyTZn9c/Lh3R?= =?us-ascii?Q?rvd2KOvCzvrMtM6YsSsjvGXnb/kkBqhGvA+udkJgN45uLw1tg7tAuk6PazSa?= =?us-ascii?Q?QyHvgYcHfsOjw/oqlCWt1/zbhmZqoEi9CC28le1/LM42V8fvgCKosOA40phT?= =?us-ascii?Q?c60zjXCFyy3wH6Ogt/vXtjOZNXlemler3VoANnrVz3G0AlxlbXfJbii8yCzL?= =?us-ascii?Q?NQyfH+dPFrd6CcWvjva+28f0J8xV9y9VIgOhv3GzU4ADNXIfdi2cJYnzGYAr?= =?us-ascii?Q?lpePzcLVEeeRYUcpjaR+goaYdb+DbANyVvZTMQKYvKcI/FSrCv0Ltsx18kmT?= =?us-ascii?Q?jqdnxUo32qLrmFwzmtXuNwdE8SDKofgzG7FFPu7kV6hIz3C9MtUOwxfR9g58?= =?us-ascii?Q?RYbhpO0jLd7Y8lhdRFc=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0567d6be-b63a-4383-f941-08dc558e49d8 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 16:34:39.3625 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KOyTzuXpSlAUGZRDJeGGQ+p4hg2ODBKbU3Bd51wB5Dyhq6P+TiH12REM4XdvxfgD X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4218 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 868EA2000C X-Stat-Signature: x16upqaz353wimzhsms6tjf6zxtbfa9d X-Rspam-User: X-HE-Tag: 1712334882-350974 X-HE-Meta: U2FsdGVkX19du3hoZaFgMd3G4z+vFxuCx5qJjQ/bHlUXugyeLzWKhjkKBOz9QIAWgB7lIHhpoJg/hR9fkFbgkv8Tmy9AWb7TKORkQ67SZ8fAhmBaE2iKKt2suIYTXtw2QSkK+3k5/ALqa2WjDHZ/bl0HBgB1O0lvTb81AWsC4nyjUbaUa8tPVQWGHiu5bINOWT3D+uiidMey4jLvQ5B6ChSIFFRNabZvMfBFOto5dxkfEKHD2UbcRGy95rO7IRGWtCIAUB6K4ZZnt6yzfdFjHZXHjUZ+C2xlZtF3dLfWgnharYsN0baw1VJyqkFfw0AUNgZu0z5HwzS1qR6BcgdjrclEAp53hQHF+1ZmfawcjpavilYgX4l51G2mnTTv2XfvC/xE/ScKvz/hMlNj1bikj5AEwglmkx8ZpkLOUZFiS11Cm3VT7AXfAFEzyEwk8jywrI/PYErMQ72CS5cAUeRgrf8XtYd1VlJFjFOxa5zJJ9gXMAr//wU7GGdv2SCk5ND9mFTACzzVqWo/6jL+Pj6WvzEHnXgGjKhT7hrJMmVpgZDs7gpuZY57m7AoWU6WsPsIt+Jotu8SdahxLHuPZm2t0WbqKiAyvy1i0KGeS0Alg4ackFpVlURcUlfCHVE1rByBTJdpWFiPHusvd4uPrEnFV1ITV0a3TdmAzsvtvw+9R14hUc5nE5IJAyOzpN39edwW9jUsfREWUSXX/VxS5CjnOiIwHfSMQSWlWxIpCKe/J/tYwjJrKS3eaeifXE9kVMXr6lrA6bSROG4VphzB/Q6Cay+6nlQYl+AymSIWfj8bFqblr3LtBhM01MLpr7+v6kMBK1qmLFZUFDUYSOU7EmTCa4pm9spF9U43oScPSk5lKmpfGgCQT4mfBAx7EAbihKig27V0sP2b4FFNOEJlgr+U6kLSGL9yaI19S4pGInzub0sEgQdyRAXvVV17w/n9YzpITjqQ+9hyPd0Xfu2xMoH 4NsPEbVk Pa0uWY23I8WmKWMWcZO6mAxP63I3BngeeaEotQdqdiNRBCXKFtN7u3t1md2rZEco0TMZIwDUHYlXq2utxBeEKNF0RW8u9fUDPx0vPmjTsdOCX0LNUPKo04NycIqc0s5A/MioaTbMcv5ABM/iiU9LvF1cubCb7osqcE33klB/R4rQssUeR/mb49Qf/+YxY1NnZckoZbqZPp+vGGLIFSk6s7pqfaX5T71IsyGH9ZTezMyut1w+bYx2DQWZqR0pJUWOowdJBT1OCi6loUjnrfC8V3aCPbRIVTnAB5EgnZbQti3GxgKsV4budhXmAz0p2zh6rhKsyYzfer/0W6uSEJw73zpOWM2dL205lFe1lpTjmDum0kOk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --=_MailMate_AC3478F0-2BD2-4FDD-918A-1618C9D49919_= Content-Type: text/plain On 5 Apr 2024, at 11:32, Matthew Wilcox (Oracle) wrote: > With all the changes over the last few years, __folio_put_small and > __folio_put_large have become almost identical to each other ... except > you can't tell because they're spread over two files. Rearrange it all > so that you can tell, and then inline them both into __folio_put(). > > Matthew Wilcox (Oracle) (5): > mm: Free non-hugetlb large folios in a batch > mm: Combine free_the_page() and free_unref_page() > mm: Inline destroy_large_folio() into __folio_put_large() > mm: Combine __folio_put_small, __folio_put_large and __folio_put > mm: Convert free_zone_device_page to free_zone_device_folio > > include/linux/mm.h | 2 -- > mm/internal.h | 2 +- > mm/memremap.c | 30 ++++++++++++++++-------------- > mm/page_alloc.c | 37 ++++++++++--------------------------- > mm/swap.c | 44 ++++++++++++++++---------------------------- > 5 files changed, 43 insertions(+), 72 deletions(-) The whole series looks good to me. Reviewed-by: Zi Yan -- Best Regards, Yan, Zi --=_MailMate_AC3478F0-2BD2-4FDD-918A-1618C9D49919_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmYQKB0PHHppeUBudmlk aWEuY29tAAoJEOJ/noEUByhUCo0P/2BVQbUe0Kt4s2EGN1DKuBJRBll4Sdu43k0G //JORFEMClIcarRAHrFIazqsQq8PCudLFWkqgjfdpiXHtqrMpn8piUVslSHJvg7y LSzhntlBD8C0f776y+A43PrYy4ijn9dKyKFPLaeajwelId2dkJh/YoLB/TbRSZXV F5oyvGI2LMah3Af5h7OsGaKpkLGJeQZu60SXALXtcDupP+9qXCsHxdVRlkKzP3wJ uEXQHI25ccdCdRm0GiNdBMJ5j3TJ9xtjpCPZ/9dFtZCe3WpwBN2SvwkeDHbVP1DM 2dD7YAhVMZDnTppJhy9GslQf0GHIk8D3bqYoRBZA7JH1cTK1gHLRj0ZAbuCJbg8m /7aNB2w8f2kCdJmNN4iztEmJhuEiBGWbAbZ4AeEXAJ+OJcf4RWbsd0KVzvtKse/N 1uHqC7IeyCvgXO75rFe3nkyaS6rEmcuPVYGX5LZ9ByvHbdpDvy7kJBn8m7i5snH5 roXIWww0sQBobZsN1bM4lS0Y8qFN/XJYCv1XszesbNnmNwBrwHhr4cGAGxQnqBjm ODXDYrUGjp3TNGuvWbl4ZZZ/ymPevVAMur8ps3NUg3+Lvmfe+SJGMvivAgTqYjLS XTVA0KHVmtH+grxpCxYuDCgN+oPWGtQpcvSgZfOiTXWKz2IQd7GZXXlWGmm/2uSD 1yzelx8F =9gPp -----END PGP SIGNATURE----- --=_MailMate_AC3478F0-2BD2-4FDD-918A-1618C9D49919_=--