linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Zi Yan <ziy@nvidia.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: Re: [PATCH 0/5] Clean up __folio_put()
Date: Fri, 05 Apr 2024 12:34:37 -0400	[thread overview]
Message-ID: <A9222E41-28D5-461D-BE2C-922274410127@nvidia.com> (raw)
In-Reply-To: <20240405153228.2563754-1-willy@infradead.org>

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

On 5 Apr 2024, at 11:32, Matthew Wilcox (Oracle) wrote:

> With all the changes over the last few years, __folio_put_small and
> __folio_put_large have become almost identical to each other ... except
> you can't tell because they're spread over two files.  Rearrange it all
> so that you can tell, and then inline them both into __folio_put().
>
> Matthew Wilcox (Oracle) (5):
>   mm: Free non-hugetlb large folios in a batch
>   mm: Combine free_the_page() and free_unref_page()
>   mm: Inline destroy_large_folio() into __folio_put_large()
>   mm: Combine __folio_put_small, __folio_put_large and __folio_put
>   mm: Convert free_zone_device_page to free_zone_device_folio
>
>  include/linux/mm.h |  2 --
>  mm/internal.h      |  2 +-
>  mm/memremap.c      | 30 ++++++++++++++++--------------
>  mm/page_alloc.c    | 37 ++++++++++---------------------------
>  mm/swap.c          | 44 ++++++++++++++++----------------------------
>  5 files changed, 43 insertions(+), 72 deletions(-)

The whole series looks good to me. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]

      parent reply	other threads:[~2024-04-05 16:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 15:32 Matthew Wilcox (Oracle)
2024-04-05 15:32 ` [PATCH 1/5] mm: Free non-hugetlb large folios in a batch Matthew Wilcox (Oracle)
2024-04-24 15:20   ` Peter Xu
2024-04-25  3:39     ` Matthew Wilcox
2024-04-25 15:00       ` Peter Xu
2024-04-25 20:54       ` Andrew Morton
2024-04-05 15:32 ` [PATCH 2/5] mm: Combine free_the_page() and free_unref_page() Matthew Wilcox (Oracle)
2024-04-05 15:32 ` [PATCH 3/5] mm: Inline destroy_large_folio() into __folio_put_large() Matthew Wilcox (Oracle)
2024-04-05 15:32 ` [PATCH 4/5] mm: Combine __folio_put_small, __folio_put_large and __folio_put Matthew Wilcox (Oracle)
2024-04-05 15:32 ` [PATCH 5/5] mm: Convert free_zone_device_page to free_zone_device_folio Matthew Wilcox (Oracle)
2024-04-05 16:34 ` Zi Yan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A9222E41-28D5-461D-BE2C-922274410127@nvidia.com \
    --to=ziy@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox