Re: [PATCH] mm: page_alloc: allowing mTHP compaction to capture the freed page directly

[Zi Yan <ziy@nvidia.com>]

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

On 11 Apr 2024, at 23:27, Baolin Wang wrote:

> Currently, compaction_capture() does not allow lower-order allocations to
> directly capture the movable free pages, even though lower-order allocations
> might also be requesting movable pages, that can lead to more compaction
> scanning. And, with the enablement of mTHP, such situations will become more
> common.
>
> Thus allowing lower-order (mTHP) allocations of movable page types directly
> capture the movable free pages can avoid unnecessary compaction scanning,
> meanwhile that won't pollute the movable pageblock. With testing 1M mTHP
> compaction, it can be seen that compaction scanning is significantly reduced.
>
>                                    mm-unstable       patched
> Ops Compaction pages isolated      116598741.00   120946702.00
> Ops Compaction migrate scanned    1764870054.00  1488621550.00
> Ops Compaction free scanned       7707879039.00  4986299318.00
> Ops Compact scan efficiency               22.90          29.85
> Ops Compaction cost                    73797.69       72933.48
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
>  mm/page_alloc.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
LGTM. Thanks. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]