From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 104D8C433FE for ; Thu, 3 Mar 2022 21:36:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90D5F8D0002; Thu, 3 Mar 2022 16:36:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BD338D0001; Thu, 3 Mar 2022 16:36:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7842A8D0002; Thu, 3 Mar 2022 16:36:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 6491B8D0001 for ; Thu, 3 Mar 2022 16:36:00 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 27C64A010C for ; Thu, 3 Mar 2022 21:36:00 +0000 (UTC) X-FDA: 79204382880.20.1AB2FF3 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf12.hostedemail.com (Postfix) with ESMTP id B5A034000E for ; Thu, 3 Mar 2022 21:35:59 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id gb21so5752949pjb.5 for ; Thu, 03 Mar 2022 13:35:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=mTTQbV2A2vstkO2kh5RQpGJLvdRtPFWdqW179J6hNJ0=; b=N0Hu/qem+pyMDDz2i8akwdkI4o0ab5wiaqXHx0jVz8DekzDFJJGKCRQh9OzA8XMX+h gmZ1SbI4TvAiqXEdoRbtS21W9hIOgHzQKi2Dbvkfbf83YeFsb5H4IQswCLbgbo9P0wg0 Sb45Ip01tIdIB6zxEYBtv29Tf7VEYsuPCETkD5wrZt09QwMEXceBkvR3WAzUnfsQYp63 GWU0E/r+PovlZQjGUuQsjGLyAh6YJkuPB4XmvgitREtgMLbKEy6EVKB8CfEg9iIYi59E RLaHzAzuN7Cg5+vQznojiovQNSR3CrW8Xt6p0DJnY9XqFDx29JyvX1AWhJzBaqu1h+/c rQQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=mTTQbV2A2vstkO2kh5RQpGJLvdRtPFWdqW179J6hNJ0=; b=eNizlQ+PRDkM2CC1UNO8YjnOLTW5qledeFph1mKO90e2ATo/0AScLWw6JjYfyDBIq7 FI/KLYgaMyQYOGza+feWK8nK/V2N5bDq1ha5b0xCW4AF0TkYaY3XlJPbZMrQM/FUvmAL YvMHbwCC3jyI0go/DwZf9TVmZkkEdW1Nw1TPVcSr3slt5vqMY/xb9a6MU9QiGM0xNuuz j1k11YPgiL12/PBN6KDpttVmyOElaEdto7IFbdw8WAvgJawXqFuLN+PjsVhAWI46YPbJ haj5OM7dLiQZKQ29wgk06VLWp7rpFiNq+49/mHS8OyAuqvHC9783dXWGc0P0iusD+dTl W/gw== X-Gm-Message-State: AOAM531Oio79lF6jBpf20q1HA0ibZF9SJHfHt3gZbRwOnPe2iBzrP4DK I4QUI5IWdw++CrfG6y0KwsU= X-Google-Smtp-Source: ABdhPJxeEj71FVOkpuYaEuAffExNYk8JYhq8TPI0C0rV51GW4k3JxXIM0Wc66BertAkOp9bnEhGOsQ== X-Received: by 2002:a17:902:7b8d:b0:14f:1aca:d95e with SMTP id w13-20020a1709027b8d00b0014f1acad95emr37928815pll.122.1646343358520; Thu, 03 Mar 2022 13:35:58 -0800 (PST) Received: from smtpclient.apple ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id lr11-20020a17090b4b8b00b001bc4098fa78sm3115724pjb.24.2022.03.03.13.35.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Mar 2022 13:35:58 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.60.0.1.1\)) Subject: Re: [PATCH] mm: madvise: MADV_DONTNEED_LOCKED From: Nadav Amit In-Reply-To: <20220303212956.229409-1-hannes@cmpxchg.org> Date: Thu, 3 Mar 2022 13:35:56 -0800 Cc: Andrew Morton , Michal Hocko , Vlastimil Babka , Linux-MM , linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20220303212956.229409-1-hannes@cmpxchg.org> To: Johannes Weiner X-Mailer: Apple Mail (2.3693.60.0.1.1) X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: pg84cd1bo79eodfmpqtxh75jnb8sfsab Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="N0Hu/qem"; spf=pass (imf12.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Queue-Id: B5A034000E X-HE-Tag: 1646343359-88818 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Mar 3, 2022, at 1:29 PM, Johannes Weiner = wrote: >=20 > MADV_DONTNEED historically rejects mlocked ranges, but with > MLOCK_ONFAULT and MCL_ONFAULT allowing to mlock without populating, > there are valid use cases for depopulating locked ranges as well. ... > @@ -850,7 +858,7 @@ static long madvise_dontneed_free(struct = vm_area_struct *vma, > VM_WARN_ON(start >=3D end); > } >=20 > - if (behavior =3D=3D MADV_DONTNEED) > + if (behavior =3D=3D MADV_DONTNEED || behavior =3D=3D = MADV_DONTNEED_LOCKED) > return madvise_dontneed_single_vma(vma, start, end); > else if (behavior =3D=3D MADV_FREE) > return madvise_free_single_vma(vma, start, end); > @@ -988,6 +996,7 @@ static int madvise_vma_behavior(struct = vm_area_struct *vma, > return madvise_pageout(vma, prev, start, end); > case MADV_FREE: > case MADV_DONTNEED: > + case MADV_DONTNEED_LOCKED: > return madvise_dontneed_free(vma, prev, start, end, = behavior); > case MADV_POPULATE_READ: > case MADV_POPULATE_WRITE: > @@ -1113,6 +1122,7 @@ madvise_behavior_valid(int behavior) > case MADV_REMOVE: > case MADV_WILLNEED: > case MADV_DONTNEED: > + case MADV_DONTNEED_LOCKED: > case MADV_FREE: > case MADV_COLD: > case MADV_PAGEOUT: Don=E2=80=99t you want to change madvise_need_mmap_write() as well and = add MADV_DONTNEED_LOCKED there too?