From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69B0BC2BD09 for ; Thu, 5 Dec 2019 19:34:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 30A04224F8 for ; Thu, 5 Dec 2019 19:34:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="FSI80S6w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30A04224F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C62026B11D7; Thu, 5 Dec 2019 14:34:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C14086B11D8; Thu, 5 Dec 2019 14:34:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B509A6B11D9; Thu, 5 Dec 2019 14:34:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 9C5C26B11D7 for ; Thu, 5 Dec 2019 14:34:27 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 4E35B180AD815 for ; Thu, 5 Dec 2019 19:34:27 +0000 (UTC) X-FDA: 76232089374.05.art44_43f334576e515 X-HE-Tag: art44_43f334576e515 X-Filterd-Recvd-Size: 3874 Received: from mail-qv1-f66.google.com (mail-qv1-f66.google.com [209.85.219.66]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Dec 2019 19:34:26 +0000 (UTC) Received: by mail-qv1-f66.google.com with SMTP id c2so1731329qvp.12 for ; Thu, 05 Dec 2019 11:34:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=ohFqpgFuVLwMR/fPnOxHSbjoD2kJwKsGI28iIy8iuZU=; b=FSI80S6wt6yqxmdtp9lMdXY3+LYc5UjWTB1vwIsAcXlDyfxSVPz5KQmZN0tZnN/TOT vq+PrzHxbrYch3Ux1DjOFE+WkZhecLq4WqrwcV1hXe77TNihVXGM+WSvhZiQ4XeAzhcM 2zxZxrAE5+Z+XZFziJdXvGBOF7Aw4I2J6ZuLjXQuYIrz/puUMzv4ZIXy0PyiXC2QD1E9 SGb04g64wzP+imIpkiiDEEOMPvFz24AmgKEuyXdEuklQ0Nt93OH9tdvw88ZoI7JjHISQ sD7+bJGg9ya8lxY9ezPzx/X04/x/puxZpNsXs65yfg7uzCy4dbwb220wBVTJmH6CNWAe gmXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=ohFqpgFuVLwMR/fPnOxHSbjoD2kJwKsGI28iIy8iuZU=; b=ZN5gXhPgfUjqOC0aUj8hyvKK3OArm144tdfHcqMCbXl4WTUaxN6uYrdpLcwFGkYAJt tnJnflza6D3L5d+m3nsrC0lBHJYxu7DjEhT6l+di79Uf8mYIb1Qxq9+cvyy3/zB8IFFI xgJf2GjGa+iNruSoDyfIaIoP/ND2L8RjUup1Bbp/ECSzMrRdXUH3nIUSFaKXTIUqvrfp FqJTwc5tpMfbyZ8Qi1UfpP5LevRunU4Q5UkKOQ9cA4BPZUNz1f1gWU0zDU8geWV7wiPd YyqFv58+1ltz/7GgiVIeWI4eP/UF0147++FfPuNMZa2YvtVxNTrReisIyT6I/xqMNPln 4Qag== X-Gm-Message-State: APjAAAXwYT1dR22EOiAhfWYRLNRkLF7kt6oMCTq70OLkM0wGJD9kX0H+ SpRHDvkigTQ6UtEf4Xh229kyzQ== X-Google-Smtp-Source: APXvYqykYO+fEIijGOKaoHOo0rjkpKIgKBKPXv5S5alIm7Mz3Z279D2irvJWzPaCU8jHSyK8jDXfFQ== X-Received: by 2002:a05:6214:245:: with SMTP id k5mr9171653qvt.182.1575574466035; Thu, 05 Dec 2019 11:34:26 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id u24sm5362334qkm.40.2019.12.05.11.34.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Dec 2019 11:34:25 -0800 (PST) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [v3 PATCH] mm: move_pages: return valid node id in status if the page is already on the target node Date: Thu, 5 Dec 2019 14:34:24 -0500 Message-Id: References: Cc: fabecassis@nvidia.com, jhubbard@nvidia.com, mhocko@suse.com, cl@linux.com, vbabka@suse.cz, mgorman@techsingularity.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org In-Reply-To: To: Yang Shi X-Mailer: iPhone Mail (17B111) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Dec 5, 2019, at 2:27 PM, Yang Shi wrote: >=20 > John noticed another return value inconsistency between the implementation= and the manpage. The manpage says it should return -ENOENT if the page is a= lready on the target node, but it doesn't. It looks the original code didn't= return -ENOENT either, I'm not sure if this is a document issue or not. Any= way this is another issue, once we confirm it we can fix it later. No, I think it is important to figure out this in the first place. Otherwise= , it is pointless to touch this piece of code over and over again, i.e., thi= s is not another issue but the core of this problem on hand.=