From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B514FC3DA6D for ; Fri, 23 May 2025 08:31:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39CC26B00C9; Fri, 23 May 2025 04:31:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 374256B00CA; Fri, 23 May 2025 04:31:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B0DC6B00CB; Fri, 23 May 2025 04:31:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0B7266B00C9 for ; Fri, 23 May 2025 04:31:00 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7352F121D2D for ; Fri, 23 May 2025 08:30:59 +0000 (UTC) X-FDA: 83473502238.28.600EF09 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) by imf08.hostedemail.com (Postfix) with ESMTP id 8AF23160004 for ; Fri, 23 May 2025 08:30:57 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FTEQbYzB; spf=pass (imf08.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747989057; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EsXWGTDv9G1fwwntK6vu0cW1hqdYJtSxhAr9nuGD+wk=; b=S/1CkVxfU7pk8RIpLSxfNLUSQ1IoftnYNQpEL0NQd00XhMIw+q6nr4l7Tcqqv+KhCLVqX/ yT5dtSeayjwkwYi2L/7D5qiy1qRvizOyf+aVfnIa0QpnTVZCDhiatIigqU6dDaKFxNILUT vI5+zEO1KYOIqVCP9itPj9dAQCA6r0c= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FTEQbYzB; spf=pass (imf08.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747989057; a=rsa-sha256; cv=none; b=KPGHNE55oGU+qQPHVMZBX8E+UZknVnE1Oyb24LGtuO7VGBwZXZzHCjyRo8HsTfBicjKWUW Rk4lzzwshdXR+C38MgUQpRtiBoKbTxYBllWTQm4eTLWHnxNPkbw2jck8bCiqHqP7HI5/oO qvNqgCELW5q2j/PdPkrXPuCZmQezkTo= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1747989055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EsXWGTDv9G1fwwntK6vu0cW1hqdYJtSxhAr9nuGD+wk=; b=FTEQbYzBtK/qo5wG6OXMCV3sKpJJoGrKw/wtZYwA+jSdxy8hbij+dlrPWxCIXnVVGL0G94 lq4FqR6ZCAWX+EmJt+pAunHL0/rlc8J4Zj21ZbYIe88HcJ3k2t+ta3+skoshWEPOd5OKQ7 tN5tYSu71A1B8syoeSxL4Q3NgEsG4zo= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.500.181.1.5\)) Subject: Re: [PATCH] mm/hugetlb: remove redundant folio_test_hugetlb X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <1747987559-23082-1-git-send-email-yangge1116@126.com> Date: Fri, 23 May 2025 16:30:15 +0800 Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com, david@redhat.com, baolin.wang@linux.alibaba.com, osalvador@suse.de, liuzixing@hygon.cn Content-Transfer-Encoding: 7bit Message-Id: References: <1747987559-23082-1-git-send-email-yangge1116@126.com> To: yangge1116@126.com X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 8AF23160004 X-Stat-Signature: 4uixaw5b9h1mo59bj3nwzix8ig7ybft5 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1747989057-159913 X-HE-Meta: U2FsdGVkX18PSTKJVpnB6EFzmW5z332//jibCiEe+47xMxLeBHxkFS7lWjbDXbS2xTcT9yh6jCqMp87hw1uDgSsZQZMJPzCFBXZTFNYWQt4RDjtB4s1/0FUao94mJRZMDVbcc4D6p/GnLA1w+a+PUAS9GZad50f4XtvPpmI3pxhw2X9pYEOB6JtEuC1bz5aB5I10RE/xrP98eRXmOFF+Vy0mU1OYH5K6QjD3ZNqwZWs4d6zkb90ZHxyM+ELGPP1c7PGUsAoxonboNRTEZouncmrABN/Zy4IG1Na3dDK9T5poBU5I8NPIk4t9BvpCbBfh8kixEzA7gi//Zsl3ZN2ypQoJ3S0tIb6l0BfkW7FIiPd59L19XA+GkGTPThio0+dvd6EQFKZ2Lz6AQOg1MODth97nFGZ/v7Me9S+GwnOWqY8YB/TzgyA0NNytIA+4TXpcC0hVqQVlq/Zjgw8wSfGulmxH2ilkcl7cNqGXNWz/PDwZckfHmngAgayME+u8xm1P+VMHCG6kIZkLc/MB+h349eB2k0/ddCW6yI1YDaSb+Poe5mv+wEfdRso1gsNwm91p83V8qESgnJ4d3TuUA9p2j8uS4/N41OyyLfa+ZKy3V36aeg55GthS2S1k/Q1eN/7ulL5Tho1CWlIiNDxKHLoa8ziTYGapFAh1wt9klbw7paFTYVTHliA0EJ+Li+eTZ1tyjoWbxWXYlFf7jzCdCTRuwAg26vERV9nVSCxXrF5/cuJF6vUxPrxHR9zaI463ryYblLCSmW2AjbscYZMnbmeXxIgxy1wa/Npai43DVikHXSC09BF/aAyW9GQcc+JAo8emBJvJJI8LgYQWfHEykLsj+wfnjcSbQlqWeeH87WUSYeR6agklOC0XAwONC7mzfJKCvU/9sARWK/lEOa9YmCAo2j7QYSxJ5gyJDcjBq0V7ZqsAGBpuUBQSBdNRe6Sbo26sgctMSTuvCSUaXnAxI0Q mVdVdOSz OsPr/788vvg9LwWHGcjl5+VoNeRn5anWUv461OWb88AtU6kOOVhWKPtdjPNbpvMNQfRzn3iNm5rfY8ht+SD7UmNuLkc72YjlOK7lOJIqyF/mMVOdbNtpp0BjN5evwiT9pjU/THgXSveCb6TPCUaNi2IyqnBN23BpaeoCYvzXxQOcAsSJLvOhy1LApmT5SoBEtOoeHl54dpfzarUEPqkMnah/mJDx53/CyrcO1TEOxUcF0djIaCisOtuQNhTOwWCMgwDz4n30LVXT+jIHzh1lb0FtgUKI2YB3IFcFnrpBeHAbTaWlrobq7NTw+ktz00ijA3n4qN/DQruEacun7OJiHePXUlHp3GoMbVwhz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On May 23, 2025, at 16:05, yangge1116@126.com wrote: > > From: Ge Yang > > In the isolate_or_dissolve_huge_folio() function, the folio_test_hugetlb() > function is called to determine whether a folio is a hugetlb folio. > However, in the subsequent alloc_and_dissolve_hugetlb_folio() function, > the folio_test_hugetlb() function is called again to make the same > determination about whether the folio is a hugetlb folio. It appears that > the folio_test_hugetlb() check in the isolate_or_dissolve_huge_folio() > function can be removed. Additionally, a similar issue exists in the > replace_free_hugepage_folios() function, and it should be addressed as > well. > > Suggested-by: Oscar Salvador > Signed-off-by: Ge Yang > Reviewed-by: Muchun Song Thanks.