From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AB09ECAAD5 for ; Sat, 27 Aug 2022 01:36:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86313940009; Fri, 26 Aug 2022 21:35:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8104F940007; Fri, 26 Aug 2022 21:35:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B143940009; Fri, 26 Aug 2022 21:35:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5B669940007 for ; Fri, 26 Aug 2022 21:35:59 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3860B80323 for ; Sat, 27 Aug 2022 01:35:59 +0000 (UTC) X-FDA: 79843656438.29.8878603 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf26.hostedemail.com (Postfix) with ESMTP id B533214002C for ; Sat, 27 Aug 2022 01:35:58 +0000 (UTC) Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1661564156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y+NLU0Agr0DzkFmH5v2uMtwuDu7hJTIQm8wF8qUZfKw=; b=TTwfwd156JTzz7U1PxkE+sPW9VMDBvBep0XiY1kqEPo1gEqdCx7Lx/AHs6280v4LG37oeQ hikGa0VMLX3WuXUWIUjZgiGK3JYjEP3Vfk6lW6uRQrc1UBXl+BeUNobyjulyXhFEb91YcR R8SmayHoOqHpM7Ry9pSA4HdiKrsxOHY= MIME-Version: 1.0 Subject: Re: [PATCH 08/10] hugetlb: remove unneeded SetHPageVmemmapOptimized() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20220826092422.39591-9-linmiaohe@huawei.com> Date: Sat, 27 Aug 2022 09:35:52 +0800 Cc: Andrew Morton , Mike Kravetz , Muchun Song , Linux MM , linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20220826092422.39591-1-linmiaohe@huawei.com> <20220826092422.39591-9-linmiaohe@huawei.com> To: Miaohe Lin X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TTwfwd15; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of muchun.song@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661564158; a=rsa-sha256; cv=none; b=BAPDwBMur9YSn7VUEAu0hZQOgZ9lRbSHtudRCncJFDIEa89F3RJxgGJemHZ1y1xUePxjSx OfO4aNg14L6le3SpmLqFMV7d7/4PMh2DJuB+vSMS0+0NbcOdYRA3o0KU97QJdvFyh4Z4YV Sf6om5GSGbJrCM2wjCI4FATXznlmgUw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661564158; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y+NLU0Agr0DzkFmH5v2uMtwuDu7hJTIQm8wF8qUZfKw=; b=Yv8pMKzs8shCXtZ/beELbnfa/SvIy4uTcyD+zyB0xdrrnJ+ON7NzECX92xB0fXDhkwX0WW 0LRvz+iw9GOa84gNXoeBOOrr7fVYQ1oSsFGXedaHpTPYDPEm0gsupAckkG2dZaM8Tn8EZe ekkZjqTw6Hfuy/M3m4eF7jHdqCjB7n8= X-Rspam-User: X-Rspamd-Queue-Id: B533214002C Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TTwfwd15; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of muchun.song@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=muchun.song@linux.dev X-Stat-Signature: upsi84q87cuefzghy19yyaaog61jtebf X-Rspamd-Server: rspam03 X-HE-Tag: 1661564158-687827 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Aug 26, 2022, at 17:24, Miaohe Lin wrote: >=20 > If code reaches here, it's guaranteed that HPageVmemmapOptimized is = set > for the hugetlb page (or VM_BUG_ON_PAGE() will complain about it). = It's Hi Miaohe, Right. > unnecessary to set it again. No, I suppose you didn=E2=80=99t test this patch since it does not work. = The HPageVmemmapOptimized is cleared in the above code of line (set_page_private(page, 0)). So NAck. Thanks, Muchun >=20 > Signed-off-by: Miaohe Lin > --- > mm/hugetlb.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 7934188bbed0..b432a00061e3 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1520,7 +1520,6 @@ static void add_hugetlb_page(struct hstate *h, = struct page *page, >=20 > set_compound_page_dtor(page, HUGETLB_PAGE_DTOR); > set_page_private(page, 0); > - SetHPageVmemmapOptimized(page); >=20 > /* > * This page is about to be managed by the hugetlb allocator and > --=20 > 2.23.0 >=20 >=20