From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3497CC02196 for ; Thu, 6 Feb 2025 12:41:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87D286B0082; Thu, 6 Feb 2025 07:41:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 82C936B0083; Thu, 6 Feb 2025 07:41:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F5866B0085; Thu, 6 Feb 2025 07:41:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 509796B0082 for ; Thu, 6 Feb 2025 07:41:39 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E8692C1298 for ; Thu, 6 Feb 2025 12:41:17 +0000 (UTC) X-FDA: 83089480194.03.A4FDD58 Received: from mail.marcansoft.com (marcansoft.com [212.63.210.85]) by imf16.hostedemail.com (Postfix) with ESMTP id 8DAF4180029 for ; Thu, 6 Feb 2025 12:41:15 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=asahilina.net header.s=default header.b=nwevoDBb; spf=pass (imf16.hostedemail.com: domain of lina@asahilina.net designates 212.63.210.85 as permitted sender) smtp.mailfrom=lina@asahilina.net; dmarc=pass (policy=quarantine) header.from=asahilina.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738845676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gGjxLpCbPBjW2Ych8XSy3B16+07LZI5NC9HXokxFssw=; b=HIJTab/RNnP1Yw3zzDOioWNtPYgkD0CJbI9QCNG9eNJxBzPZLGODvt2Sg3CtPd3rxOm3La yz9bbb2xadvqbxIWWGgyh/Xo/EDfKITfejJvBMHGEcshEblpJFuFmz/X4H/U8RGHpBLVBK 7kKhX4WA6Ys72BQRCWlH85mL/uy8GSM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738845676; a=rsa-sha256; cv=none; b=hJPVwP2aVnMz/pyGnKTVYc7tERi+G5PDy34UgZ4ca9Ydf/Kj2KcJ+3IRInHhRv/4NX/F5r iJguZgKFiUbOpNomLGisEaX5gEGhEMu4ugHBUvAAFSxivM9VtlLhFa4ZE3UFsiHYi9MYoN CTx3mgcdZ79hEBfgYUrHbmPAFhu9lcA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=asahilina.net header.s=default header.b=nwevoDBb; spf=pass (imf16.hostedemail.com: domain of lina@asahilina.net designates 212.63.210.85 as permitted sender) smtp.mailfrom=lina@asahilina.net; dmarc=pass (policy=quarantine) header.from=asahilina.net Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: lina@asahilina.net) by mail.marcansoft.com (Postfix) with ESMTPSA id 309B343A93; Thu, 6 Feb 2025 12:41:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=asahilina.net; s=default; t=1738845671; bh=gGjxLpCbPBjW2Ych8XSy3B16+07LZI5NC9HXokxFssw=; h=Date:From:To:CC:Subject:In-Reply-To:References; b=nwevoDBbC0UeG2eDXtUawSqdQxRm+euSZHd3ngRpkByL0DD9kCFf49BH0SVwqgk2n VbPbgsXeuo5qKxEQitzDnNoYRnRhrDKUdwnfZEkFo1hN7pvdu935hNtstjc2/IZoPD wZ84XMWJKbaTiwQ/YcDC3VxbjMRTo+8kUIfTzRhKhmMvCUS0mMfOHTpNhAIUJH1Hco bUkn/83a2NXwoIF45+wABskiOXwaXu9MjBUmoX7JF/ca3nB3DXUGRGPVqXmKTz2oWw XQrIRRijvdh5im9KZQEg5MV7prp92svrz8nBInZM8ksGdBxRXC4dm5xe52/WWrZvPA ZkBWJ4Sif4Mvw== Date: Thu, 06 Feb 2025 13:41:11 +0100 From: Asahi Lina To: Dan Williams , Vivek Goyal , Alistair Popple CC: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org, alison.schofield@intel.com, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, Hanna Czenczek , German Maglione Subject: Re: [PATCH v6 01/26] fuse: Fix dax truncate/punch_hole fault path User-Agent: K-9 Mail for Android In-Reply-To: <67a3fde7da328_2d2c2942b@dwillia2-xfh.jf.intel.com.notmuch> References: <67a3fde7da328_2d2c2942b@dwillia2-xfh.jf.intel.com.notmuch> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 6iup8cxs6mebqjytiuze9orttbq8r6to X-Rspamd-Queue-Id: 8DAF4180029 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1738845675-284448 X-HE-Meta: U2FsdGVkX19DSfB4NWXOKnO2aFw6R8L2wRSaDd70WLB209WwxDuimG0wvX9AJ/Xt3oW5tNcBViQjbf9+Y8jar06/boiMUv+VEZakl+C7NUF/yeAYgV07mlsURrh71UOsn6KX9NF/VXUqjkhrUgZ90KcJ10AvRmw9/DEg4xK0H8nLznIpuk3b/XFQ7aryPEH6wajrXbtd+ljsQiG53B2gYYI3bbL5tCwlzsv5zAp5aiZHOr7vb30X5qu+oZSGnBdIfti+LoUCLyK/rcXS/qAegoEPy0irypB+VzEYFWZPwEmH/OhN95rxw67dBxXxEt6xMozNf4POQJpEsmRVGywXVRhJpZ/okkZJzYgxe3u/rvA7QJIbJIbrTSgnynpouad+8iYE1xZ14AH37X0UE8aN2cLb1Uiu1wrwdNlxH5OD+sR057zhbv4DCBGN7WXnq8V0H3uRqK05QaNzlgNZ6ryn7s6nOmj5KcfF94KCFrm8jjaVHZMp+RYQHFLSRpmG367YXAn0Sxv6uygOabBZgoSWqa6na0Sq5c48EFy3VC9f0AmdwyBEGxCC7rn5uQUuKEuNMX/GX3q1+aJssQS5IoKH3xjQsVKepopv5eMEZEraVKlHr6N2+gSBm6eTl/Q+XVzx00XSF499kk9JGGWzLDMN7AapT3LAguMsFCFYB2mcWXn59Vz/8/s0pa7DuadXtJncHfh7h/9NuCc2Jogs4PG1XhwHOwWAwz0YG9N4JUGoz83ThnE03fprgqedWYKRu0Xr/jP933pQAG5fVr3mxVniRaXuA5DejZbTC+aJ+tRlpMHG/b63ylamlfsilARZDotHjgrbs+prTyKhMUvW4CKUQmir6mulORLF8fbik5YF58G2d1VVnovFCSCIkYWJ1GkyiE9+FFs6PkvkTUjSlZaC4x2AS56fxsJQp+XH4viXAkzCmVejW48E65kPeuLWCbs5UslXo2NtKSyaxQJTdrw jer76qRT 9BIYq+tcr2m5WSuOluTGYn9jZulI9SEF8O4D5BPfZlcHII3nDwdSyC7poYwUd6Z3xAiBFHSE3+fdBQWBMoaQrO9Z5wzFWMwKg28Nn/jHo8TMk+PLVDLgNVU8IBtGxwOyrxoycwNNiEJFgOcWibds8YVKhNGCVG5CQp0BfYXucklqs8mixZWjkvmAXgQrgpAfmgQd8/l2b2zkbv/L/HY/WXzEDrj5LItYHNLCoBo/exFO4oUqAosuhb/w91ZNPGGwAdoSR3s2HdyVxLx3YXuoR0wPhg7FEDoU614Zc28OZ0Ae2H+M1FeE8azBgn/WPCXKFzQJlM8J6Bahw4J/5CKpymAmhFKMrIPYg5T8lYurBG5DhvmiPOwmaVZ6hIiBuub8CunyhzwUOHJI/zYdx9y9T4kzX/RkblOumcco+kax2vwuQf5+v/KvcH06mSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On February 6, 2025 1:10:15 AM GMT+01:00, Dan Williams wrote: >Vivek Goyal wrote: >> On Fri, Jan 10, 2025 at 05:00:29PM +1100, Alistair Popple wrote: >> > FS DAX requires file systems to call into the DAX layout prior to unl= inking >> > inodes to ensure there is no ongoing DMA or other remote access to th= e >> > direct mapped page=2E The fuse file system implements >> > fuse_dax_break_layouts() to do this which includes a comment indicati= ng >> > that passing dmap_end =3D=3D 0 leads to unmapping of the whole file= =2E >> >=20 >> > However this is not true - passing dmap_end =3D=3D 0 will not unmap a= nything >> > before dmap_start, and further more dax_layout_busy_page_range() will= not >> > scan any of the range to see if there maybe ongoing DMA access to the >> > range=2E Fix this by passing -1 for dmap_end to fuse_dax_break_layout= s() >> > which will invalidate the entire file range to >> > dax_layout_busy_page_range()=2E >>=20 >> Hi Alistair, >>=20 >> Thanks for fixing DAX related issues for virtiofs=2E I am wondering how= are >> you testing DAX with virtiofs=2E AFAIK, we don't have DAX support in Ru= st >> virtiofsd=2E C version of virtiofsd used to have out of the tree patche= s >> for DAX=2E But C version got deprecated long time ago=2E >>=20 >> Do you have another implementation of virtiofsd somewhere else which >> supports DAX and allows for testing DAX related changes? > >I have personally never seen a virtiofs-dax test=2E It sounds like you ar= e >saying we can deprecate that support if there are no longer any users=2E >Or, do you expect that C-virtiofsd is alive in the ecosystem? I accidentally replied offlist, but I wanted to mention that libkrun suppo= rts DAX and we use it in muvm=2E It's a critical part of x11bridge function= ality, since it uses DAX to share X11 shm fences between X11 clients in the= VM and the XWayland server on the host, which only works if the mmaps are = coherent=2E (Sorry for the unwrapped reply, I'm on mobile right now=2E) ~~ Lina