From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1F7EC18E7C for ; Wed, 26 Feb 2025 15:30:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E5F8280008; Wed, 26 Feb 2025 10:30:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29389280003; Wed, 26 Feb 2025 10:30:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C0B8280008; Wed, 26 Feb 2025 10:30:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DD805280003 for ; Wed, 26 Feb 2025 10:30:33 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 43C01161965 for ; Wed, 26 Feb 2025 15:30:33 +0000 (UTC) X-FDA: 83162482746.19.D507A95 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 85DEDC000B for ; Wed, 26 Feb 2025 15:30:29 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OKatrrSB; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740583830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gVt0qzRRcwLYzm8lqhyi37nC1mPHa9gt3lqzImxJBfw=; b=PeONPYyA7hEnXe/4Okar0yPp8T3/OoInAG/yqdGzzpPwZ5P6ywtTo1iAzvw9c2uEy5ZX3x F0tzFpdxCBVM4UtOyHwLkpFSZc/JQEeiqIFoUhLzntYFaLeyeP8dWyqzSMFvWug8J+jvkV 5oTqwOoEYsWtnMQdGzcLGtWEE+TFmg0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OKatrrSB; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740583830; a=rsa-sha256; cv=none; b=MRkhez6enFVWUkfdp+8PWGnQY4lL8i8CuocHoN6pik6Jn6pLUIt/QZR7rl13Z8SjYoKRfv leU+8VfwBg1tJRoXrq8C3/KH8T5ipQa8dCm8OEg8IW1LXXXlrZRgeQHAFjr1qDuehTfQ5k SXTPTiwbSfQ/eI6yWftTbU/9DzZF35k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740583828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gVt0qzRRcwLYzm8lqhyi37nC1mPHa9gt3lqzImxJBfw=; b=OKatrrSBfjekLgZC5OMd741ocaKiFoIKq58N27DKrr+IbFeb3gQqMvOU4BHl8G7VRwzLu0 2A0tIxAaa2VujcCTYCcSvFv5Rv3SlV0tNHwC6SSQu3AZcBJOUECdlMlNgte/hnlfsaDEa2 w1VhKGFDB+qJ0ZKQllC7I+Usiz6laj4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-SKZ6rqK8MbCpJgoVvRJbvg-1; Wed, 26 Feb 2025 10:30:24 -0500 X-MC-Unique: SKZ6rqK8MbCpJgoVvRJbvg-1 X-Mimecast-MFC-AGG-ID: SKZ6rqK8MbCpJgoVvRJbvg_1740583823 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43943bd1409so47408275e9.3 for ; Wed, 26 Feb 2025 07:30:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740583823; x=1741188623; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=gVt0qzRRcwLYzm8lqhyi37nC1mPHa9gt3lqzImxJBfw=; b=rwcI6Ki9ICkTQx6/FUq0zRQlaYRnfFbNw2aICWsDP6XYrxJvCYE4stAFvxnbrgLGeJ eud3ubr3qatxyy5c3DNo05jO35MYVfx1Rr2pLcSDSJLpMf/RUM4qRlNvqeFpS44/8c3P hNsH1xRCnkWQ3VNDyAPVV0PeIbyDiGMXaQcUWODvKcXggVKaMUsyd2rO7qt0FBspTKbr /Ej7hhCS3vxDApRDukvzcxr0CYhjj/mrYaQyzAIBx2E6O8rT5cRFW0VcjEu5qZqVKnhF uD3SfNba8W3fQy6ZUSlmxxncYyeWcs5CuOL2kbf9KwbnxWbWCdRdpL2lCacU8aaX5XdG K5nw== X-Forwarded-Encrypted: i=1; AJvYcCWrK8YG99kA3IiAj8tO7l1CQl2D+ky96rHVKRZXi9NqP9BIfxKsjxMhJNdfURBB/JuBJkDhpqxyhA==@kvack.org X-Gm-Message-State: AOJu0YxT6+iA5zRiDT7Ubs2ksFhoYVx0c12NcoQWjNMLYT9a1K3m7EJ9 ZuX7KsUhzas0UHQoHfeHgxWc5vpzVOAgqZiQVhDsi3hHGJgsGCajFkESV8KbmdTkZ6E75Hq2R+o G/ubI6krG2gr5PdOPoUKr3awUvYl3z36KMf8u2KSvGe3Yd3U5 X-Gm-Gg: ASbGncvEPnE0hNncuGHyGsmveKTI+V7EtLsK/eCVczM5gu0CV+rjfDHvQDUB1J89oz+ IBF5VUFqrhduPCC7MBxJwSxgvV0IzO9sLGflnHRC2cehW8iBOYW+YzUzLaQ1IzltjAR+CaMxbIq F3b/qlG4nQ9/cYhXlyAPY8KV836vRDJPBDwYk1Z6qwXMgk/OlxZ887Oe1GP4OFogONkVkE4hmeE G1FukA3Bz0m16oKrordxH9HBiFoMB6xXGKE/WclIYn+iTTf0+idiC+x8tlH1ovtwbFyTL317Ph+ X1X3JW/ofrFVaZ4MJGs7NIODO6fbHhT9EEcIXjfGoKTmdzje0Ykho3wdR/thFUnLJ2b6IjIegOd Fh9y3uNFDpwiRT5GbouaLxemSRUv6kjGkI1+nDcFm3PE= X-Received: by 2002:a05:600c:3b13:b0:439:8bc3:a697 with SMTP id 5b1f17b1804b1-43ab8fd1f46mr35729685e9.4.1740583823440; Wed, 26 Feb 2025 07:30:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDQ1Rg5mJ7gASlDo38k12X1agotgAvbBBn2p1lMp4aSsVrgnQa+7aXZITK3QN/pmv/rHAjsw== X-Received: by 2002:a05:600c:3b13:b0:439:8bc3:a697 with SMTP id 5b1f17b1804b1-43ab8fd1f46mr35729205e9.4.1740583822963; Wed, 26 Feb 2025 07:30:22 -0800 (PST) Received: from ?IPV6:2003:cb:c747:ff00:9d85:4afb:a7df:6c45? (p200300cbc747ff009d854afba7df6c45.dip0.t-ipconnect.de. [2003:cb:c747:ff00:9d85:4afb:a7df:6c45]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba52bc54sm26843285e9.5.2025.02.26.07.30.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Feb 2025 07:30:22 -0800 (PST) Message-ID: <9ffce724-23c9-4aa1-bc53-8292e1029991@redhat.com> Date: Wed, 26 Feb 2025 16:30:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/12] KVM: guest_memfd: Add flag to remove from direct map To: Patrick Roy , rppt@kernel.org, seanjc@google.com Cc: pbonzini@redhat.com, corbet@lwn.net, willy@infradead.org, akpm@linux-foundation.org, song@kernel.org, jolsa@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, shuah@kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, tabba@google.com, jgowans@amazon.com, graf@amazon.com, kalyazin@amazon.com, xmarcalx@amazon.com, derekmn@amazon.com, jthoughton@google.com, Elliot Berman References: <20250221160728.1584559-1-roypat@amazon.co.uk> <20250221160728.1584559-4-roypat@amazon.co.uk> <8642de57-553a-47ec-81af-803280a360ec@amazon.co.uk> <7f38018b-dc89-4d79-a309-149557796121@amazon.co.uk> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <7f38018b-dc89-4d79-a309-149557796121@amazon.co.uk> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: V21sRMUZUm_RKlVyIW5GOsWDNpJ8LawEyeo8BiYfTAw_1740583823 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 85DEDC000B X-Stat-Signature: 5xcs34foatwxdjyzswfyfdmccn7r5mrc X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740583829-846169 X-HE-Meta: U2FsdGVkX18MgJpod1/TJNDYvN7di3KZISyPKOzZ+RsA9831e9dnXDKGhgYTF9CE0t5Y89Mpe6jRwJAe2niJjuO8A1aIx6TBlwOiGevnN4H8CBUjMXT9cc1tirNKh1lbk0w4Sp6F0vgDWfjFCkNcX/7SFAcdbflJVHEeyVVlYpTlWGifxuTQjzJTLcC/j0Lh3f5uFgB6SOKCG5O11gSS6V1DyLgX8cMUZ1EyFa2oiXmd5TabarasuaOynTESXanwJfQeplpLRFX2OydChFwQ+1dukDB37d4kGAqsgq2tyws92iOgdMtqG4SQYKS9t04QWXP294G+C5u1BTJqEuMRyC0GcIgQL5Q6LqsufTDGKtBx4zTPvnhBQWzFG56LHR9M8A9XFrI4m0seTdXG1oSyjlnxuwkJySRblf4fRNUxPXehb1vFKfg9tksEuR3aKTupe4NDqYbktE5FjU4vpHscP6q3nkTi9UZAMTjHrJ/Y6YotwJ40K60gMzy2zwDXG6I+5mU/HqXhVSWRt2q6KDVHplstCZ81M/GV1Owsbw0ZzuL+T5vk7/nZRGKXko79tUyZ5nEyqOh4bpah/+17oCnuoJn9/8aUD88fuehW+8U8AuFWYr3/Cp2L7sQJ58RVpAWOV+UClHjaPH0SvBzEfofSJQZDEuDeSVYQu/k/OWQYc9WnZKvlcLopCkGovAExtGmSwTPTi0usAaTrdYbdkBMvRVNJ8isHDW8Q7swWci8BT03OfsfXkyU+RT278FCnKl5Du8dXOb7DAA85tSusrtIcTtrDf8B7EWTU78VM4rZqnoHqaXyjf+bYJdKKeLMAwm0hle5wbvCpn4hn689VOrHo/B585xBpPMSo16MrEz2XQZ1234bS00ktjzKAxehV9BN1ArVDvJovFfj/AFixSSgo76mRdmzFBlL6WVfMrZjQEipfdUT398jMV2qnv6SILTkosr3s81nEVFDNr127Jus zaF7YAH2 dSZKiTfEn1oWfnjFrefxjrXSr/p0NDk5nIt5ljS3W4KxFkATMlT/qv1q92ml4WJNljXqU73RcaW8zvl5LNgSDhtRHylBc8OBLAzw5IdcafoxsTXl7CLw3X9JKjxZSXR/xHNOvvxsBRkfEXqzozoRgsFrKvZFSJWgpBhy6XzZE1yNMwgEduN3t2eH+EQpMB6EyGWit+pG9kdkfoRZsfKqikJIymeRtsQhIJF9x7dL8uTwZy6DDsnaRvSEfscUic2Ey528+ifVrPm1m4CtMnsTvNQEZeunhUGgFF3jT2tIXt+dzQ3tunX0N0i6G7+4nZwiq0ud6asd1/MqA3xQSu+AddlG5PU+iavj2FqacMmNoIeBWb/AQ5MeWyyhNQ4Vm+1Jp+2Cni5qq1A6c3VU44yXJdajjoEVjJ5EHWxKh7QpviyxE1AgntzV4HzVH7XCTHTvChqk0oHhoDgAMEecDscL8HShukgvzDUiuWb1MrByFo1l9NaFQcB8KaSK7j230ikgwb5fmrxzOYlp0S11oZBYiDRqK71bIPc2hoNMdkbGvMU5RQoh7MV1wL0SfhGixZ5yH7OI0zx1Gtx5b214Wffla+q3VtW8u9lt8P6xxHpFuOveHPoaK+WyjmFL6Dw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.02.25 16:14, Patrick Roy wrote: > > > On Wed, 2025-02-26 at 09:08 +0000, David Hildenbrand wrote: >> On 26.02.25 09:48, Patrick Roy wrote: >>> >>> >>> On Tue, 2025-02-25 at 16:54 +0000, David Hildenbrand wrote:> On 21.02.25 17:07, Patrick Roy wrote: >>>>> Add KVM_GMEM_NO_DIRECT_MAP flag for KVM_CREATE_GUEST_MEMFD() ioctl. When >>>>> set, guest_memfd folios will be removed from the direct map after >>>>> preparation, with direct map entries only restored when the folios are >>>>> freed. >>>>> >>>>> To ensure these folios do not end up in places where the kernel cannot >>>>> deal with them, set AS_NO_DIRECT_MAP on the guest_memfd's struct >>>>> address_space if KVM_GMEM_NO_DIRECT_MAP is requested. >>>>> >>>>> Note that this flag causes removal of direct map entries for all >>>>> guest_memfd folios independent of whether they are "shared" or "private" >>>>> (although current guest_memfd only supports either all folios in the >>>>> "shared" state, or all folios in the "private" state if >>>>> !IS_ENABLED(CONFIG_KVM_GMEM_SHARED_MEM)). The usecase for removing >>>>> direct map entries of also the shared parts of guest_memfd are a special >>>>> type of non-CoCo VM where, host userspace is trusted to have access to >>>>> all of guest memory, but where Spectre-style transient execution attacks >>>>> through the host kernel's direct map should still be mitigated. >>>>> >>>>> Note that KVM retains access to guest memory via userspace >>>>> mappings of guest_memfd, which are reflected back into KVM's memslots >>>>> via userspace_addr. This is needed for things like MMIO emulation on >>>>> x86_64 to work. Previous iterations attempted to instead have KVM >>>>> temporarily restore direct map entries whenever such an access to guest >>>>> memory was needed, but this turned out to have a significant performance >>>>> impact, as well as additional complexity due to needing to refcount >>>>> direct map reinsertion operations and making them play nicely with gmem >>>>> truncations. >>>>> >>>>> This iteration also doesn't have KVM perform TLB flushes after direct >>>>> map manipulations. This is because TLB flushes resulted in a up to 40x >>>>> elongation of page faults in guest_memfd (scaling with the number of CPU >>>>> cores), or a 5x elongation of memory population. On the one hand, TLB >>>>> flushes are not needed for functional correctness (the virt->phys >>>>> mapping technically stays "correct", the kernel should simply to not it >>>>> for a while), so this is a correct optimization to make. On the other >>>>> hand, it means that the desired protection from Spectre-style attacks is >>>>> not perfect, as an attacker could try to prevent a stale TLB entry from >>>>> getting evicted, keeping it alive until the page it refers to is used by >>>>> the guest for some sensitive data, and then targeting it using a >>>>> spectre-gadget. >>>>> >>>>> Signed-off-by: Patrick Roy >>>> >>>> ... >>>> >>>>> >>>>> +static bool kvm_gmem_test_no_direct_map(struct inode *inode) >>>>> +{ >>>>> + return ((unsigned long) inode->i_private) & KVM_GMEM_NO_DIRECT_MAP; >>>>> +} >>>>> + >>>>> static inline void kvm_gmem_mark_prepared(struct folio *folio) >>>>> { >>>>> + struct inode *inode = folio_inode(folio); >>>>> + >>>>> + if (kvm_gmem_test_no_direct_map(inode)) { >>>>> + int r = set_direct_map_valid_noflush(folio_page(folio, 0), folio_nr_pages(folio), >>>>> + false); >>>> >>>> Will this work if KVM is built as a module, or is this another good >>>> reason why we might want guest_memfd core part of core-mm? >>> >>> mh, I'm admittedly not too familiar with the differences that would come >>> from building KVM as a module vs not. I do remember something about the >>> direct map accessors not being available for modules, so this would >>> indeed not work. Does that mean moving gmem into core-mm will be a >>> pre-requisite for the direct map removal stuff? >> >> Likely, we'd need some shim. >> >> Maybe for the time being it could be fenced using #if IS_BUILTIN() ... >> but that sure won't win in a beauty contest. > > Is anyone working on such a shim at the moment? Otherwise, would it make > sense for me to look into it? (although I'll probably need a pointer or > two for what is actually needed) > > I saw your comment on Fuad's series [1] indicating that he'll also need > some shim, so probably makes sense to tackle it anyway instead of > hacking around it with #if-ery. Elliot (CC) was working on "guestmem library" project [1], but it was unclear what we could factor out into the core. Looks like a simple shim for such stuff might be a good starting point, although not the final idea of encapsulating more in the library. @Elliot, are you currently still looking into this? [1] https://lore.kernel.org/all/20241113-guestmem-library-v3-0-71fdee85676b@quicinc.com/T/#u -- Cheers, David / dhildenb