From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 013A1C54ED0 for ; Fri, 23 May 2025 19:31:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B3046B00B7; Fri, 23 May 2025 15:31:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 789616B00B8; Fri, 23 May 2025 15:31:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69EEF6B00B9; Fri, 23 May 2025 15:31:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4D11D6B00B7 for ; Fri, 23 May 2025 15:31:04 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F35671A0E3C for ; Fri, 23 May 2025 19:31:03 +0000 (UTC) X-FDA: 83475165606.13.DFAB1A5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 9AF2640005 for ; Fri, 23 May 2025 19:31:01 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ix6ZoLBe; spf=pass (imf04.hostedemail.com: domain of ddutile@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=ddutile@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748028661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FTvdxciROz3xcyDGA7SqLlzzoP+BAXCOdB9KfOHNYyY=; b=rUh88S4700a3T0gJD3NdokY9RRFdEF08n2XFN2XBgKoTmSyZrrzlBVVapRU8ICwdlWKQjx D0hTcS8sWUsn0juJfvlWqJlop9aB8NUP79KKooRAsFSTxPKyBJfx/NwMtIJyegvPkq3w2r 0PhBfm4kb3wbSnHiD2bFuTIxqmbrGVw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ix6ZoLBe; spf=pass (imf04.hostedemail.com: domain of ddutile@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=ddutile@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748028661; a=rsa-sha256; cv=none; b=uxQEOoB2muC/QA0TFPu+m95BC5w6RctN2BW/8zg63ZU23wdWoHAtlz7fGtTC9DUy0+6Ttw TCY1IZY4Wj6NZAnWny4EkAPbkhU8KFVnBmVYGYTZbgMphhSUN2nidkCf7qBX4CEmbD3N3r F/Vs4Y9qI7jTChi+BdYJZbKDQHgrWKI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748028661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FTvdxciROz3xcyDGA7SqLlzzoP+BAXCOdB9KfOHNYyY=; b=Ix6ZoLBeCn9pjO3jVLvDpFHq5eG2V2rhVa5Ca4KOGQGV19D4sXGzFh5a8oKrIBtV36skMt l3fEQYQu0JAcRuJtyCDzoWz7fY3qDenr+dqiUptxugql8wzQcBHgjhPEQOAvOGHutVzSq+ 33PziHAdHVcPx1kMxq3ROOoTIbhG6U8= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-fnViVeMAOGuQaJkG4hmCHw-1; Fri, 23 May 2025 15:31:00 -0400 X-MC-Unique: fnViVeMAOGuQaJkG4hmCHw-1 X-Mimecast-MFC-AGG-ID: fnViVeMAOGuQaJkG4hmCHw_1748028659 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6f50edda19eso3116646d6.1 for ; Fri, 23 May 2025 12:30:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748028659; x=1748633459; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FTvdxciROz3xcyDGA7SqLlzzoP+BAXCOdB9KfOHNYyY=; b=KEh1U3GmVvw7veuS8NPZQ5IyWjzy8FohvxHwVauPEZc1+jEOKxhCrphTSH0j/7HcVh OK9TKbR0ulUKo5JZ2vnRouGeyrmWQCnNH0DkYAluZpK4QZbBVFRcJFi1d/DQ5ggixCmG COnLvgosDclfaZEwkTex6pLFP0Vyuf8Ii08ukUP+S2lcO6Qfyb0Z8Gi2vRYUX5BKWB21 w8s22S2R+QRR6ZSgin98qtV37ZjAgsbeA6y5r2qmd9cyAjrnV3Ncq2JODoNil8tIIq8i jAokkjEOoux7XdokXRuV35JQL9wiZv6qmBrtpR7SWDngiwmLthIVCOBkQU9LE7pWhUQK /LOg== X-Forwarded-Encrypted: i=1; AJvYcCWwQ+KNlCfnjfnTCaKt95Qp+zkFOyM98LJ8k6XgAuGEXchQSt7/B0Qyrrkf4hEMjE4vlqqB3F9ZYg==@kvack.org X-Gm-Message-State: AOJu0YxggSafTsDvrvPQfA1n/EmTdME2X3uuOuL8xP5EZ/QNEV+BdbUA 9SzmDkYieXA0qM+yO/Vt1cXh33uBj2YRtLjJYKHLD2cKtoI6CIoGiAUWua4lpBn6mYW9ZRfIQPG CQzfORm+iqC0F1KmBvsuyl/adjByPTh0M7nhHJjHZirYh+iOaFZDj X-Gm-Gg: ASbGnct4fCx/AEa0cFRvcmhU7cTqkGdv4zesRnWzgVAjOo4/KccVSINujSyATLFw3rv 1Z0TsZQtCoMnc5dj35ZDHwJAaCqTB82+uoou8WgDV/MGp0tZily3QDsRgZhRc69h79hmnxV+AwC YV65bx9d8kSoL6JhWXgI+dcQULTOGO+LpNp1eds/hkfN19MHDgRnHd4EJlYA/wvHhdZQskODKVj 1nSbqzprYtOZeZ3FRscKjTlkFZKqfQFgR7ycNDAaiDTNqg/2VV3B+z5E5a4QrDvNEzmjDGkFCb3 m4uerWZbbHw2 X-Received: by 2002:a05:6214:1d23:b0:6e6:6964:ca77 with SMTP id 6a1803df08f44-6fa9d29c58dmr11208036d6.28.1748028659024; Fri, 23 May 2025 12:30:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFd+qzCAswhS3iuiKWeZE50Wf+7n1+LX7vli2jZxIWG36wkuD8DiM8xlaNuqX/4ezVASlQWyA== X-Received: by 2002:a05:6214:1d23:b0:6e6:6964:ca77 with SMTP id 6a1803df08f44-6fa9d29c58dmr11207166d6.28.1748028658328; Fri, 23 May 2025 12:30:58 -0700 (PDT) Received: from [192.168.40.164] ([70.105.235.240]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f8b08ac5ddsm118552726d6.44.2025.05.23.12.30.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 May 2025 12:30:57 -0700 (PDT) Message-ID: <9ffc7686-0dc0-4978-8cd8-f12a1c148b63@redhat.com> Date: Fri, 23 May 2025 15:30:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/5] KVM: arm64: New function to determine hardware cache management support To: ankita@nvidia.com, jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, ryan.roberts@arm.com, shahuang@redhat.com, lpieralisi@kernel.org, david@redhat.com Cc: aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, kjaju@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, zhiw@nvidia.com, mochs@nvidia.com, udhoke@nvidia.com, dnigam@nvidia.com, alex.williamson@redhat.com, sebastianene@google.com, coltonlewis@google.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, gshan@redhat.com, linux-mm@kvack.org, tabba@google.com, qperret@google.com, seanjc@google.com, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, maobibo@loongson.cn References: <20250523154445.3779-1-ankita@nvidia.com> <20250523154445.3779-3-ankita@nvidia.com> From: Donald Dutile In-Reply-To: <20250523154445.3779-3-ankita@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: juwh15W-FDLALDEIqEdWaKIbelDZvKg95l950Q6-Nzc_1748028659 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9AF2640005 X-Stat-Signature: 5pqu5gq7zyf5ps9kuzhtagkft1k7dom7 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748028661-766334 X-HE-Meta: U2FsdGVkX18Isgx4QNwKyimFQHWv9FhGH8tGFNTox4ArWo5nXnymV974jgfFDDPlyRWEl2nsHOLHObEjf330i3DtAJ1mGVpg+ynwOjZd1Njxl+ckRR+aKJEs09EYcTBjABfywVSIyTUDfqGuNY8v5GKyn4kdJSLT6gV9Xvjb02UCRu6AiEld7gcWLJNzR7AK9zSonczf/EHAgFfnWNgG/T0YIxf9r9/mMzagieb9rokC0oyChPVQDyLryZ4kf9NN67iUO2Oo0L51Fv/pJucHGm/KwQ+0nWkScn2p2pT2QEXMzrQl/eEv01EzMQSxttJSPt+uiYZoP6KNv4jm92MsRjzvNYgKFqnQ+J/zfWf4vog3Tk/efYcv8CKQVyGwW9EoJ0FHH3+s+wmNrPZD4NQSdyyDfVpE5XnpZczSu0umTlt2O3hbj4+9dix5sDwbmSdfq0N9ZwPNel0yKH1OAGx1awTqGQGZ4v+h3Ofe9MZOtuER61FUM042tx9WOdKpipXWUGvvwdlIDhC5d3Xzf8gwgte8ZWpNm8HFaJ/94pTF+hCjlJHw68RzQXBW0Tr0tjomsSIq5qwYXas8Td4HxJJBtGulk6bGmOsJYO46KaG0eVAtPASO3twg34IJVYW0PfZQx2UKa9r4Xrp4/BQWmTncmg54Ow/b/OkU0CeskvB24gosC9Pw+Ft17mq25fD/46b20bsCSZDSrHlSNQ91E/gp6A8SJo6+SbhN7PlrsuR/Awb49755QGolWoNYnvrePCA0LenJ/cSh/uY4pAy4+bJmNBNrKA2WjcSQDXP6SwlHfd9ASXUqXo39ddy3dsmBU2qGSsMzjywjykV0sQUFtly5FplqKSpNrKtyfshinHUFr68ZbWH15ydcqZSw4DdUOyt3LOhbyJ79OPTlwvvInRCFzP0C+HCHgE6UZGMP91zlTV24l/opoar/RultffqiRSvFV0jnO4X8PXtyi8Vsusz aTv9UYAp 7p/u0emeEe6vZ1cbLeKaeoYy/60483rumQ6MkVxtZ5mAh0X/zpCj+hAFpz89BraBwwHvIaOlN3qTVb7iHOozxe72A3juho7hWXTrUZBFEB78baDxxjIDVq8Cb6aYhOhtP0bxfygIQ2hE6Mh9GaphvpbazzVgmSsphp6xA9poZ202Ya9WVwAAfSX1u3j9NJIKrHf0i9tLOCqCN0wueIyW4Szealn6BMIj+IVosIFbFlz2Ve0LwLqS7t/lTqIE9F3F/AXJ8lblVNKolax0l7niWslRMlgQ8xTaZu71PR2jQLKKrV61AMePz45yef09iWzGSB8VzoLPDNFC8FnDvyi1AN1c+8b5262k0BdeEBCORIAAUNaVjEHZOiBm4ACgGmdadYvFvmjRUkOeDmMi0RtHN3f50h6xpnNjaE9A/UOG11tL/0PYM0IOrbV05QQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/23/25 11:44 AM, ankita@nvidia.com wrote: > From: Ankit Agrawal > > The hardware supports safely mapping PFNMAP as cacheable if it > is capable of managing cache. This can be determined by the presence > of FWB (Force Write Back) and CACHE_DIC feature. > > When FWB is not enabled, the kernel expects to trivially do cache > management by flushing the memory by linearly converting a kvm_pte to > phys_addr to a KVA. The cache management thus relies on memory being > mapped. Since the GPU device memory is not kernel mapped, exit when > the FWB is not supported. Similarly, ARM64_HAS_CACHE_DIC allows KVM > to avoid flushing the icache and turns icache_inval_pou() into a NOP. > So the cacheable PFNMAP is contingent on these two hardware features. > > Introduce a new function to make the check for presence of those > features. > > CC: David Hildenbrand > Signed-off-by: Ankit Agrawal > --- > arch/arm64/kvm/mmu.c | 12 ++++++++++++ > include/linux/kvm_host.h | 2 ++ > 2 files changed, 14 insertions(+) > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index 305a0e054f81..124655da02ca 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -1287,6 +1287,18 @@ void kvm_arch_mmu_enable_log_dirty_pt_masked(struct kvm *kvm, > kvm_nested_s2_wp(kvm); > } > > +/** > + * kvm_arch_supports_cacheable_pfnmap() - Determine whether hardware > + * supports cache management. > + * > + * Return: True if FWB and DIC is supported. > + */ > +bool kvm_arch_supports_cacheable_pfnmap(void) > +{ > + return cpus_have_final_cap(ARM64_HAS_STAGE2_FWB) && > + cpus_have_final_cap(ARM64_HAS_CACHE_DIC); > +} > + > static void kvm_send_hwpoison_signal(unsigned long address, short lsb) > { > send_sig_mceerr(BUS_MCEERR_AR, (void __user *)address, lsb, current); > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 291d49b9bf05..3750d216d456 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -1231,6 +1231,8 @@ void kvm_arch_flush_shadow_all(struct kvm *kvm); > /* flush memory translations pointing to 'slot' */ > void kvm_arch_flush_shadow_memslot(struct kvm *kvm, > struct kvm_memory_slot *slot); > +/* hardware support cache management */ > +bool kvm_arch_supports_cacheable_pfnmap(void); > Won't this cause a build warning on non-ARM builds, b/c there is no resolution of this function for the other arch's? Need #ifdef or default-rtn-0 function for arch's that don't have this function? > int kvm_prefetch_pages(struct kvm_memory_slot *slot, gfn_t gfn, > struct page **pages, int nr_pages);