From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E11EEEB64DD for ; Fri, 23 Jun 2023 02:07:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F14A68D0002; Thu, 22 Jun 2023 22:07:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9D968D0001; Thu, 22 Jun 2023 22:07:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3F1A8D0002; Thu, 22 Jun 2023 22:07:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C55FE8D0001 for ; Thu, 22 Jun 2023 22:07:21 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7AACF140C17 for ; Fri, 23 Jun 2023 02:07:21 +0000 (UTC) X-FDA: 80932375482.15.E20FCEB Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) by imf19.hostedemail.com (Postfix) with ESMTP id E47F31A0005 for ; Fri, 23 Jun 2023 02:07:16 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.111 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687486039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MzhV9LhSS9unc5IWnsa4gXYgrk+O0TYDKFcPL/jvg7I=; b=G1wQoSwqYV+pWS4Vk/BTUKU/RK4p+aUnyUXtKe8s9S0BKMjjYac3qGlQ0kk78HppWo0fSh fgImnurI2otQPSDIVhIVzWHF9YZjUDb3hSCZEf3HjJApadsrZb9qrKhw2E+2szs3V0SSkj nb+76S4XAnUiGvqYM6Q15sToseWhFzc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.111 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687486039; a=rsa-sha256; cv=none; b=Ry8PB/FeuZIfqLykaa8TL6mqVBS/xv7B40jouVjID5L3JI/JTGKZRpNlX5N3kjZHHcDsCk LN6XjcUt1zEwOpgcWuA98QyLday+bp9GbWwK9lXopwq8BdjM72xiea1Nx0kLy2Zklm7Z3x UhdlIuKAoiZ1I1IKyTuBSnsASn5GRdE= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VlkdzUw_1687486029; Received: from 192.168.0.106(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VlkdzUw_1687486029) by smtp.aliyun-inc.com; Fri, 23 Jun 2023 10:07:10 +0800 Message-ID: <9ff605a5-a989-01f2-e629-e52bb50201a7@linux.alibaba.com> Date: Fri, 23 Jun 2023 10:07:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v3] mm: Fix shmem THP counters on migration To: Jan Glauber , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Huang, Ying" References: <20230622094720.510540-1-jglauber@digitalocean.com> From: Baolin Wang In-Reply-To: <20230622094720.510540-1-jglauber@digitalocean.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E47F31A0005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: oxwrxnuyfkitcm4qmuahwzmbzcxqngyp X-HE-Tag: 1687486036-683535 X-HE-Meta: U2FsdGVkX1+1BLu4x2HumV83bx5ha85c+RTREBzIoSsHs98GUG8ixr2mpa3jHNmMaBDpVUjgzRKo/KokW1j46WqR/3t6hPZcsUV/gv4gtjCkg+xhtPSgpPG8gou4vmMRjkQrcHpxdsI8sUeXFyjDjZFhB7AtqED8VXjN9Vh4jLzPgeXXqSRRWbMKmjA9SMuDQ9Onk33MeDqXz0EQD1dI67gJK0I2qpluZlUPBgCIj9+D9Da1rgHWMYW2R5hXh/+0jO8Ey6RkJBJkfHkZaYbMqVTcalb/kF45EbaA87Dl9w+OIW+32JyngVtnpH9tQ8NL03K1EjYkn9fxbUhbXZANwMWcw1mwN8gagyzf/kGpU1tGTvGEuadgTwdno/jTTwxMp6W4/i+JNghOcu8hpHpt2g6ApJC9ImlQX9u82QpUeVuSuvzDNpVXvqPAYfVLOL991FazpFGPYuJSHjhe3C05qYNdfnqgSFe7pl6Os38Cwubq/iwcV3pYNDWl2/vbL7asDQQtIXuq2klgRJ+llCX/SY+Ie73uQ3vXXzsQduPTn28PCsXyHf+rgLL4ApAkABgsfkMXWyUZAPE0i+OT2UN0qh6N3W2klE0IMeXurdJvYiBzx37e9hqOsZk6K/QmvXBTC2zqwJagV1T7Ws7G+uetApNZAvoqfUgCWY95F14x5M8seOMTkL/vsdHqO67zmLl0//guFZzS91a0DhyEMH3JVt9bnmXFnpY+xOmW1gLmU13ihf3pA2zQ7BYWQol4dFfIcWKjjmmrBwjKaW2WDWSU5odLRT4+u+A2Xw7sO/pVOwhBPsYRN+0Zb/V2HsCgQI9yDfHDo2goNFLvRi0tIsWK9x+WUF07BptbG4W8qqivdjnC3pr9hszLjlR2OUzMICVQLPFpXNZa2ySG2ILBT7wQY3DOOr+kp8rcfZPi0si2uBLS3WuaUu+ZPcogxXx9fRxfqxC+hPJtlGE9XUbvq/e /SP3XhXW 76GKQDODdT9hsm0UTT4g8mNKUa2fVzk7H+BUOeTpOgqTMPTl9bYJlgItedxcxZY4qigtL8+zrCOdLZqMvAxB3xpOLE1d2CQA1WMeuT6TGYVVGzdSbarx4a9KhykD00tN5aHpI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/22/2023 5:47 PM, Jan Glauber wrote: > The per node numa_stat values for shmem don't change on > page migration for THP: > > grep shmem /sys/fs/cgroup/machine.slice/.../memory.numa_stat: > > shmem N0=1092616192 N1=10485760 > shmem_thp N0=1092616192 N1=10485760 > > migratepages 9181 0 1: > > shmem N0=0 N1=1103101952 > shmem_thp N0=1092616192 N1=10485760 > > Fix that by updating shmem_thp counters likewise to shmem counters > on page migration. > > Signed-off-by: Jan Glauber LGTM. Thanks. Reviewed-by: Baolin Wang > --- > v3: Use folio_test_pmd_mappable instead of folio_test_transhuge > v2: Fix compile error > --- > mm/migrate.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 01cac26a3127..6ef8b1dea2e6 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -492,6 +492,11 @@ int folio_migrate_mapping(struct address_space *mapping, > if (folio_test_swapbacked(folio) && !folio_test_swapcache(folio)) { > __mod_lruvec_state(old_lruvec, NR_SHMEM, -nr); > __mod_lruvec_state(new_lruvec, NR_SHMEM, nr); > + > + if (folio_test_pmd_mappable(folio)) { > + __mod_lruvec_state(old_lruvec, NR_SHMEM_THPS, -nr); > + __mod_lruvec_state(new_lruvec, NR_SHMEM_THPS, nr); > + } > } > #ifdef CONFIG_SWAP > if (folio_test_swapcache(folio)) {