From: David Hildenbrand <david@redhat.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, Ryan Roberts <ryan.roberts@arm.com>
Subject: Re: [PATCH v2] mm: Remove folio from deferred split list before uncharging it
Date: Wed, 13 Mar 2024 13:32:19 +0100 [thread overview]
Message-ID: <9febc1c2-d497-4677-82ae-945315c2a26b@redhat.com> (raw)
In-Reply-To: <20240311191835.312162-1-willy@infradead.org>
On 11.03.24 20:18, Matthew Wilcox (Oracle) wrote:
> When freeing a large folio, we must remove it from the deferred split
> list before we uncharge it as each memcg has its own deferred split list
> (with associated lock) and removing a folio from the deferred split list
> while holding the wrong lock will corrupt that list and cause various
> related problems.
>
> Link: https://lore.kernel.org/linux-mm/367a14f7-340e-4b29-90ae-bc3fcefdd5f4@arm.com/
> Fixes: f77171d241e3 (mm: allow non-hugetlb large folios to be batch processed)
> Fixes: 29f3843026cf (mm: free folios directly in move_folios_to_lru())
> Fixes: bc2ff4cbc329 (mm: free folios in a batch in shrink_folio_list())
> Debugged-by: Ryan Roberts <ryan.roberts@arm.com>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Tested-by: Ryan Roberts <ryan.roberts@arm.com>
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2024-03-13 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 19:18 Matthew Wilcox (Oracle)
2024-03-13 12:32 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9febc1c2-d497-4677-82ae-945315c2a26b@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox