From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Dennis Lam <dennis.lamerice@gmail.com>
Cc: jglisse@redhat.com, corbet@lwn.net, linux-mm@kvack.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs:mm: fix spelling mistakes in heterogeneous memory management page
Date: Mon, 9 Sep 2024 10:15:38 +0100 [thread overview]
Message-ID: <9fdf8ae7-332e-4266-b43b-df37fd7e20b9@lucifer.local> (raw)
In-Reply-To: <20240908161928.3700-1-dennis.lamerice@gmail.com>
On Sun, Sep 08, 2024 at 12:19:28PM GMT, Dennis Lam wrote:
> Signed-off-by: Dennis Lam <dennis.lamerice@gmail.com>
LGTM,
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
> Documentation/mm/hmm.rst | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/mm/hmm.rst b/Documentation/mm/hmm.rst
> index 0595098a74d9..f6d53c37a2ca 100644
> --- a/Documentation/mm/hmm.rst
> +++ b/Documentation/mm/hmm.rst
> @@ -66,7 +66,7 @@ combinatorial explosion in the library entry points.
> Finally, with the advance of high level language constructs (in C++ but in
> other languages too) it is now possible for the compiler to leverage GPUs and
> other devices without programmer knowledge. Some compiler identified patterns
> -are only do-able with a shared address space. It is also more reasonable to use
> +are only doable with a shared address space. It is also more reasonable to use
> a shared address space for all other patterns.
>
>
> @@ -267,7 +267,7 @@ functions are designed to make drivers easier to write and to centralize common
> code across drivers.
>
> Before migrating pages to device private memory, special device private
> -``struct page`` need to be created. These will be used as special "swap"
> +``struct page`` needs to be created. These will be used as special "swap"
> page table entries so that a CPU process will fault if it tries to access
> a page that has been migrated to device private memory.
>
> @@ -322,7 +322,7 @@ between device driver specific code and shared common code:
> The ``invalidate_range_start()`` callback is passed a
> ``struct mmu_notifier_range`` with the ``event`` field set to
> ``MMU_NOTIFY_MIGRATE`` and the ``owner`` field set to
> - the ``args->pgmap_owner`` field passed to migrate_vma_setup(). This is
> + the ``args->pgmap_owner`` field passed to migrate_vma_setup(). This
> allows the device driver to skip the invalidation callback and only
> invalidate device private MMU mappings that are actually migrating.
> This is explained more in the next section.
> @@ -405,7 +405,7 @@ can be used to make a memory range inaccessible from userspace.
>
> This replaces all mappings for pages in the given range with special swap
> entries. Any attempt to access the swap entry results in a fault which is
> -resovled by replacing the entry with the original mapping. A driver gets
> +resolved by replacing the entry with the original mapping. A driver gets
> notified that the mapping has been changed by MMU notifiers, after which point
> it will no longer have exclusive access to the page. Exclusive access is
> guaranteed to last until the driver drops the page lock and page reference, at
> @@ -431,7 +431,7 @@ Same decision was made for memory cgroup. Device memory pages are accounted
> against same memory cgroup a regular page would be accounted to. This does
> simplify migration to and from device memory. This also means that migration
> back from device memory to regular memory cannot fail because it would
> -go above memory cgroup limit. We might revisit this choice latter on once we
> +go above memory cgroup limit. We might revisit this choice later on once we
> get more experience in how device memory is used and its impact on memory
> resource control.
>
> --
> 2.46.0
>
next prev parent reply other threads:[~2024-09-09 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 16:19 Dennis Lam
2024-09-09 9:15 ` Lorenzo Stoakes [this message]
2024-09-10 21:15 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fdf8ae7-332e-4266-b43b-df37fd7e20b9@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=corbet@lwn.net \
--cc=dennis.lamerice@gmail.com \
--cc=jglisse@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox