From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93BD8C55185 for ; Wed, 22 Apr 2020 13:44:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5F4372073A for ; Wed, 22 Apr 2020 13:44:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F4372073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EC4AB8E0025; Wed, 22 Apr 2020 09:44:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9B288E0003; Wed, 22 Apr 2020 09:44:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB0968E0025; Wed, 22 Apr 2020 09:44:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id C39628E0003 for ; Wed, 22 Apr 2020 09:44:37 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 78BBE824805A for ; Wed, 22 Apr 2020 13:44:37 +0000 (UTC) X-FDA: 76735610994.14.feast39_b20b8404e146 X-HE-Tag: feast39_b20b8404e146 X-Filterd-Recvd-Size: 2656 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Apr 2020 13:44:36 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R241e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01358;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0TwKj2lW_1587563066; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TwKj2lW_1587563066) by smtp.aliyun-inc.com(127.0.0.1); Wed, 22 Apr 2020 21:44:27 +0800 Subject: Re: [PATCH 15/18] mm: memcontrol: make swap tracking an integral part of memory control To: Johannes Weiner Cc: Joonsoo Kim , Shakeel Butt , Hugh Dickins , Michal Hocko , "Kirill A. Shutemov" , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com References: <20200420221126.341272-1-hannes@cmpxchg.org> <20200420221126.341272-16-hannes@cmpxchg.org> <20200421143923.GC341682@cmpxchg.org> <2721c508-9b32-d0e7-454d-386129bfda1b@linux.alibaba.com> <20200422133001.GE358439@cmpxchg.org> From: Alex Shi Message-ID: <9fc87212-fb75-7512-41a3-79ee13fb7909@linux.alibaba.com> Date: Wed, 22 Apr 2020 21:43:13 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200422133001.GE358439@cmpxchg.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2020/4/22 =E4=B8=8B=E5=8D=889:30, Johannes Weiner =E5=86=99=E9=81= =93: >> Also as to the RSS account name change, I don't know if it's good to p= olish >> them in docs. > I didn't actually change anything user-visible, just the internal name > of the counters: >=20 > static const unsigned int memcg1_stats[] =3D { > NR_FILE_PAGES, /* was MEMCG_CACHE */ > NR_ANON_MAPPED, /* was MEMCG_RSS */ > NR_ANON_THPS, /* was MEMCG_RSS_HUGE */ > NR_SHMEM, > NR_FILE_MAPPED, > NR_FILE_DIRTY, > NR_WRITEBACK, > MEMCG_SWAP, > }; >=20 > static const char *const memcg1_stat_names[] =3D { > "cache", > "rss", > "rss_huge", > "shmem", > "mapped_file", > "dirty", > "writeback", > "swap", > }; >=20 > Or did you refer to something else? With about 'was MEMCG_RSS' etc. I believe curious user would know where the concept from. :) Thanks for this comments! Aelx