From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90CB5C021A0 for ; Thu, 13 Feb 2025 13:00:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2DC26B008C; Thu, 13 Feb 2025 08:00:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DDD3D6B0092; Thu, 13 Feb 2025 08:00:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C56D06B0093; Thu, 13 Feb 2025 08:00:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A4B306B008C for ; Thu, 13 Feb 2025 08:00:34 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5FF921A0E4C for ; Thu, 13 Feb 2025 13:00:34 +0000 (UTC) X-FDA: 83114930388.13.21E220E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 849A740029 for ; Thu, 13 Feb 2025 13:00:31 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EWeIwQ4B; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739451631; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mfnvsrTaO3psu4jmIyQdi8eiJDFREwQyTUaQ4HeOqrE=; b=GR8WauAUvaSoekJcZERu/YFvpDwVOuel1luFRj6nRM7b2Lrjtut1eRaJuyQZ8dktEUrRmm RsuLhmRRffrDA6U0249pN8nQ3VBL/59JIpPgosvKzUP+KoHj/97Vb+eOJgdq2vJ/udBwqd 4BS97961fwv/yr/wxBSzoBhy9SjTgIY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EWeIwQ4B; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739451631; a=rsa-sha256; cv=none; b=pzEPY5KwlHnbwzxeKoDZZ7o3ufqVCL1Woe+d1oqSVtcuwGZfjZYfIhQJnaeH4nqbxtsm/g vvbZY+HEPKoF9R4thI+d7VWyBSNKGJzsbuoH/Qnj+0anwejSf64aZ7SUCLXhepaZrzwFAA L4BvXIAM1PaC2EBwRmfkJiZANVErWXE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739451630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mfnvsrTaO3psu4jmIyQdi8eiJDFREwQyTUaQ4HeOqrE=; b=EWeIwQ4BxUWru9ksRItuh+S7+fEnaLcjO/Gb+FGfU4x4SbaaNuCv4HGASGu/XbyU4PdUNZ MoSwVE0atpAQ7yHwrIggoMUMvqAhd+otMyTTD7Elnry9oMQdPHb91/tXxrPu8MqQJ5wgpZ jBb2zCTZ+GBhyqUBgq1/wlnUK8QVWfw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-qs2Vpu5oP4qkKkJpQlIpdA-1; Thu, 13 Feb 2025 08:00:29 -0500 X-MC-Unique: qs2Vpu5oP4qkKkJpQlIpdA-1 X-Mimecast-MFC-AGG-ID: qs2Vpu5oP4qkKkJpQlIpdA Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38de0201875so507754f8f.0 for ; Thu, 13 Feb 2025 05:00:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739451627; x=1740056427; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mfnvsrTaO3psu4jmIyQdi8eiJDFREwQyTUaQ4HeOqrE=; b=oNdNIWl5aesmLSlkxdUz8ZPzc7ri1yKEKYwFO3rj00jx2jCDAx13gyBRHCRM2Dr/OO ta3fWBqtPlzGApB5cU3G4uNJgOgXACKirJYXfL0dsJ9IgdcyWboBbD4U/gWQWyuPrUs7 Obklv0sXLXYu4PfoF/HKLP8azOf2p2u83ZMS1pdXJZKn9kmZEqjuRClVrkFGOIfyzj/P E1yCDRhvIxMb20N1vjmBIyCSXkl564aLgdUmmxisAEkvKv9leFY3C+pT7LQBkicWwWVc hfByaGGpwEqfWs0ZWTdB6qGLQA6F5YqCNjRZmCj17YVMoMf2NFilu/dqaOEeq9Ae7dhK LDYg== X-Forwarded-Encrypted: i=1; AJvYcCWu/e9gMNDGzQ1MHmwMn8WTd2bQyAESiZj+6ZlcNbRSH8pu7FlChQShZksySm/XiNgPpxr7xhSVng==@kvack.org X-Gm-Message-State: AOJu0Yxp3vILruCLSzN2K5qdJjvJFfd4K0HhqD4B70rngY2DE96Ib+Sz HXfZEV1lGMn2PPId2bdpZFj/MkHbGlXIMaHQioDNqBOCGlnyBVYa3oyTS591b3VWg9CoIcryt+U tOSAdpH0bZCogrOS3u87ItBuWs+MXZobKd3aiCZFwIFQ0zcpmI0RtinWu7g0= X-Gm-Gg: ASbGncukKBgeXISJwISSuhb+XQ9pktESug0MVPMPB6+DmsrS9+qy/rvw9tOMvrIiZjp lt/NCaL/9p8/i4Pdp9ucM7qCFCCBRUjmtXfGCeNSycnz8j1chBokx+n0kE1QFgd6X5xUpXUUFmh AbSJcIG0iUadSTCp4LXd3WFchEf/hfxhUmcJLUXf5O8MFMQKfDKmQKovVMruJoBzyZv1haXjzaW N86WuCEBIyd26DnczXEbVYp1kBMaRuXcVAEddCkU7EFndRq0IPZ35bvw0hqEHC6mEZ1q4gcHsIu ipK3u3pdmBON0ildyst8wOtmcIc/WlQmMH+o+sOtIB0yBHnyM+4AKz6YWIV069W0EbTLIH+s8qA uznh1QC5OkiCmI2/yNSjvgMuGE7U85w== X-Received: by 2002:a5d:5885:0:b0:38d:da79:c27 with SMTP id ffacd0b85a97d-38f244d5085mr3180654f8f.2.1739451617214; Thu, 13 Feb 2025 05:00:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IGibeuFs5cDXtn7xG1Fnqp50UyOedeKGyfYtUsGJrtkfYfZ0quTGv8DvIIEgk1u1kG0YtabFA== X-Received: by 2002:a5d:5885:0:b0:38d:da79:c27 with SMTP id ffacd0b85a97d-38f244d5085mr3179420f8f.2.1739451611117; Thu, 13 Feb 2025 05:00:11 -0800 (PST) Received: from ?IPV6:2003:cb:c718:100:347d:db94:161d:398f? (p200300cbc7180100347ddb94161d398f.dip0.t-ipconnect.de. [2003:cb:c718:100:347d:db94:161d:398f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258b4423sm1871351f8f.11.2025.02.13.05.00.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Feb 2025 05:00:09 -0800 (PST) Message-ID: <9fb47de6-0d39-43df-b11a-ec188ecd90c8@redhat.com> Date: Thu, 13 Feb 2025 14:00:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm 1/1] filemap: Remove redundant folio_test_large check in filemap_free_folio To: 'Guanjun' , willy@infradead.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250213055612.490993-1-guanjun@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250213055612.490993-1-guanjun@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mrUHnCputwwtfpTdX4fbHz_knDUcpFQ3t4y5smqyibk_1739451627 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 849A740029 X-Stat-Signature: mbo7iz9tmdcw4yyenxpregbgxgyzbkj7 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739451631-621830 X-HE-Meta: U2FsdGVkX1/tuK4E6oim1Rh0gGRMiE3b7DIopJlAFdoSB58vAe92HhpVoe65O16fMs5FQhOWx0khcPMO+85AhjSldjgmE6Q9jN6hvHroKpePwUDUJ92zWrk3dqZjIAa/IL085dnnry596R25lXD1tEQq33EADgCqtKKu4VD0TWbGtKxH31jDbCdJ0m0CloyG6Wdh28A0bx+fZT/vkgev0QWOEWND0CDPNImnxUycm11vbSzLIBI4CikuwSReFnXBX8HKklp8+eIGV4fFX13/lAd4gktCY/AbWt3RKe6tvlyImYlayWPWZc4kd6lR/HSuMHTcsgToftqBDy0nZfcvgqzz+nQjbnnaZUhinEb+DxGl4CiUdixqxdpUjmYKYnpvS2uJySIz9NUh/9LMV0XrOKanedHJhfyYW/ERxTglMsqXC6kQSt84y7LkPrEQT27cIvgPWasOiYtLKj+SC49+4oZ96TnvBtYzX8499SkIs/3Dxf5X4NJ/8opktfcWIJaiB9qbm/n8uzS4G/s5yVNDpXKDZzjubsmOEWPsCRhPeydfN/WgnYry8Cyt19Xm0wJyewY4ATE0DVqik0DsSfWqe7ZQ11fU10NGmyLRfNstjB8odfGpdmpCt/FKywQeWC1bhbseQvVsjYvlnv1FORIcswXYmSOC4oNEHBu1LzeuAHTSxkfw4maCaLX4D3GrEfItiuqTydsv9DrOsLTx2x6ADfAOSJ9paXkvO4VkSX03M4SiGsavVdBWEw5ddszXCh45bZcBSdPlh2f9DnvDxDp1ibMeng21LKbUYjCWEkUy2cUiU3vYMMMgi3IuVBqUZaOZn55jFYjHfua3Hj6K/KinkGmHQf8KSsBcH33IOOo/1ZZZA5XOzKu+sxvr/HlfXH741BahlEFFooAK+HAo/rQYNDdoOeTjxjLRJxxBgqH21YBxHOPBDmpioULd49DsHUf52KFjnFhtfrZusSUF9/C Fe9SUbvu JoD9WJ9GBfZXDlIr9+IkOzQkrHETYYR4kr2PlOesGhba1SoKCi5VIagwmarDOIk1Fzr2eamScuP0UsoJXO/yIifb4xj1/t97Wp1oc3WaLvJoWD1gP2zzoMuLbMffFGOtRZp/u5oQt1slaqNkFxG5BkmdhyIjwq0XRumcscrM9KLgJP331012B2zmBPl5hn1l90yGn63ISZlYOvljdbF5jgsTJ7JdCiziHx/dis+kt0Gxoy23DzRAb+DpIaj+GEskwRtVTDpbCnu1FA5PNXN4dPcLnNffFG7m/VOnNL3iP2xoN/oq8ztgM5OK7Bu/+I8LGkxxDd4R6bvjtJhCToHD2utuaDf1P8HOvIHIycll2aAlSK8sKJnUFw1EXyC3pQ/SKjPEz53ezxkzyteiwwAsVRIHZE/GLI4lTBj5yjQ6ZUZjxg+jqY04K8PV8kCD0JczkO+LU0xUcyYkR/FS/nAn9PpRZWGWUlRwqdezv2gvfdtDbKpU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.02.25 06:56, 'Guanjun' wrote: > From: Guanjun > > The folio_test_large check in filemap_free_folio is unnecessary because > folio_nr_pages, which is called internally, already performs this check. > Removing the redundant condition simplifies the code and avoids double > validation. > > This change improves code readability and reduces unnecessary operations > in the folio freeing path. > > Signed-off-by: Guanjun > --- > mm/filemap.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index 804d7365680c..2b860b59a521 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -227,15 +227,12 @@ void __filemap_remove_folio(struct folio *folio, void *shadow) > void filemap_free_folio(struct address_space *mapping, struct folio *folio) > { > void (*free_folio)(struct folio *); > - int refs = 1; > > free_folio = mapping->a_ops->free_folio; > if (free_folio) > free_folio(folio); > > - if (folio_test_large(folio)) > - refs = folio_nr_pages(folio); > - folio_put_refs(folio, refs); > + folio_put_refs(folio, folio_nr_pages(folio)); > } > > /** Acked-by: David Hildenbrand -- Cheers, David / dhildenb