From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36852D69108 for ; Thu, 28 Nov 2024 13:08:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBF056B0083; Thu, 28 Nov 2024 08:08:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B6EFB6B0085; Thu, 28 Nov 2024 08:08:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CC4F6B0088; Thu, 28 Nov 2024 08:08:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7BCF86B0083 for ; Thu, 28 Nov 2024 08:08:35 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 335C7141D2D for ; Thu, 28 Nov 2024 13:08:35 +0000 (UTC) X-FDA: 82835532822.16.7D2C5A7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 8B18D100004 for ; Thu, 28 Nov 2024 13:08:19 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H53l8vXB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732799306; a=rsa-sha256; cv=none; b=7Klk8Ruij3PAbcQ8kOSVYUQ9goCgKhke5JMhB3SdVjwcis28+Ib8bwacLecM8l4i0jfZRH 6agIOI7PUORvVVLkTpWO6A1SfxH1B3QuPPElK3yrlOWjM9c6X/eeXfuE/NkAfx2xLgBuO2 aNWaQw4fo5bfO3OTJ2Go+8xWLTklzq0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H53l8vXB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732799306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6WVLrMW4PgfFUurlgLPd9Tg1Y80e1mcQMpUaoH4fb9Y=; b=rrND/7saQJMOXwy8MIgGwRGQaZKpFjcAEY9oXImXjMr4SAzm2KOZry6VDelFZD6Y/kmV3G Xrg9NSDmfyl6XzfpQqVOZHw+vII4HtDQIpRiBKGPuKJUuBR9VJGR046YW6Pd4WCU/7cFUF AdoqJ0Mnl3AWSZlxOwhueTBh15YbbDU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732799312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6WVLrMW4PgfFUurlgLPd9Tg1Y80e1mcQMpUaoH4fb9Y=; b=H53l8vXByQ+1yXt8hsHpyipzc76ku/ZHmaB5kcSqY2+nIlWissDNwOoYbFdpQBnTTsqfdc 9tYakUpZmguWu3AQXada+iEhvYXp2RnuXYAcQt1bczSZXDwolaZaq/ZUDyxmoOFBk1rSUE mXmGr79E8J3Ni3CWhvlG+Ndk5LsyKg4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-hMAFrkSXNpanu0ZfaM-mYw-1; Thu, 28 Nov 2024 08:08:30 -0500 X-MC-Unique: hMAFrkSXNpanu0ZfaM-mYw-1 X-Mimecast-MFC-AGG-ID: hMAFrkSXNpanu0ZfaM-mYw Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4349df2d87dso7532685e9.2 for ; Thu, 28 Nov 2024 05:08:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732799309; x=1733404109; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=6WVLrMW4PgfFUurlgLPd9Tg1Y80e1mcQMpUaoH4fb9Y=; b=rRKlNcFFPwj6cuaYfzVhDt1z5Mxhe87kYjyCOE1iTlSkJuWpUhcl/K5lY6R7hTO63g 3pKhb6A8yHdqS9VSMiyuaVP5jNsm+YSt+QsFOgTtkrj9ID7d4AJsHp9peJNiW8Cqp9+q iUwqXOvXpMpWVs2SdSPTm4e45dWT9mStszJKSETbwBatseTO6xfRp4hnXGTjUMKcltJ9 5iVaDiWIi1bkBxpeUmYHdyCIHZyA0FHk1EJ5JdRAUNkJZ7frKeHmWbckvWpLWmUwu8sq kKpHRZ+WpVcnmvkmUnKYJ6j0XQ7Y/4PxCO8QDABZh52aLyt1bW6n5Bp2U1xMA3DAOK31 m3Fw== X-Forwarded-Encrypted: i=1; AJvYcCVEOk2jFHv4+q4LTyFL7b5S2E7oI9DBtP9qb4LQM8wC8XU8B1Jn71qS4m4YFOZFry9k1y5RlSqjZQ==@kvack.org X-Gm-Message-State: AOJu0YybMtZKnGt+KbACKxCT4B9NeEvadZtnUY7GLRAw6RCRRyKlU9z5 kMErxIYrel4Pxt3NGwPVb+6eJtuNE5qz4+Q5bsiku8CaNeecuvDVQ9Tds0maSZpUsDtB9Bbsfkq itum9EpNoCFBH6vX/VSlW2LQrNLWblWRtNtcnHAWnxeGEGQB3 X-Gm-Gg: ASbGnct7xAZKI06Dho3REpyVTv20lxC061GT/dJdfV7n2JrUlJNWj+6e3bocemyGSa4 mqeUGgVz1CWmGlrmWcsjKYQmgKoobUBMgef6HLNjiguIgestaxzdCM9NjKWlfH4XGZY66SGzKBg KPDa+sp/vIVzvqCLb2GtSJr8YlWpwaFFToRnlh8NqICuM7y5IkrdT7ArRmKKHQJc84z0PEIUYlx 9MNcpl03VhbTqQhXV29VdNr78MKZn45CT/OLH1rI1i5iIC4XnEz41ssQwvaSY+nnlr+zFXZLTT6 dkGdPjjMSBkQ7MOiiA2hFWkKdf94kkfBdwRih4dIEo3wJk52xnlOUhVLj4RmJZVFy9dnNyE58gI = X-Received: by 2002:a05:600c:4686:b0:434:a986:11cf with SMTP id 5b1f17b1804b1-434a9dc3030mr74568495e9.8.1732799309610; Thu, 28 Nov 2024 05:08:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYU2FIWFdBgjrp3Pqs3E01oigMpUF7ykjhtFFQMA7mQkYi/Kd3ajnsobPltJT21a/3mX9/Aw== X-Received: by 2002:a05:600c:4686:b0:434:a986:11cf with SMTP id 5b1f17b1804b1-434a9dc3030mr74568165e9.8.1732799309201; Thu, 28 Nov 2024 05:08:29 -0800 (PST) Received: from ?IPV6:2003:cb:c714:1600:f3b:67cc:3b88:620e? (p200300cbc71416000f3b67cc3b88620e.dip0.t-ipconnect.de. [2003:cb:c714:1600:f3b:67cc:3b88:620e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434aa74f1e6sm54103115e9.9.2024.11.28.05.08.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2024 05:08:28 -0800 (PST) Message-ID: <9f9fd840-6421-43b5-9a12-edfa96e067cc@redhat.com> Date: Thu, 28 Nov 2024 14:08:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] perf: map pages in advance To: Lorenzo Stoakes , Peter Zijlstra Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox References: <20241128113714.492474-1-lorenzo.stoakes@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241128113714.492474-1-lorenzo.stoakes@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MfZuprF_Oxi5qPIyL5dc9PRQtnK00h3p5qy-9T-df8o_1732799310 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8B18D100004 X-Stat-Signature: hk3mkwef7urzxh5qqw3nguotnfks8jc3 X-Rspam-User: X-HE-Tag: 1732799299-655320 X-HE-Meta: U2FsdGVkX1/KMb4ZbJfh+HQG0D4urdmW207Oa5SA7pA7FfMIPDiRW0zbcZXu5SmxAmkpkZTtPbKUtTkTyV72wVDIUU93e3KbRnXANKT15hz/Gke9v2KUFdgWpNdX6kZFe01PY5Fg3idHQ8ab7d7R9+BLx8IQzCvSxEUGNskT/KJldo2+HU9nce6ATT22Vd0Di4BcZr3MGX3s53LX0pz4NMzZRYOL5nvheMOT8bdCkDXXRv/OhvcQmxw7blqJOj5fyMQoqTGp91QC14QSaN8Xhc7wqYv/1SGLiPwLLhvlvdJCOLhP7Y8wNktWylVv5n+UZBD0rs/4HtE/KYSAFJd4kjiTtJj0MW85xHoU0I2Qo0Pze6ZsiECNZxAA/navIGgGW/AtMgC2nR8NEA2RMLOXbvai23+dw+35wQxESBSExTp/JPOqhQkSvWe2pjI35AEGenUNDlqiqzfAsLgPhc2TDqHd15vh2cE61kpHAHxQ519VPkt9a3YlCgO5ldX55loLKhwDfBI944xb+e4Yw2KTXLLEYidOZnPfw+InTm6xgAni3+kfUlpzs2mC6XQO5PaSFwJhFHW1S5915SLvr75wcUc6VjGGglUR6WzcMuMcouyCBp1qdrl0YeK1tMZ/PoZ1VyiESEA9m0Tw265pF5A7Fv5SWCZMV1xl0SgOPRLsGD265Mu+Jj1ry9iQoXva+kVWDRJWL0qXDzs0DW1+Lvy/RM5gOzJUy+VzXTsj0EoM8l5t1zJXHuKwi+R+Iq76ypAkqe6vofvy7z20V/7xvYlLgvIrd/1lVmZGdBJE4HdhEjnT9xSPlUDCiAhi1SUDkr7O7hf9ojkkDQR/19R6nO9+FD+VcI6FVY/xZtDo5ZMwfn2/lPX/LYvk7z6OwTyhPMDk7GFDiblxtTUD8WAAA1sU0lLV4ru1s/teKMzEv9Y46F2ujq4Nab9HQ8Zz3af/dNdfiFi3qYoFhnQwBubqXN2 kLl3KJDL 7WYfZ5SGL8SkAxu2sZslM+3zLGM1tuFnoASlLxTZYCFTKsNbEEdMdD2IhTX7jKrJH+Pgrj3iVcbB6RK1mE/zllHIcOsLNIXOUJ1bHwPCrTRpJk+7mOPA4WIHTxK1SS6cSEj0205Pz3wAB10W5U7Mk3ifEh1GL0mv6/HLqCekqRhuSf233RLf+MvoipGxdBdR1cVnGsXsXmJXmgvxVWMYQcf7HfpQdMbJQ98t0hJpKEKYj3Gyr64QP0sju/jE+MRqphU4R0F3wQQyJN70NVNItHYnbINLWIi/5PQd5ravjifjc+rC7v4jhvymTSscTnZS274TdantU36jhHofjrQqWYgkXjOqnMuWlja8agRQnu9x3h0ydzPbisA3pBIG2bZT1Tlz3sRRdviRE1R+xsuMFmHlLKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.11.24 12:37, Lorenzo Stoakes wrote: > We are current refactoring struct page to make it smaller, removing > unneeded fields that correctly belong to struct folio. > > Two of those fields are page->index and page->mapping. Perf is currently > making use of both of these, so this patch removes this usage as it turns > out it is unnecessary. > > Perf establishes its own internally controlled memory-mapped pages using > vm_ops hooks. The first page in the mapping is the read/write user control > page, and the rest of the mapping consists of read-only pages. > > The VMA is backed by kernel memory either from the buddy allocator or > vmalloc depending on configuration. It is intended to be mapped read/write, > but because it has a page_mkwrite() hook, vma_wants_writenotify() indicaets > that it should be mapped read-only. > > When a write fault occurs, the provided page_mkwrite() hook, > perf_mmap_fault() (doing double duty handing faults as well) uses the > vmf->pgoff field to determine if this is the first page, allowing for the > desired read/write first page, read-only rest mapping. > > For this to work the implementation has to carefully work around faulting > logic. When a page is write-faulted, the fault() hook is called first, then > its page_mkwrite() hook is called (to allow for dirty tracking in file > systems). > > On fault we set the folio's mapping in perf_mmap_fault(), this is because > when do_page_mkwrite() is subsequently invoked, it treats a missing mapping > as an indicator that the fault should be retried. > > We also set the folio's index so, given the folio is being treated as faux > user memory, it correctly references its offset within the VMA. > > This explains why the mapping and index fields are used - but it's not > necessary. > > We preallocate pages when perf_mmap() is called for the first time via > rb_alloc(), and further allocate auxiliary pages via rb_aux_alloc() as > needed if the mapping requires it. > > This allocation is done in the f_ops->mmap() hook provided in perf_mmap(), > and so we can instead simply map all the memory right away here - there's > no point in handling (read) page faults when we don't demand page nor need > to be notified about them (perf does not). > > This patch therefore changes this logic to map everything when the mmap() > hook is called, establishing a PFN map. It implements vm_ops->pfn_mkwrite() > to provide the required read/write vs. read-only behaviour, which does not > require the previously implemented workarounds. > > It makes sense semantically to establish a PFN map too - we are managing > the pages internally and so it is appropriate to mark this as a special > mapping. It's rather sad seeing more PFNMAP users where PFNMAP is not really required (-> this is struct page backed). Especially having to perform several independent remap_pfn_range() calls rather looks like yet another workaround ... Would we be able to achieve something comparable with vm_insert_pages(), to just map them in advance? -- Cheers, David / dhildenb