From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 196E9C433F5 for ; Wed, 23 Mar 2022 08:49:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8830F6B0074; Wed, 23 Mar 2022 04:49:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 831836B0075; Wed, 23 Mar 2022 04:49:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F9616B0078; Wed, 23 Mar 2022 04:49:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 610446B0074 for ; Wed, 23 Mar 2022 04:49:53 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 28ACB20AF9 for ; Wed, 23 Mar 2022 08:49:53 +0000 (UTC) X-FDA: 79275028266.12.B873386 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 4E3CE16001E for ; Wed, 23 Mar 2022 08:49:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648025391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DuaFBfkU5mZppkqVIrrjjLRuEeroDbRieuMkt8MGpmI=; b=PzAnbJaurH7sZ8JLSeqQUynwFNgfH1CeXZugKuT7Hsp7tVR9yN0+3296SrJx95RhwRAK95 OmkfbPn8R7Gvmgl1yFggfzEXNWv3RUScRqDakx2oiMnqJlMWAMAXaX8SA1+bkToA+4QpXQ V95subUEe/TtL7SjIE5BQZQ7xzatTi4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-300-hEFXV6jDNpKwhtRs_S1kiw-1; Wed, 23 Mar 2022 04:49:50 -0400 X-MC-Unique: hEFXV6jDNpKwhtRs_S1kiw-1 Received: by mail-wr1-f69.google.com with SMTP id p9-20020adf9589000000b001e333885ac1so270079wrp.10 for ; Wed, 23 Mar 2022 01:49:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:organization:subject :in-reply-to:content-transfer-encoding; bh=DuaFBfkU5mZppkqVIrrjjLRuEeroDbRieuMkt8MGpmI=; b=NZrno9iU0kmwo+iW1XDicuzr/guJNODwT135+emwJwnTDabN+AIDmr5MGee4hxDiGC Bz+ILsAB0NR9Ee7myZk+Hojjp1BGg5/dau2Fq8KvUTQdp0eN/LlWakTb9rq5tBkTI8NP uSK58RBlp7sfDEbxFiqEWnU9sy3m+vW18bLa+UnFlExyXIn6R9P/8oU2G2U5HrNANijF P2kJSgM/nxaQGfyl9hiKWZ2Zkul2IoZ9LPrBWeXlav6x8mZF01Uz3BAGU/RAKfloZXHK LBtsTGa22NqaBSpsPU/7NXy8vHogXZ2HvhTiw50TnjJPeHKY+FHdoQqkmgyi/V2UYxJg yzCw== X-Gm-Message-State: AOAM530zOp+eOwtfTMTQKtEOEEFPV6+ZSf7NQxP8pWkgwUgT+9oWC7ZO tCByFE7mERfsKp1fuN9BTKLnd9SP6rp0iDbJuJf9h41JxB3cnpaKVd2fEB11p7KvZPvwloCl1fs dmAsCp0Ikk+Q= X-Received: by 2002:a5d:6f11:0:b0:203:ff6b:5df9 with SMTP id ay17-20020a5d6f11000000b00203ff6b5df9mr17313715wrb.361.1648025389206; Wed, 23 Mar 2022 01:49:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSnr0uXtRn05WsTbb0UWoFxm84f7c+DyhXxFVQhbmoS9ZDQtkNLkurqKhCs1uameHDB7HjEQ== X-Received: by 2002:a5d:6f11:0:b0:203:ff6b:5df9 with SMTP id ay17-20020a5d6f11000000b00203ff6b5df9mr17313695wrb.361.1648025388968; Wed, 23 Mar 2022 01:49:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:a300:f7c1:f4a5:f958:a561? (p200300cbc704a300f7c1f4a5f958a561.dip0.t-ipconnect.de. [2003:cb:c704:a300:f7c1:f4a5:f958:a561]) by smtp.gmail.com with ESMTPSA id e8-20020a056000178800b00203da3bb4d2sm18730863wrg.41.2022.03.23.01.49.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 01:49:48 -0700 (PDT) Message-ID: <9f9ddbf7-797a-58d8-2903-beacb2698329@redhat.com> Date: Wed, 23 Mar 2022 09:49:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 To: cgel.zte@gmail.com, akpm@linux-foundation.org Cc: bsingharora@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yang Yang , Ran Xiaokai References: <20220322110444.2340748-1-yang.yang29@zte.com.cn> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH] delayacct: track delays from COW In-Reply-To: <20220322110444.2340748-1-yang.yang29@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4E3CE16001E X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PzAnbJau; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf08.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: xsi5w97u17ucixmgtz8xsk1ekobfbt9h X-HE-Tag: 1648025392-483677 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.03.22 12:04, cgel.zte@gmail.com wrote: > From: Yang Yang > > Delay accounting does not track the delay of COW. When tasks trigger > much COW, it may spend a amount of time waiting for it. To get the > impact of tasks in COW, measure the delay when it happens. This > could help users to do tunnings, such as decide whether to use > ksm or not. > > Also update tools/accounting/getdelays.c: > > / # ./getdelays -dl -p 231 > print delayacct stats ON > listen forever > PID 231 > > CPU count real total virtual total delay total delay average > 6247 1859000000 2154070021 1674255063 0.268ms > IO count delay total delay average > 0 0 0ms > SWAP count delay total delay average > 0 0 0ms > RECLAIM count delay total delay average > 0 0 0ms > THRASHING count delay total delay average > 0 0 0ms > COMPACT count delay total delay average > 3 72758 0ms > COW count delay total delay average > 3635 271567604 0ms You should also update Documentation/accounting/delay-accounting.rst most probably. Overall LGTM and this might be of value not only for KSM but for anybody using fork(). There will be collisions with [1], especially [2], which I want to get in -next early after we have v5.18-rc1 (after rebasing [1] on top of this). We'll have to decide if we want to also account hugetlb wp code (hugetlb_cow), and if we want to account "unsharing" here as well under cow (I tend to say that we want to for simplicity). For THP, we only split and don't copy, so there isn't anything to account. [1] https://lore.kernel.org/r/20220315104741.63071-1-david@redhat.com [2] https://lore.kernel.org/r/20220315104741.63071-14-david@redhat.com -- Thanks, David / dhildenb