From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9263CCDB482 for ; Tue, 17 Oct 2023 08:13:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E5DB8D00FB; Tue, 17 Oct 2023 04:13:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 297448D0007; Tue, 17 Oct 2023 04:13:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15FD38D00FB; Tue, 17 Oct 2023 04:13:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 00AD78D0007 for ; Tue, 17 Oct 2023 04:13:57 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C2C51160F52 for ; Tue, 17 Oct 2023 08:13:57 +0000 (UTC) X-FDA: 81354240114.12.158CBA9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf14.hostedemail.com (Postfix) with ESMTP id A56B110001B for ; Tue, 17 Oct 2023 08:13:55 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=FtCLP5U5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=UrbsHyAi; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697530435; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l8Uxvnp+afGL5t1DPxVjcVWqjHuaCiM0M/YSyAS3x4E=; b=v2QffZrE6Y4i6L5OFHqEH6uOx5e2LjTZXrz+7D9yEtwlmReOwSUu3OFRSWps3kTaKjwzgk qNg1F4cV+zrTfeFwUPGwD55TD2zBavIsFvYV9ALRUwjbieoZobhUGBPG6Fw8oWirwDFDmn PofP14cRimFvXTVF11Mvs/vA2fM+iJY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=FtCLP5U5; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=UrbsHyAi; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697530435; a=rsa-sha256; cv=none; b=pSUj+qzxTUsDK49Jmhhmga97seRboSMxhdRbomH5gL+YavA8S2q/yVqGKkP3/w07wF13Kz VD9rMO+cjejsk9ICSi16caByPGVaF3vDWjFc00wC2oKywR60J6ORVYR4IUdfGjnB7zR39u 7axeCsiGFnFwUymxYGIGUpA3O6ylkOQ= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EEEE31FF08; Tue, 17 Oct 2023 08:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1697530433; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l8Uxvnp+afGL5t1DPxVjcVWqjHuaCiM0M/YSyAS3x4E=; b=FtCLP5U5FalpC0rLexHkLEUc+2h3Id1WDJBdGAugXH9+EiErwtHd9qr9LfctYqdVPE4qKY 8dhNLd4L8zyqWLXtJPp5ZEkYA+craDDv7I1K8Fsad5AKRPk205agpClwyc37EGJmHAEeZ+ ZslMYcVQAA+5A13NUiAzWhwX5IYekts= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1697530433; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l8Uxvnp+afGL5t1DPxVjcVWqjHuaCiM0M/YSyAS3x4E=; b=UrbsHyAiclGuToXCnLZNBgll+JueGSvT2KvJKPlQb/vo9dXj47okB/vFBZg5VW4omOzVdA vhzFMe1sae6MkABQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D3F0213597; Tue, 17 Oct 2023 08:13:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8TElM0FCLmU1RgAAMHmgww (envelope-from ); Tue, 17 Oct 2023 08:13:53 +0000 Message-ID: <9f91b2be-dfb2-8bc3-91f8-6bd0715cc89d@suse.cz> Date: Tue, 17 Oct 2023 10:13:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 5/5] tools/mm: Update the usage output to be more organized Content-Language: en-US To: Audra Mitchell , linux-mm@kvack.org Cc: raquini@redhat.com, akpm@linux-foundation.org, djakov@kernel.org, linux-kernel@vger.kernel.org References: <20231013190350.579407-1-audra@redhat.com> <20231013190350.579407-6-audra@redhat.com> From: Vlastimil Babka In-Reply-To: <20231013190350.579407-6-audra@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A56B110001B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qmeuj9xwapfkndee4eqw967fiprx6uif X-HE-Tag: 1697530435-500331 X-HE-Meta: U2FsdGVkX19UExaY2TwA1e342npD9aS+62WmNvfjdHUIKUyTXiPv9kvzaX1EmrsgzwbZuDJys1R/n48aYwQ8HTecPdXNJUSElvwx9mH+UZ9GaHs6lP9tv2/42B8O9uuQOBiAJN7hwes5Wz8H2F8QJ0m20gNr+6Sr+ELC5c/drSaD9rb8XyLldfsLkvvJgvXp9nK+ZmjjPoNPW7UEeJLFra3JS6CRZwBJIcZwdJe7NyW6LYULr2ZIdYU7hJuoXbJxaZpmWR9oyLQxT5dzIchPicJcAKz6TEz/4bQUMeyx5NTLYNakqV315mCblHvPTS+BH/NO11Hpo29Tfoehb/0mKssscYeMuRQ0x6SQ+scKaxFwwx3NzdaV/v5nJ9cT09JImLCGwgBaTXmqoc5ojBrjyThn+anWbvJqlfYb9eieWnfK33Uu5o9xP2XRDXGIfJSSKg46LmmFqB0BvVf82m8CObm92BgmlSRD1SVaA2cKlzePLtKNRgN8eMXqpwJHJ6iILsP/CUlUnE8GW7C6WsxgFOAm/FDskJqzaVcf4fdJsxT2xeoWUczdwzPidrkWsNrVoFSIybSj4MWpK3ZxKI/wZkt0IVWYzwn+as6jclqmtcm54U3/JJZYIJ572BligVTGtwMUvhEK41pgAe36oyRhz/xA2qAiYJENUfRH6rDqYuweWxJswwLfqfdEOucRQFgckjO+XHUS2oM2AzCetgzbU8pVQt/IuGZ3EDuOF1No+SRxoAFMYKg1JkYoPmASa0pO1JN99whNrVgx4t+oPVzZQdncu/D4OEIIoSCaCl8FZk31d41g1nHy/GR50oXhleEyaoJ50ot6cvuOUtNPMlZpC4XDzqCdjGUcwKHJu92dtTSeXJA1YibThchJf/fRhcod2zCnc8LLSNKqul6GEerI9eZFLVFXlazpwyoM8W1T7mFzdSur8O8FNEjDb/LYI7VBgDbSv35HJpdoMBXGLfH OSphvFk6 2rJZjFzXLJp07gPytW1LjMtt3+jv6et7FE+Peh6Mo0aNS8y702cpWw3Vugw67U/nPixY1iIZFeg+MAlPiDQgguxNiNQLYMLYOLYiFBS4pmthQ6icMX4RXN4jt+3y8AYN6BTCNWNYCBPHa/Ape2oGQWPKQhpm4eIY3YV29vnqwsvSwTknkeGGN4rJMxnaDshTrIm/D/gOu5ynNGzQKKnr1YmbWHjHbUGnl3g1ETEyJd2I+98HcJDrRtHwmYSSnQWzupXss X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/13/23 21:03, Audra Mitchell wrote: > Organize the usage options alphabetically and improve the description > of some options. Also separate the more complicated cull options from > the single use compare options. > > Signed-off-by: Audra Mitchell Acked-by: Vlastimil Babka Thanks a lot for making the tool useful again! > --- > tools/mm/page_owner_sort.c | 33 ++++++++++++++++++++------------- > 1 file changed, 20 insertions(+), 13 deletions(-) > > diff --git a/tools/mm/page_owner_sort.c b/tools/mm/page_owner_sort.c > index 5a260096ebaa..e1f264444342 100644 > --- a/tools/mm/page_owner_sort.c > +++ b/tools/mm/page_owner_sort.c > @@ -634,19 +634,26 @@ static void print_allocator(FILE *out, int allocator) > static void usage(void) > { > printf("Usage: ./page_owner_sort [OPTIONS] \n" > - "-m\t\tSort by total memory.\n" > - "-s\t\tSort by the stack trace.\n" > - "-t\t\tSort by times (default).\n" > - "-p\t\tSort by pid.\n" > - "-P\t\tSort by tgid.\n" > - "-n\t\tSort by task command name.\n" > - "-a\t\tSort by memory allocate time.\n" > - "-d\t\tPrint debug information.\n" > - "--pid \tSelect by pid. This selects the information of blocks whose process ID numbers appear in .\n" > - "--tgid \tSelect by tgid. This selects the information of blocks whose Thread Group ID numbers appear in .\n" > - "--name \n\t\tSelect by command name. This selects the information of blocks whose command name appears in .\n" > - "--cull \tCull by user-defined rules. is a single argument in the form of a comma-separated list with some common fields predefined\n" > - "--sort \tSpecify sort order as: [+|-]key[,[+|-]key[,...]]\n" > + "-a\t\t\tSort by memory allocation time.\n" > + "-m\t\t\tSort by total memory.\n" > + "-n\t\t\tSort by task command name.\n" > + "-p\t\t\tSort by pid.\n" > + "-P\t\t\tSort by tgid.\n" > + "-s\t\t\tSort by the stacktrace.\n" > + "-t\t\t\tSort by number of times record is seen (default).\n\n" > + "--pid \t\tSelect by pid. This selects the information" > + " of\n\t\t\tblocks whose process ID numbers appear in .\n" > + "--tgid \tSelect by tgid. This selects the information" > + " of\n\t\t\tblocks whose Thread Group ID numbers appear in " > + ".\n" > + "--name \tSelect by command name. This selects the" > + " information\n\t\t\tof blocks whose command name appears in" > + " .\n" > + "--cull \t\tCull by user-defined rules. is a " > + "single\n\t\t\targument in the form of a comma-separated list " > + "with some\n\t\t\tcommon fields predefined (pid, tgid, comm, " > + "stacktrace, allocator)\n" > + "--sort \t\tSpecify sort order as: [+|-]key[,[+|-]key[,...]]\n" > ); > } >