From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A77B3C19776 for ; Fri, 28 Feb 2025 12:29:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48C66280006; Fri, 28 Feb 2025 07:29:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 43C16280001; Fri, 28 Feb 2025 07:29:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32BCD280006; Fri, 28 Feb 2025 07:29:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1D82D280001 for ; Fri, 28 Feb 2025 07:29:38 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B1EF3A1AD3 for ; Fri, 28 Feb 2025 12:29:37 +0000 (UTC) X-FDA: 83169284394.05.F7B650E Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP id CD603A001E for ; Fri, 28 Feb 2025 12:29:35 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf25.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740745776; a=rsa-sha256; cv=none; b=qbBduzprTy60H9vBomrT/lKIUWimelQC9fJUIvrXM+oA8U7u4GFjX8M0LW4p5GJE58eHie quha/pMFs5ybktaTY0lmF7VGg2l0pJQFBaf5NgdLBNC25wGkXGz5D0gTB2bEmVH8Iwf4sg N/dXkIUt5p9KZCMLsdhPXOFcPqMHdlU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf25.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740745776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iIx8AaB1XQy68ITCtoaTk4nxfNAnjzJTn1t1mFpJ3h8=; b=5Y8IRSbEfQH1jJV1/wxfD0G6+jjojI761vFO2Eagoyolad0z4izIdjAOUjisBLq/yl83tt 1xfG19QR3H/KciwY373P/bi2YVNTmSUZfHbZFxG/aPE6WQFzf4Km5lm175jip4ylO+sA+s YFeHAI3HLfdHo8Ib6jH2V1e/m96uto4= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D6A11688; Fri, 28 Feb 2025 04:29:50 -0800 (PST) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CBE3B3F6A8; Fri, 28 Feb 2025 04:29:32 -0800 (PST) Message-ID: <9f9192cc-245c-4adf-b72f-61f0537e7f26@arm.com> Date: Fri, 28 Feb 2025 12:29:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/16] selftests: vDSO: parse_vdso: Test __SIZEOF_LONG__ instead of ULONG_MAX To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Kees Cook , Eric Biederman , Shuah Khan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Andy Lutomirski , Thomas Gleixner , Willy Tarreau , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Cc: "Jason A. Donenfeld" , Christophe Leroy , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev References: <20250226-parse_vdso-nolibc-v2-0-28e14e031ed8@linutronix.de> <20250226-parse_vdso-nolibc-v2-13-28e14e031ed8@linutronix.de> Content-Language: en-US From: Vincenzo Frascino In-Reply-To: <20250226-parse_vdso-nolibc-v2-13-28e14e031ed8@linutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: CD603A001E X-Stat-Signature: 77kwkpjh5xpcpr1uksp5tusftty1nmz9 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1740745775-253483 X-HE-Meta: U2FsdGVkX18uh2Y9Qw7tT660YVsxk34xze/9cdZpT+wlHKK9zyLkv/jNZh1LWGtOwt75qLftSsKaXWQWlYCURNRx0ik5m/TCYFEMoC39vQM/VlKCyayIJoVaOvfKpTQYd6nXyQ+flhy/6CDmvaukY62ErFk7VpXyCdW2xhjXi8+hrv6OWrU0Gl1vfjp/xiGvRoNiafq7+n9J2GSXGArCg8PkkDn5lOjzJ/+QqqSfiDtt4CY/B3EwLbwG3Mu1pcJnRWqd7hXc4eTsWArmb3snSP5MQsxvOqvLR0MgVIYDhm64+pfsz/bdisFBytECKugJrLCSx7g3/bS2MrNomaE7rC1kH9ijT+LxXnrglpjURnlXgZnUgvsEYgkEZedOmMvzc6r6pfiA8xXwTMt3PSHqYVQHUx6eg0hGaNoHuBd/rI8xm28ry23m1Kvw9OZWIajquYHbCA3REetTngEmv3IdPGzvdOT0eEtc23rqA8iuxgBfcscu9l4rMxs+kQcpmwnDEvA23nlDAYue6d4GAHYIEM7lzl2y9sVCv7usnVxqhvi4o2K7lvLCZcV+RvHiHQXqEk6FpatrZz5lvk3uX4XlwvBRvPms2A1q7bQCsW1Wk56+irgsxTidzY4dPsoC9lDvTeZg8pKjbDJvC37Q6VoU7c76vkY8IYs+3/zdo8QN/ar7rf509oRe1jRZC3PL9GP/SsccZw1TelfDvpJz0wQVDyAKiO3hWiGdA5e76u7vZXStnGHEijj/mkb7YyaM1YS1iefcEx98wo8r3lP4iPd0PsSHFLySo38XG+VK/942YnlOCbkAjxCEPK4FaUWHIB05Qz1UnR22c6raWp99l2ARdEyA3cQ5KQc0Cdaj0mgXcNK3B/jJOOSNzv3iNLRw8pA69aFI6uPHkvaI4FgRd2M+Xm8aw5RnwrdNDUDVHVtx9hjjLt4THzckqmLSVV1yzvrH+O3ovSSVVmXMcvgLsGl SEY0Aq1X 8XAeIGCPi+WEHUvDoncFnxEjHtX4C9WEy3AevcMxTeMNCHMQ68JvJlGNaXaBKina/COEBPI4XrxFfqRx3fXhUN0QaiprajdPIUzewv71Brby+2S3S9WubOZl+dO5aXKCnemPmYWSJC9z4Qm/rTOjENWFsJcfPLvo4jZneYdcdVxvwsk2MGj4SdaLfASCOZMOYQranC0pEvsWGEO1TqZznuVGxfStcYHuMw8/k524vBhHgp6NetaZB6DupgnnLaooAapwMglWeEn8NxLB6qrlwsyRyoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26/02/2025 11:44, Thomas Weißschuh wrote: > According to limits.h(2) ULONG_MAX is only guaranteed to expand to an > expression, not a symbolic constant which can be evaluated by the > preprocessor. > Specifically the definition of ULONG_MAX from nolibc can no be evaluated > by the preprocessor. To provide compatibility with nolibc, check with > __SIZEOF_LONG__ instead, with is provided directly by the preprocessor > and therefore always a symbolic constant. > > Signed-off-by: Thomas Weißschuh Reviewed-by: Vincenzo Frascino > --- > tools/testing/selftests/vDSO/parse_vdso.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/vDSO/parse_vdso.c b/tools/testing/selftests/vDSO/parse_vdso.c > index 200c534cc70e2c2381fce3be5c0ebe4cb5675e84..902b8f9984a1f70049d46bcd4f199df24f507dcb 100644 > --- a/tools/testing/selftests/vDSO/parse_vdso.c > +++ b/tools/testing/selftests/vDSO/parse_vdso.c > @@ -26,7 +26,7 @@ > > /* And here's the code. */ > #ifndef ELF_BITS > -# if ULONG_MAX > 0xffffffffUL > +# if __SIZEOF_LONG__ >= 8 > # define ELF_BITS 64 > # else > # define ELF_BITS 32 > -- Regards, Vincenzo