From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17492CEF148 for ; Tue, 8 Oct 2024 09:48:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 705026B0092; Tue, 8 Oct 2024 05:48:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B3EF6B0093; Tue, 8 Oct 2024 05:48:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5543D6B0095; Tue, 8 Oct 2024 05:48:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 32B846B0092 for ; Tue, 8 Oct 2024 05:48:50 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DAD4B141A9C for ; Tue, 8 Oct 2024 09:48:48 +0000 (UTC) X-FDA: 82649960778.25.F2F435C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id 371A9140020 for ; Tue, 8 Oct 2024 09:48:46 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HHNkTdjP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=P1XcT7cO; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HHNkTdjP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=P1XcT7cO; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728380793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F9O5rWJa7TOBcNlcqYWuRNrE8PjVlGXuVyvIHmw0T9Y=; b=mxfs1DG6dHqUfLDTvcx7diH5yXIAfFWPp/yavTNJBtcMa28A9STBZUGmn2gpozNW/pzCaz yQF6ESJZJZ6QySRAB7Qod1m6IqNrfFOZ/UskqcjYgmRgwuG7xBv/9cx3FZophLGtOfejsE NdItUmB+XcNZSd9QgrK9d/BaIsIudRU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728380793; a=rsa-sha256; cv=none; b=5ukWt9f9wlHj+TqtqdrjM1Txk2JB07sHO7ROeCm5pEomZBih0XeUoGuD2BOK/q66Cnf/tE K1gZ938ynbBLsrlje/I5dHYrpb3IHIjU4iC172BgmBIEgtbqaVgJdkqeSBbPFuKf7ovb6o 5QRh2LwsYKdNDqBOqx8R7VzPoylIMfM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HHNkTdjP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=P1XcT7cO; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HHNkTdjP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=P1XcT7cO; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4AF4F21CD7; Tue, 8 Oct 2024 09:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728380925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=F9O5rWJa7TOBcNlcqYWuRNrE8PjVlGXuVyvIHmw0T9Y=; b=HHNkTdjP20e4jspGpT7oRIPVLIf+C2bF3yaUuRlsz72PlZTghZ8dNVAoaI4KPVwhF5f1p5 DWseHQoSMhOxpfUwFDZ1SUA5fW53YmVJ56OlqgpALp5SKmDEtbKFh/ecBn9QqNg4s/Y8Lj LMfozwaTKx6DursV8DxOCT5CK9kgvxM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728380925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=F9O5rWJa7TOBcNlcqYWuRNrE8PjVlGXuVyvIHmw0T9Y=; b=P1XcT7cOVWA/tDcJssI9FMQ0/Y+eAxprCIksc7dXmrGm76emlobXZvpOa5in/pIUUypnXe R3cWO//cZ778kBAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728380925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=F9O5rWJa7TOBcNlcqYWuRNrE8PjVlGXuVyvIHmw0T9Y=; b=HHNkTdjP20e4jspGpT7oRIPVLIf+C2bF3yaUuRlsz72PlZTghZ8dNVAoaI4KPVwhF5f1p5 DWseHQoSMhOxpfUwFDZ1SUA5fW53YmVJ56OlqgpALp5SKmDEtbKFh/ecBn9QqNg4s/Y8Lj LMfozwaTKx6DursV8DxOCT5CK9kgvxM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728380925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=F9O5rWJa7TOBcNlcqYWuRNrE8PjVlGXuVyvIHmw0T9Y=; b=P1XcT7cOVWA/tDcJssI9FMQ0/Y+eAxprCIksc7dXmrGm76emlobXZvpOa5in/pIUUypnXe R3cWO//cZ778kBAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2D3E71340C; Tue, 8 Oct 2024 09:48:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HLypCv3/BGeGPgAAD6G6ig (envelope-from ); Tue, 08 Oct 2024 09:48:45 +0000 Message-ID: <9f856fe8-8bd4-4e2e-a5a5-21bed20241ed@suse.cz> Date: Tue, 8 Oct 2024 11:48:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] SLUB: Add support for per object memory policies Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, cl@gentwo.org Cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Yang Shi , Christoph Lameter , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Huang Shijie References: <20241001-strict_numa-v3-1-ee31405056ee@gentwo.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 371A9140020 X-Stat-Signature: mnpb7yt3hydx5q1i3ki7qo5k9om81idu X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728380926-676725 X-HE-Meta: U2FsdGVkX1/ajv3et0Hj1159ywsVDl1bCw9dp8BJIjlm/5lzSJe9lUfGi/TzIrHt5tLlpKIvjXjtLHlNjENF3ijhN3yaMlp/Yp6IADkSYP4zrazVTJgszVSj8Wzf1IO8rvIEkVTHjIq62NIzbLvW2Cmm0R3fe1p9Mx/dKNpaSR8Lwxq0PzBi/SuPi9G0aIEwCyQ1wX6MtsDIhFF/JW3qYzDv/swZ20ClI6cJQYFpvhRWirEeQsmeWqCC7MIDylUf3fzxne/I2RcS5bpzGSgHE8oII+J5qHiJ+6dX9wsV0pjVjshA2G9Bi7lHD4Xg/+YCvl3Gt4yOikl86W8lRAysUZF6/eEAZe7m3WAdJ5F5Xm2qr+SsOIcZA04LnvhZjTPcYapyWoeoEPsPtKpbf0dSObG5qUnDrzDHNIxDTJIG9Ehw3q2/CN8nyGhuAGm1TfLwXbSt3VCsY7I+PVQpqfqQmtjKcvHqibyfQk/sJzaJaMC5q2cq1bS12BN0WoVqXWtivRle5UMcGOLA5ILxY4g4wwH2eva/mOogMTeoc0qhGFz6fRUKZoo0HfViLWD1nfk844qn9UDz7P+3WMkJODscmY7uTzDRZX49PBgkTo/7bE5tnbebeH2oa9oduns85eORZP67I3rGoP7Q2GzifUHuqYl/OVTfb8MR8CvNopkcrWpkHLg7p53QUOjTbieDAPEQQHu+IOhXWvoVLe20FppJrgdUJ6ysNhWvXRAgZvU5XXUHnRD+3da082XTy5omyx1MiDV8fmoyYZH1dEtZG05GsielzxJjPl8KdEark2800rztSGsd2vijUEpwJfxpA8uacwXtBEqrXpRbwOwcN80adsSwncmID39TZZJEySSoy1MHsOEZ4Az5XlGSDpmdlFC9vdidRRq1WZUXW2VD8qhx/ZXkYVZ75YZktdbecHmcC68V/hFbL9wm5gEzH6reAC7CNujUGST/CZLgZAGKXRM yI91sEbW 1Sn5JX//YvM7CuzCzGl3WcoegeyqQY3JGsZX+LyXKwIjBrgK4GbY7hc3GOjf4AkeG7vNLCn4eZlsZOe2HJNJ+fBGTqkD7uAOyq7be2PH1i79ZYYkuM49IB+5XaKuBgTeyfXT5FoNGjkA/Bl0yM1DZcuxKs+hyBzmdT/jUTdCHTt2Bd8SArX8wuDymWiAAtSHRvzRH9A9ElHP1alU6bAtVWvJN71L29NmHDcr7jr5iJjhwCwKx8bx9MHV6XZDdi9SkuHjV1AWIALAnc/pK6mgr0TS3t40NhE33Iwiboe5v5en8pbu97yHdYxJj9PuPu5mbNSQaJV3/Lge2cO/mVyANn/a+S0Sg/8wyL53FPaMsCkIDYXI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/6/24 16:37, Hyeonggon Yoo wrote: >> + >> if (!USE_LOCKLESS_FAST_PATH() || >> unlikely(!object || !slab || !node_match(slab, node))) { >> object = __slab_alloc(s, gfpflags, node, addr, c, orig_size); >> @@ -5601,6 +5627,22 @@ static int __init setup_slub_min_objects(char *str) >> __setup("slab_min_objects=", setup_slub_min_objects); >> __setup_param("slub_min_objects=", slub_min_objects, setup_slub_min_objects, 0); >> >> +#ifdef CONFIG_NUMA >> +static int __init setup_slab_strict_numa(char *str) >> +{ >> + if (nr_node_ids > 1) { >> + static_branch_enable(&strict_numa); >> + pr_info("SLUB: Strict NUMA enabled.\n"); >> + } else >> + pr_warn("slab_strict_numa parameter set on non NUMA system.\n"); > > nit: this statement should be enclosed within braces per coding style guideline. > Otherwise everything looks good to me (including the document amended). Right, amended locally, thanks. > Best, > Hyeonggon