From: Vlastimil Babka <vbabka@suse.cz>
To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, cl@gentwo.org
Cc: Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Yang Shi <shy828301@gmail.com>, Christoph Lameter <cl@linux.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Huang Shijie <shijie@os.amperecomputing.com>
Subject: Re: [PATCH v3] SLUB: Add support for per object memory policies
Date: Tue, 8 Oct 2024 11:48:44 +0200 [thread overview]
Message-ID: <9f856fe8-8bd4-4e2e-a5a5-21bed20241ed@suse.cz> (raw)
In-Reply-To: <CAB=+i9T8cOLQt4YprvUghwWZx1nOaiQ-0vV1N1zOOHWAFXza0Q@mail.gmail.com>
On 10/6/24 16:37, Hyeonggon Yoo wrote:
>> +
>> if (!USE_LOCKLESS_FAST_PATH() ||
>> unlikely(!object || !slab || !node_match(slab, node))) {
>> object = __slab_alloc(s, gfpflags, node, addr, c, orig_size);
>> @@ -5601,6 +5627,22 @@ static int __init setup_slub_min_objects(char *str)
>> __setup("slab_min_objects=", setup_slub_min_objects);
>> __setup_param("slub_min_objects=", slub_min_objects, setup_slub_min_objects, 0);
>>
>> +#ifdef CONFIG_NUMA
>> +static int __init setup_slab_strict_numa(char *str)
>> +{
>> + if (nr_node_ids > 1) {
>> + static_branch_enable(&strict_numa);
>> + pr_info("SLUB: Strict NUMA enabled.\n");
>> + } else
>> + pr_warn("slab_strict_numa parameter set on non NUMA system.\n");
>
> nit: this statement should be enclosed within braces per coding style guideline.
> Otherwise everything looks good to me (including the document amended).
Right, amended locally, thanks.
> Best,
> Hyeonggon
prev parent reply other threads:[~2024-10-08 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 19:08 Christoph Lameter via B4 Relay
2024-10-02 10:32 ` Vlastimil Babka
2024-10-02 17:52 ` Christoph Lameter (Ampere)
2024-10-03 9:51 ` Vlastimil Babka
2024-10-06 14:37 ` Hyeonggon Yoo
2024-10-07 16:19 ` Christoph Lameter (Ampere)
2024-10-08 9:48 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f856fe8-8bd4-4e2e-a5a5-21bed20241ed@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=shijie@os.amperecomputing.com \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox