From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D93CC4332F for ; Mon, 13 Nov 2023 19:16:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2747A6B028A; Mon, 13 Nov 2023 14:16:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2243C6B028E; Mon, 13 Nov 2023 14:16:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0ED656B0290; Mon, 13 Nov 2023 14:16:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 008B26B028A for ; Mon, 13 Nov 2023 14:16:57 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D3BEBB58B3 for ; Mon, 13 Nov 2023 19:16:57 +0000 (UTC) X-FDA: 81453888474.12.ED3CF01 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 566A7C000A for ; Mon, 13 Nov 2023 19:16:55 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RYdtCNUB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699903015; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QI+OFjhz2/q8YuzQGF/7kt5ZmFWZ0Ih26v8XHGpxDAg=; b=3sNnkQkzBmcbTNR2M9DRmtosH3OQDXs70pQxmEAL5NTe1h3HMIJ73Z4wQ9oyiFfqAhpquC kEtffmVUZUCpw+x2h0QELWVmnMurlq5sVY+YzXLPCaXx8ISOPcbVrDzzUz83rhE9qPEEIS msxeDMAlHnz0OQPpe9foPp+x8KLeokk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RYdtCNUB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699903015; a=rsa-sha256; cv=none; b=GFcYUBIU+v+XnA48NJjzAvuzNJCY/vuqrvkNl7k/0rUptfjsqyHuGZ1NKhvx/sLs9RH9Yi crYj/BdiHf06eny0b2TO8sPR2INQuLp/egoUGS1AtPQVyOseRGbEW0SL96bFY0R9Qd2lvM r2ijFzdbIlh9F7aFuJiJQe2DuzPCYN8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699903014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QI+OFjhz2/q8YuzQGF/7kt5ZmFWZ0Ih26v8XHGpxDAg=; b=RYdtCNUBBQ3TgMQ3iUx6g3FXGr2tJqwaRnQ51LvEZOQnGbTzIXux4OUlzkXr2iTtmRW5Nu sx0yXrfKRTOl8VYZTEYzWxUtwt2x0E4aW+8iI8LwIPhCL295Iyb6mthDneVouhyBiAdkz/ hJavRiNhrescodYhqS/jQK/9+toRlnU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-118-ro4AQkz_PUC5TwQbIfAXzQ-1; Mon, 13 Nov 2023 14:16:53 -0500 X-MC-Unique: ro4AQkz_PUC5TwQbIfAXzQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40a48806258so20197865e9.3 for ; Mon, 13 Nov 2023 11:16:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699903012; x=1700507812; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QI+OFjhz2/q8YuzQGF/7kt5ZmFWZ0Ih26v8XHGpxDAg=; b=fXE1q/FAymSqVyGFBc+gWQ+3ASXL3WHla23VxSupDFp4ihohKq/FKbiAbTh7+drosb XHyOr6eDc18OA39bi9plE2Uw5hWm6QQrvEw/7T8wxY12y83V5mQioH4LLeqLhg0wwbds qTySsg/tjbnRHBFI57IP2RTKAEehiC35NLqqpIuoRuALD5ddjsH9tmnbVD4CaU2Q/uf0 2I7ZJTM26wJOUAEoS8J5TTSftG8dMJP90oHfzJwT/CU6qxpCbaKIOL1MQwDFLruNgf6C JNYZrVuRR59BoPW1tfdlP6Z0s5t2X2Vno0L/0+HTK5p9bPZx7tkPw7B+xls+nY3l83Gu dosw== X-Gm-Message-State: AOJu0YzbD/xAoUQLPcPvyCCG17mPAVGUpfxRw3URHGmJnwTt6giUGFB7 NJwn6PTgv/Nz23W0RA6oZGe8kpkIrpNzSHOZVwsyTkKvuUCpqdKurR0LKEb7XjbMZyZTnxIQkcA a0e0WmtyedR8= X-Received: by 2002:a5d:5847:0:b0:32f:7d5a:87ab with SMTP id i7-20020a5d5847000000b0032f7d5a87abmr6576514wrf.53.1699903012060; Mon, 13 Nov 2023 11:16:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IHePviOiZUmhfcxNssCAgAnAuSKXuz27fg99dUJ3dKUcuVnbQ/fIU7ew3IR4gby02/E8lMFlQ== X-Received: by 2002:a5d:5847:0:b0:32f:7d5a:87ab with SMTP id i7-20020a5d5847000000b0032f7d5a87abmr6576498wrf.53.1699903011617; Mon, 13 Nov 2023 11:16:51 -0800 (PST) Received: from ?IPV6:2003:cb:c73a:400:892e:7ff0:87:a52c? (p200300cbc73a0400892e7ff00087a52c.dip0.t-ipconnect.de. [2003:cb:c73a:400:892e:7ff0:87:a52c]) by smtp.gmail.com with ESMTPSA id w12-20020a5d544c000000b0031aef72a021sm6020406wrv.86.2023.11.13.11.16.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 11:16:51 -0800 (PST) Message-ID: <9f83d97e-b7a1-4142-8316-088b3854c30d@redhat.com> Date: Mon, 13 Nov 2023 20:16:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 0/2] Introduce a way to expose the interpreted file with binfmt_misc To: "Eric W. Biederman" , "Guilherme G. Piccoli" Cc: Kees Cook , sonicadvance1@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, kernel-dev@igalia.com, kernel@gpiccoli.net, oleg@redhat.com, yzaikin@google.com, mcgrof@kernel.org, akpm@linux-foundation.org, brauner@kernel.org, viro@zeniv.linux.org.uk, willy@infradead.org, dave@stgolabs.net, joshua@froggi.es References: <20230907204256.3700336-1-gpiccoli@igalia.com> <202310091034.4F58841@keescook> <8dc5069f-5642-cc5b-60e0-0ed3789c780b@igalia.com> <871qctwlpx.fsf@email.froward.int.ebiederm.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <871qctwlpx.fsf@email.froward.int.ebiederm.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 566A7C000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: cb1o5d11asbe31yhoirnjeu79itwcxye X-HE-Tag: 1699903015-11124 X-HE-Meta: U2FsdGVkX1+N4mfE41ZMYzHfVM7WXAYeOCgfocyFgACn7zL+1kxd7ek1tu7oDBZs3XeIQc6yO6Aprr5c7QFLta8Wla2TxH8Zw2YvAJPtd83hSIRVdr6VoVLkwXGl6YifF+Afrn6wjpPBf44CDDUGqQyMB8wAWcIMODpMbRynnd7CxPMm1FDCtaJige6GJ0hfb85TRf4KzjHNXgIj07tSi8lBY1yEFAUqIimOU85GUhPFD6Cam4xlVIXju+X2yNDeZa4KnXmD5uUBWSganfQDjM2Qsb80r0py9gIQKdXuAE8NBkFafEQdV5v+opFB1Rapx2GgFzhb1E/1T+kTkxjkNA28gyFDElitk2F2JfONSOUPb3RISET/jZJP6xw6omg+e9wKD1T6M2+TOLW1RMJHEg2pwCXyZtxvL5p65wzpRLnG3r1Zu/AVJwRCZ9zTzc+mPUkcSYLZFwORkorZYf478JXAhSKQndknDVqNLrt+isNRlhVCdeCY5Q8nL+qZfmeY+f+IyP4rcRPx4oHmEuFxkHRwgV/AiKn0LV1mmzBKXfJh94kd6eUOFl1ryX9A24fPMgolXkedmsXLT3gWjxNCsXLBAf+gOFk7hXfe71WXRlw/DsyvLUXH1R/vd5R7UwyO3GHREVui+BrIG8XTqriAOg2/swngoMSZyX4K9U2rjSPEb1arQAYJpw4f939wxBvz3METDLn5Wk3l/tvcsi1y9EsF/bjdf3drV1yNCOSzPa0TK7qAMdrgClBxNr8KxG8vRoZk1Lt1+P5v5LiL7lL60o+VspAzHcxgX7bhwjmMNS5KEEplta4TgUwZ+1t+IRl5A9eR1A1aAntj4rfTqc8KS5dbUapXIJZIT09LPd/a3hTtM0WqTi2YG5XmYEC9ud5JUCaja8qssoCUQ6KLhckNSlhNk1bOB6cwa5dC41eLSl6fjdu4ZaXKSqxUxeSLdp9LlBI/+DdBHRR2ugn/UQm hkoMfwmQ 5m+ZCK9V+/xrUMAD8c902ajQ+x9J7wZPdyq4FIKexcJ71ZO3ks9P9sILZuYo/TIKyNTIrgs+d0TiRU/8uQgJA9hWFpLQALla+rI1vcZaMRnMO22ppDVpCtQRaXJVSZpBb0+Ro3gRUPIgs9TRvB85KpXgV5RHg+//SmyrT06UQSKZyjeZKFvSagHaqUyHpDnEBNA1oBDBraOZjx3NKJE/n89qEdY5Em0y6Y5IjUE/uJ+/Y3HHAZIcu3pu83fIFf3pqBVmRBGJqmjRGTbwOQgYxusih4g1yI8mgrJlstMux7zRMA+G8aHey9H+ooT5zkxZXfUw60OAfII0bf+vgppbME5jBgR3L8NsU1wXDajpIlVPI1/Mn7A89IvCsLY3fccQxWNjjPq9lxZPH2syzvgwjVSOQInyej09lxAlQnLwYqGPa62MKYAvt050qKXrcKc8ik+m6PkSE9A3WfqkR4ZIfPXsagR6pAVi0rCDZyDLGrZmqPClFACQdLg55Ek3Q1TkQRZCvJLx1nLSFEsx3Fg+EITJfJjuUVBirbcORg1pGWJKL4Fu01joUtQliusP3j2H8f33gBLocH2smrtEFxZO7mag/7g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.11.23 19:29, Eric W. Biederman wrote: > "Guilherme G. Piccoli" writes: > >> On 09/10/2023 14:37, Kees Cook wrote: >>> On Fri, Oct 06, 2023 at 02:07:16PM +0200, David Hildenbrand wrote: >>>> On 07.09.23 22:24, Guilherme G. Piccoli wrote: >>>>> Currently the kernel provides a symlink to the executable binary, in the >>>>> form of procfs file exe_file (/proc/self/exe_file for example). But what >>>>> happens in interpreted scenarios (like binfmt_misc) is that such link >>>>> always points to the *interpreter*. For cases of Linux binary emulators, >>>>> like FEX [0] for example, it's then necessary to somehow mask that and >>>>> emulate the true binary path. >>>> >>>> I'm absolutely no expert on that, but I'm wondering if, instead of modifying >>>> exe_file and adding an interpreter file, you'd want to leave exe_file alone >>>> and instead provide an easier way to obtain the interpreted file. >>>> >>>> Can you maybe describe why modifying exe_file is desired (about which >>>> consumers are we worrying? ) and what exactly FEX does to handle that (how >>>> does it mask that?). >>>> >>>> So a bit more background on the challenges without this change would be >>>> appreciated. >>> >>> Yeah, it sounds like you're dealing with a process that examines >>> /proc/self/exe_file for itself only to find the binfmt_misc interpreter >>> when it was run via binfmt_misc? >>> >>> What actually breaks? Or rather, why does the process to examine >>> exe_file? I'm just trying to see if there are other solutions here that >>> would avoid creating an ambiguous interface... >>> >> >> Thanks Kees and David! Did Ryan's thorough comment addressed your >> questions? Do you have any take on the TODOs? >> >> I can maybe rebase against 6.7-rc1 and resubmit , if that makes sense! >> But would be better having the TODOs addressed, I guess. > > Currently there is a mechanism in the kernel for changing > /proc/self/exe. Would that be reasonable to use in this case? > > It came from the checkpoint/restart work, but given that it is already > implemented it seems like the path of least resistance to get your > binfmt_misc that wants to look like binfmt_elf to use that mechanism. I had that in mind as well, but prctl_set_mm_exe_file()->replace_mm_exe_file() fails if the executable is still mmaped (due to denywrite handling); that should be the case for the emulator I strongly assume. -- Cheers, David / dhildenb