From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8D8BC0218F for ; Sun, 2 Feb 2025 13:44:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 029FC280002; Sun, 2 Feb 2025 08:44:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F1C8F6B0098; Sun, 2 Feb 2025 08:44:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE36C280002; Sun, 2 Feb 2025 08:44:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C266F6B0096 for ; Sun, 2 Feb 2025 08:44:16 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 54758B3DB8 for ; Sun, 2 Feb 2025 13:44:16 +0000 (UTC) X-FDA: 83075123712.29.F62E58B Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf07.hostedemail.com (Postfix) with ESMTP id 58CC04000E for ; Sun, 2 Feb 2025 13:44:14 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="htg/r7JT"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of honggyu.km@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=honggyu.km@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738503854; a=rsa-sha256; cv=none; b=j7DiI+WADFcSW1KI/9rmuqeRiO9rYOIsRi/d9wg3oMznn8I/w76JhEP4fOV563KfH8L+50 WdMuljp9Pma4wOzsZrJ63nObAL+4iSpS5C8ph40H3ucXBpk+zaKZ18LOqN9wpIZfiWXbUc qfLwiHPqhiXg+ZzWT/6lpfitr9jK+Xc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="htg/r7JT"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of honggyu.km@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=honggyu.km@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738503854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yzayRBbvjFKjGTEED8m/pZVSLWexcRis3+D6NjBXPsQ=; b=F9KWysOpJfcS/rfm3tHuCszJtTUH6JIv3muuelLJIGBNxCk47S3cmNmxhzJvtg6zO0FArR TiOKondZDURp8uau3CyhGraVOvKunkVyzeEJrjnFMkhsI/DWTo5EsDvKeAHydej05cV1I1 349YYw7NONojSIACxgfDdSAl2pBJSe8= Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2efb17478adso5884005a91.1 for ; Sun, 02 Feb 2025 05:44:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738503853; x=1739108653; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yzayRBbvjFKjGTEED8m/pZVSLWexcRis3+D6NjBXPsQ=; b=htg/r7JTdAqElve+fuh2Mjwn10hwmQWCyc6hdH3aZB+U1jVv5vZTDskSRboZj5zicR /p8i3lpMbAgGXtTOFKiEcchd800hE9Szw62zweRpDS7+1yoz4Tt6DCxJyaiE9fpNLxhq wdcHrdDk5EM/BaN24SKuUYFpu1GkAJO2X6hdmoz/4CckmGj8KshssQNfPnL2CVvX1jR0 ISrQ4pCAyB8va0V30KtutI1xtE7ZtoMKM37VxmMyek08YP/tuuLqXFk85xUYhOLpHR5H CH7kyQQWGfdPYAQ0XVca9lvhABE+RSWkOiwAgCZ9Ao3/fJunkYxoM5Y2Lp3Ey3dAXf9H XpYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738503853; x=1739108653; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yzayRBbvjFKjGTEED8m/pZVSLWexcRis3+D6NjBXPsQ=; b=DiSNxU/1d/GnKmXyc6CyQVF9DZH0IbjX0GPyobr1M4HlRNCeyWJMXI0Z7cC64l92ey NYvp0VeajuCmWWLapgVjibKF8hKl+XdfyBX+zyqtEH9jo8qzIxvh1c8wEUKLHnXvCsKc EBtTZ66VVhUWSqxMKH3JLnZxtN5WPJYFSY8kXBbRu+ODR0OIRJBFg8dJwMzNPVwxp5fC rcQL/dA5kQdjEQr1RuYIdaE3QZ5kpXqL4u3OijvfSMeBud0uSXlSL+sm03+0cziH7DQC C/WfQt2GhYGtdnVLWy9T3jKdMqJwM9PEeLlPFTNWAuSh4OmSHQVOn7W+wbRv0n96f4aK WeoA== X-Forwarded-Encrypted: i=1; AJvYcCV1mUOjsp3JBexDtrqC+pRbJMLEl9VXsOUgsutjY/ERrvCDbquVv9qBrrY5tv+DEPZqfMfHMIjP/Q==@kvack.org X-Gm-Message-State: AOJu0YzPLyLo71WfIgaUd972hVaSYU3G9b1CF/GtkZjUE/a1Y1YMmF0S uAFMJGlcR5TrssSu5etbtrpwWBLXIbuMDT/kx69JFjZ2xodWc+H8 X-Gm-Gg: ASbGnctfPuMM+ZJj6cDl5RNinFZPumjuHS++vXkj+JUq+lT5HW1yoRrBRfxx+wZrcjn oDuaW+Vl1E1R2cYaUqr0ok8nCnC7KcB8r6SGBg6npzfzWEnIwI/SyiPRrIhDHwpS78G5awWryL/ RbrjtCG3pXubUWgKuLgisnZjUzx8Eh3M42zqILCYgbE0R8eRaGkNw/KHNxmoVuWofOjp/Y2drC/ eF1/0F4pmP9yYx3Jec0jjPu5b7X2tCW7IL1M0TW3bV+6plzvPk902I7WrKb5PyE4eFLwzpOtMTS vNifuikq+NCG5A/CA+gHt+kr X-Google-Smtp-Source: AGHT+IE2Fly974HNmPVReSPAvNlmMHkie4rvpmMfKb2bISi08MYI+k2dSZHMQcF2g9Ibx4ZnE2KLiQ== X-Received: by 2002:a17:90a:d610:b0:2ee:b26c:10a0 with SMTP id 98e67ed59e1d1-2f83ac5c2a8mr28211494a91.24.1738503852901; Sun, 02 Feb 2025 05:44:12 -0800 (PST) Received: from [192.168.75.213] ([116.121.188.179]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21de32eb43asm58792795ad.156.2025.02.02.05.44.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Feb 2025 05:44:12 -0800 (PST) Message-ID: <9f56bec0-b35b-4ea2-a212-5c50333c00f9@gmail.com> Date: Sun, 2 Feb 2025 22:44:05 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] Weighted Interleave Auto-tuning To: Gregory Price Cc: Joshua Hahn , ying.huang@linux.alibaba.com, rafael@kernel.org, lenb@kernel.org, gregkh@linuxfoundation.org, akpm@linux-foundation.org, honggyu.kim@sk.com, rakie.kim@sk.com, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com, kernel_team@skhynix.com, 42.hyeyoo@gmail.com References: <20250128222332.3835931-1-joshua.hahnjy@gmail.com> <41ab5a11-f8d3-403c-9d68-33eb15aef8fa@gmail.com> Content-Language: en-US From: Honggyu Kim In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 58CC04000E X-Stat-Signature: zhggpfwozpt1n39uwonfqa4aijgkfagj X-Rspam-User: X-HE-Tag: 1738503854-591904 X-HE-Meta: U2FsdGVkX18wafg9onO0/4qTRNUqoN9OFcCA7tyWgolYV0W6/wAIO7DDmgLtuZheixPicZ1oJjD4L6e1Y+QGvdwA9Y3MTYxsU+f/956XPA0hxFd7p+kNB8XoJSBCsX8eu/Yt74E3crijiVvUgFA0HSCL/c5MkfIjevt1BLTicIUsZp30Fi0EW6EO9mJD84fHOfHLPa7tVrlMcL0dCoz63lYfv/MMjdGkfONzwWz7KTavuKptwvos6P96KAdmwkCCbkjkPl8PDyYWD3qrQ3i0Fv9SKScjHcrmpj7LHdfGgSwxWcubUxaZZDetp/I0dgWwtBeldrGkPhFy9cNyeRP/Di46oseQr/GxqOB+9A2a/fD3bKEsJWQLBYVQy/NSDYuHNETCKtP5lP5EPZ2vnUqEghD/+iBrSrqDiLsTtuTRlwFXzk9W+l6WChfEAZ5LJSXhLqw8+PVHhJ8ibugjaTZo/LRpV/CkAs6TguUu14LYBLiqE/zK7soYseyNrzL1ujMGajIQAcbaP3CRlKRe8KfGIAvKw5BstJbO6DAECv1rf+ltV+la8krcoZJhDgj4ZdbcbT6nR+OVS7uK6nwf3S46xs+oerEOUwdvmlnAiO6SJZob6OeKrIVOzFRS6NKWKxnM8v/y6dE7eKfWNcu0DinoGDwPaWrGcg2BSq8JpLK1JRbGxxO7KtvNsuzzNW/ARp86jCEAmsTjX7KuHdBZMA7Rj2I3emwUk55Si/EqvredN58ekP61jOs762q+bovsVouo0MpgPu0HaLvyZDwRP3yEonbia9ufVRPUSmgkcGsWUU27jQgSy6AL2AT8/L0U6TPToes+deiLrQ8a2PaUxLF85kS+tZWBCA50Kh32weMC6KG45K4gmGMX3DSZ6pfanbtyAlm+QRMlMm32MW8+WSrY/SU2cSFv1qnTlsyXg68Ula1sAOI8onTQX40HVN/VxmcdJ5I3txHEcpEvSdpWuq5 qWCHWGCB TALWaiwKcPNCBakijdFMjBb7QC7Awu8zBL0H8GEcWTi8ip7ZR9RIhL2ynaJMFD5Kgt+dBCd7B65nM7030bPme1gV6hJzY8+RdoaJ7b5+H5dPNOZqrB2K/+sLGdDYx7V4sH0Tx6Fmaj8cyN3CPV8/CrswZ6hoVnd7v0mfWZnzCH2laGBYcaqKUAKTbR8qgqm9EQf/4gd55ZofdqdiVf9vGl4Fqv5yAT7V7U7+ViPx9CyNz9d04PfpgSSmI1X1EnkTNzBih019XU0+Zz9ORwahvnpzCy3yxrZS5c6j5mVMz9dh7ssrsq/y1qle4nCvbS7HZep9ZDWqYgJ2HNjhA2AIbibgFSN9ROlBbrszDG4ydfoI/nn4fqK00tKtRXozwvYSXdZ4fHr96siQsHczQPDzcOzo8MWGx/eVhntNJWA33wc1txXqfxBll38pvEnAFwYJibn0/cKfn016KXXcf2WO9SoIH9rM7WDnutemSfmJ90NMGL7ZFJp9FoD7WJuBkzswRIKGU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Gregory, On 2/2/25 01:49, Gregory Price wrote: > Hi Honggyu, > > On Fri, Jan 31, 2025 at 11:23:34PM +0900, Honggyu Kim wrote: >> Sorry for jumping into this discussion a bit late, but IMHO, setting a >> newly onlined node's weight to 1 can possibly make the entire weight >> ratio unbalanced. >> > > This is only the default for either: > a) Manual Mode > b) Auto Mode - when HMAT/CDAT data is missing > > In manual mode, the node weight in /sys/kernel/.../nodeN is present > regardless of the online/offline state of the node - so it can be > set prior to that node being hotplugged. Since it's in manual mode, > it's expected the administrator knows when things are coming online > and offline, and they have a clear chance to change weights such that > a 1 is never perceived. This may be true, but system admins can hot-plug some nodes without considering about weighted interleaving. If weighted interleave is not their major use cases, then they may not consider weight values seriously, but some workloads might use some weighted interleave APIs that use all nodes available. This might be my imaginary scenario so if you think it's not realistic, then you can just ignore. Thanks, Honggyu > > In auto mode, the node goes "online" after HMAT/CDAT data is reported > so users will generally not perceive this default weight. > >> 1. the auto mode set the weights as 10:5:1 for node{0-2}. >> 2. node2 is offlined, then recalculation makes it as 2:1 for node{0,1}. >> 3. the auto sysfs interface is set to 0 to make it manual mode. > > If the user sets manual mode, they get manual mode. If they don't > want to manually adjust weights, don't set manual mode. > > We can't stop users from doing silly things > > ~Gregory