From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68DDDEB64D9 for ; Mon, 19 Jun 2023 07:56:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E264E8D0002; Mon, 19 Jun 2023 03:56:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD7D88D0001; Mon, 19 Jun 2023 03:56:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C782E8D0002; Mon, 19 Jun 2023 03:56:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BB7738D0001 for ; Mon, 19 Jun 2023 03:56:49 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9C474A04E0 for ; Mon, 19 Jun 2023 07:56:49 +0000 (UTC) X-FDA: 80918740938.18.EB95B9A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 666F4100007 for ; Mon, 19 Jun 2023 07:56:47 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DBthK7bx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687161407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/fHK6hLvkLbFWjRtnXUJu1BfimbtAFaIRjWPmhQcup8=; b=fI8cIq5TY85yjty6jXMSxcOIAlLiR4sAfjroZSrAMiT44nXRqJg5oQAgSc4szDDAw1q+pT dyHdvaBLdjgWhYFXGbK7f3TmL7jegRAH5oK2Lizq+TORArQLr8DF9WxtoLsi2rjVA9YYSS 7Nt8eCQKtxiJhLsHqKOz8wU44T0wx34= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DBthK7bx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687161407; a=rsa-sha256; cv=none; b=ru15vE3vCQkAt4Udz56q1rPYCFUpun7EZ18UMbQ6md8xi5XQJ5YQJh5ipIy2GiVidegaVp 19ToV+elJR3ICaN+bjXJ5HQL9ToH1FlVGCf8VT9nyp5/i9aLxFtZaod3wPNd8xlRuVYVe5 3v8qnK9cvntUEdodJomKq/U3aaQnjw8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687161406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/fHK6hLvkLbFWjRtnXUJu1BfimbtAFaIRjWPmhQcup8=; b=DBthK7bxvE2VWjAhbmkJ6QtSoZ2AGRXdVZfsQ/u6gAbVulkFU6CSohwQ0/H+NuAHpfforu Y0vjnSwJN02V0PeoZg+w4+l8l/iKpj+PE3Y4UHb2caJK9a0oXYoX+Dv3JckYVRddLxuZWb UFtxtQatc7oOeBoPfUfx0eWMY9qSUss= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-378-uDjh3IYFNwKkF1FYuV860Q-1; Mon, 19 Jun 2023 03:56:45 -0400 X-MC-Unique: uDjh3IYFNwKkF1FYuV860Q-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f81f4a7596so19572745e9.1 for ; Mon, 19 Jun 2023 00:56:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687161404; x=1689753404; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/fHK6hLvkLbFWjRtnXUJu1BfimbtAFaIRjWPmhQcup8=; b=hJ5E5/EEUO1BZC6dk3EoW9e4ZbVs4sRdzJm03TVJ5+U5QdMryJO91fQuePsMi7jTEN j2ZOFq4HQ6O7zeqAFhOtQulXRb081U6Lquq9agNaAq6S2f4kPSgaWEkBud+skJzzF37r ocPGyJ3olq4qxP20tAIR68MJ4YvhfN+c3/7W0djODlbSkzlXszyz7RVsaksFCgovPFN4 EAoIn8iEC3RXxlJX37gsUgLErf+2DD7TL23+QUW0zgFKNiyBnKD6QrOkzZyl5T67/ic2 Jsm0igD0yEp/Vs6wOj5NxFbl8gPwff5foY14yIgN4IeoQHy0SBJXd0m0X6jpdu7kQljf UajQ== X-Gm-Message-State: AC+VfDxqqmPDpIQmbBpSne0Fz4ue7UHsVSx8Ayt8bPHHfV2K2KtduG4F 4wb2Gn9ZfZ59moy6gd/CeXixOJx9Owlj8AhwrR7ORSz/b6s20fDV89+Xa6rJvU3FfpcyZtulri9 FgXbybrq+vnI= X-Received: by 2002:a1c:e909:0:b0:3f6:a65:6ff3 with SMTP id q9-20020a1ce909000000b003f60a656ff3mr7853495wmc.32.1687161403916; Mon, 19 Jun 2023 00:56:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5pKONDQSVPAi+bDBIMNTn8k/5gibdpHqj+h2uW3r5E0zsloGf7syvk7GOh8jAWSN+3oJoDXA== X-Received: by 2002:a1c:e909:0:b0:3f6:a65:6ff3 with SMTP id q9-20020a1ce909000000b003f60a656ff3mr7853464wmc.32.1687161403541; Mon, 19 Jun 2023 00:56:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:7100:cede:6433:a77b:41e9? (p200300cbc72f7100cede6433a77b41e9.dip0.t-ipconnect.de. [2003:cb:c72f:7100:cede:6433:a77b:41e9]) by smtp.gmail.com with ESMTPSA id g18-20020a7bc4d2000000b003f8d0308604sm9942206wmk.9.2023.06.19.00.56.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 00:56:43 -0700 (PDT) Message-ID: <9f53b80e-7083-705a-88d3-7f3f33dd9c4b@redhat.com> Date: Mon, 19 Jun 2023 09:56:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 To: Yosry Ahmed , "Huang, Ying" Cc: Andrew Morton , Yu Zhao , "Jan Alexander Steffens (heftig)" , Steven Barrett , Brian Geffon , "T.J. Alumbaugh" , Gaosheng Cui , Suren Baghdasaryan , "Matthew Wilcox (Oracle)" , "Liam R. Howlett" , Jason Gunthorpe , Mathieu Desnoyers , David Howells , Hugh Dickins , Greg Thelen , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230618065824.1365750-1-yosryahmed@google.com> <87ilbk8b89.fsf@yhuang6-desk2.ccr.corp.intel.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [RFC PATCH 5/5] Revert "mm/migrate: __unmap_and_move() push good newpage to LRU" In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 666F4100007 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: e9q4j65srii8s8mpmqq5uetm3mjqwceo X-HE-Tag: 1687161407-53371 X-HE-Meta: U2FsdGVkX1/d3Ndfd9+O8dnwYJRoVypSD65aHS/UaIjiZ0wlno5vBiKbeXe77ZRO+0ResMxr9AWRzqiCJYUUFmZpB4oiN922TmSRSBAz4gNDkBkLmP9nTAq5xJq2SmXd15acxI72C1jZYn2AZAcyBU0Snbymr3ZoWaKMFxo4V+UMkLz45ISaIC5GAlL+MmnbsTEJ2h6gWTOoUw2FK+fBe3wujaVgKOTjVpzE5YaY/Bna1/4DCLGqXrhsaFI8zt4N3OnEF02MLG3wFFLL7ot9xBylvElF2Muo1kjIm6UqFETzdyRZfycKcuGQyhFwIN/LFbHMXq0nxMpEjsAToxQ0d8IGNvO3E+MZXZnZ7YVG09mMQAFhiBjykzqsurtZmdGwjr6/p2fKrza6SA6GMP8m8qcAEF5ce5i0D6s9kzj5lzkID8m+hv+pcy/zXdUx+RNGKgyqEcIDG8jLVhHCOdD+rU8vBOCKepjvKOuLSL0LAP3vILCBQFmOsC6c4XWJQqckgpCHnvC/cNdITnTxK5tzFXi4HigBR/Oc9sj60NOAMQEJMod0sBXNnL6MMzr4iME7ym7zwNbZCxr5DTqsFaechK3rqa1XcRU7ZpuhmSYIkckrf2GJrhOCQ7Kt0cCVruZdHlZZpxTIpqt2pHtpMMeVwBrnUMC9R0QzjcZBWPoaScz6n9xc9RLvASywwNVlFNctP5hHMCiLZKWe5kCGPd13H+WmFMAhZQG4A6+9aKXcQWCgTS7C5YLqX43MkCv3kXpFy8/WUpuDlAm0LBbmOjiamkvcGNgMxL6/+ojsEKu2iKDO7bjP2heeuYM+ktjYb7901zjjt77NvL8KYS5QAvZoejPwmqLh952c8U6mtH7zcDTSy0ultwZcY39NgVCvk9mDt5NYZcOAUezj5ceTyx2NnZte99C/HsPiBXvu0uUA+sDbxGe/4G0x3FQ7sd8QOl0N5UD2b1xi/iqdolzHTen zMIroFtV jlZczUgHKqCr6DFQEh4xp84oas8KCfNTEmJCbhh+OZrEllTqudtyvOlh4Y1bpKyVz4Hxx60CWCAM4NC45mRJqNtdHQ2cpNYK5Ud35K8NINhvYP7T/dcKPY9z1BVAvIJTkvAWAFs/bnlPEvys2vMm83yMmBzLv9z1X/YT/Uuz6/Y7NxlGS6aaIwO63cG27MGLfc1bIIr9OBrEKrjsgpiRWRW5EviXHDGVqEACLsdmelF63Tp3vkKpd7gmm59YlyvcXtp8xzXSFfFkeCXoFaWUGFmwGyShcgcG63M+j4ibWqYzOre8s08ShZFEviIDQSmI2NgKhe5m3AAqWCGoYiV7sq9uaCfrOf+hcLi42Gfq/Sfi+QSznTa8NX41y0rrV8Ek6TmWo8Ns/yMGhC6OJNKTVhB5aUSTrBhqPz0WWNuGVrRnAyLbdeJyD+Z0O2EnRT9fnmp/VcAfzyMXcoiJZWAd5wsKs+/18vQIXYm9r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.06.23 05:59, Yosry Ahmed wrote: > On Sun, Jun 18, 2023 at 7:00 PM Huang, Ying wrote: >> >> Hi, Yosry, >> >> Yosry Ahmed writes: >> >>> This reverts commit c3096e6782b733158bf34f6bbb4567808d4e0740. >>> >>> That commit made sure we immediately add the new page to the LRU before >>> remove_migration_ptes() is called in migrate_move_folio() (used to be >>> __unmap_and_move() back then), such that the rmap walk will rebuild the >>> correct mlock_count for the page again. This was needed because the >>> mlock_count was lost when the page is isolated. This is no longer the >>> case since mlock_count no longer overlays page->lru. >>> >>> Revert the commit (the code was foliated afterward the commit, so the >>> revert is updated as such). >>> >>> Signed-off-by: Yosry Ahmed >>> --- >>> mm/migrate.c | 24 +++++++++--------------- >>> 1 file changed, 9 insertions(+), 15 deletions(-) >>> >>> diff --git a/mm/migrate.c b/mm/migrate.c >>> index 01cac26a3127..68f693731865 100644 >>> --- a/mm/migrate.c >>> +++ b/mm/migrate.c >>> @@ -1279,19 +1279,6 @@ static int migrate_folio_move(free_page_t put_new_page, unsigned long private, >>> if (unlikely(!is_lru)) >>> goto out_unlock_both; >> >> The patch itself looks good to me! Thanks! >> >> Reviewed-by: "Huang, Ying" > > Thanks for taking a look! > >> >> And, it seems that we can remove the above 2 lines and "out_unlock_both" >> label now. That can make the code simpler a little. Right? > > I am not familiar with this code. If we remove the above condition > then pages that have is_lru == 0 (i.e __PageMovable(src) is true) and > page_was_mapped == 1 will call remove_migration_ptes(). This wouldn't > happen without removing the above 2 lines. If this combination is > impossible (is_lru == 0 && page_was_mapped == 1), then yeah we can > remove the above condition. > > It looks like __SetPageMovable() is only called by zsmalloc, z3fold, > and balloon_page_insert(). The former 2 will never have those pages > mapped into userspace. I am not familiar with balloon_page_insert(), > but my gut feeling is that those are pages used by the driver and are > also not mapped into userspace. On XEN, there is xen_alloc_ballooned_pages(), which ends up mapping balloon-inflated pages into user space (for something like MMIO IIRC). But the XEN balloon does not use the balloon compaction framework, so __SetPageMovable() does not apply. The other balloon_page_insert() users (VMware balloon, CMM, virtio-balloon) shouldn't be doing something like that. -- Cheers, David / dhildenb