From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B52FCE77188 for ; Tue, 31 Dec 2024 03:18:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2982B6B007B; Mon, 30 Dec 2024 22:18:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 246FA6B0082; Mon, 30 Dec 2024 22:18:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C17D6B0083; Mon, 30 Dec 2024 22:18:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E599E6B007B for ; Mon, 30 Dec 2024 22:18:55 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 74929160CE4 for ; Tue, 31 Dec 2024 03:18:55 +0000 (UTC) X-FDA: 82953795204.08.7B7B669 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf01.hostedemail.com (Postfix) with ESMTP id EF6EE40005 for ; Tue, 31 Dec 2024 03:18:16 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=JtdjGKpD; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf01.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735615089; a=rsa-sha256; cv=none; b=s0s24bYO2WDIAgPRLV24D+qm+0HnhwjJABn0Ac8j2U7hwmCCFiJLotmXl2RM0Q45b3yOZY +dFdHgF3Ouo8TC0LipApvsXBpZIxIRzWp4FjYQp8DJV4vdb6KrVHhGcXVQakyZ6dnKj76m ouOlLDeiR0QgMb5J6RxbW2w14bhZp/A= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=JtdjGKpD; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf01.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735615089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7zo370Vm/uei4aMsevMaKzbPlMUBBOnYJ/SJhXkOZws=; b=bAr9S9rx3QylTuvVwPOrMS79bm3pDCJFJO5EjtRupxKy9E9Ysk/9Ly9Kc5ZwHKxTRG2PlR aRm+VeChSpeaT0nxXLEveZaHRtP37cJw/XAkutUIRN1IMzUgZys+d8fe4ewvgrgPt7cEAD tXeR+5IPr4oL2h6Zwgmn/YvgyT2YuIg= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-216401de828so121248965ad.3 for ; Mon, 30 Dec 2024 19:18:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1735615131; x=1736219931; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7zo370Vm/uei4aMsevMaKzbPlMUBBOnYJ/SJhXkOZws=; b=JtdjGKpDnIJYJTuMuzq06z3TYiNYZKdgQlIB52pz9pCoRFFY5LjNrru2lukFc9kc41 f+6Il+KA7fyknI5WlCSKgAJan21iDT0Z1Tg8l03wSLt4ZpeABz2aLNXTHohxga2TE3Gs 2dUJdB6X+M+WOUsc0DZ3dWKmvGIplF7njHsO/NO9hjm7AaDj31WwfzI1/0CAco0GEn9b gY2bkiCKUF9kVmmmKmSKJnoHYimIu1zsHpKECauOlZ03nSG5HLevZm7gGd7u1De2ygRG rvy1PrWdaWr823xpSeqQQIikzWks3HO6fqe1NBY6cakv/Ge9Nps/tAQytWjHL7oif1qo Dhnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735615131; x=1736219931; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7zo370Vm/uei4aMsevMaKzbPlMUBBOnYJ/SJhXkOZws=; b=HLxxiXyWF0+5pDNG8ZWvzzUDr68BMSEoN2QJdeMTSUmksKhvwhnLBhNGfA4O95KyDq V8LCgB7Px9N1pSOkm3RVXthCE8FBTaFmWjNq4pqxc2Eqf2THPPPJ75oAnxWE2hl6K5AR Q8XH65ZSYguS4UqwTFAH0LFodHLaYrwzpBLa1KDcgI7+9BiMcSgTR8/Cm3xnheVKg8ab dvAGQ86V03qEq4PUV7Wk6bX0em1C6Gs/E+usZexNjgf8C7pte7d9UkqVzFIj446SuygF uab4VtUCnf1b9bOidkA3/6s6uwZOREYeAMIkoyIBuEVgWTMgriz5800da/tmntygr4fX fiCQ== X-Forwarded-Encrypted: i=1; AJvYcCVnFUsnsjovQJo7oioJL5qyeHRLoKbZ4v13LbNP1x7UQdINT0Z9V3nEotWhIkplDJ+UUiB01OagXQ==@kvack.org X-Gm-Message-State: AOJu0YzBa8kWOqa6Qjpq8gbLwrntCp431lUL8vydRRjCF4cMB3S/euci rMsJPgPf0IocBqjMeWuoY3rzqRCK2qjlXpvXyTXm+mHnS9gl6hj08w4nD6AdqDc= X-Gm-Gg: ASbGncu3xbj8RCAreEXlecHkTUq0oMyrxqkLmx6XQux7b9EKjqKWIUyad9zRCWgViOU iukXIpzrtVwGFGKoflPPvLYnhvKFPumQJ7HkAD9pRDtyQYCHGitxLNsEjC1HQkYa5B6pz66Vwn3 pstrfByzE4ahyybOdYPT0mvr1DnWPTX9pmdH9PV1POqeeSdywV28d3ErJzPp6XQA8izhcr1XTKH e8pqGGzCk089zHF9/ljVDtx1sVsn7VeDN9hBcD7K6aB6nw3HvIuhs0AYL4OjDespFhqDWdsnEqP jRCVIg== X-Google-Smtp-Source: AGHT+IHUFtnFGBUg9VKIMxQ9+h2qGO/fJ57n3azK0YDNIIwaL951XSJv1sYjQ9BPoBGXxPbZUmpqXA== X-Received: by 2002:a17:902:f606:b0:20b:7210:5859 with SMTP id d9443c01a7336-219e6f1457bmr582787485ad.38.1735615131505; Mon, 30 Dec 2024 19:18:51 -0800 (PST) Received: from [10.84.148.23] ([203.208.167.148]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f6285sm185590235ad.215.2024.12.30.19.18.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Dec 2024 19:18:51 -0800 (PST) Message-ID: <9f44fb9a-353b-4d50-b2de-497c87fcbb97@bytedance.com> Date: Tue, 31 Dec 2024 11:18:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/12] x86/mm: remove pv_ops.mmu.tlb_remove_table call Content-Language: en-US To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-3-riel@surriel.com> From: Qi Zheng In-Reply-To: <20241230175550.4046587-3-riel@surriel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 3j1181nixph5u83rebzzhr1qhd1odksr X-Rspam-User: X-Rspamd-Queue-Id: EF6EE40005 X-Rspamd-Server: rspam08 X-HE-Tag: 1735615096-886351 X-HE-Meta: U2FsdGVkX19uVL9T8/qCgY3wkzeHCCL88zC550peWHOcEMwJsmiSBpsv1qIkG4NPekwu7nzT+opd3MmF4vp96Bcpk6Cs2n0FRhkAdwn30/G+WNnoNCmjc7JoTNay3269l/Nv6tFF/uwCfn8eSiwJE7n34SdtalHiL0ZzWqZznh3V+KN57H0wi1JPhnskdxeQYqnRyTNNbodFfnKE7+J7bAFRanUc0qO46klMJoFb5mltYdk4n8Eb+RFt1/j/v2muD5+HGELYtfjQ08XIxdaP15EtcM6k53DU4kqW7JAdn31/Us32ivKD62eKZ4ZUtCUf2uUkkvJh3qDnHHMm+JpJM6s70+bd7QodI0DvopChhFGOd4nF0wr2hAG2WEUvgDRVVQ9qorpENNqgXZY9JwsrvfeI1SYspRUzqItj68YbhxyTITywBaQg6B8n8RMSEFnLbA9oPnciAk2PFrRna6LoclEM2ur21Xj6fSb+o4GxQDcN6C6oUtbk32Yjuk71uT1/MNzU9LeJ8FacCwgv5DNh5mk8rqQ61CqvnoUjyuH7HIlwR7tlSh8it2rvHFrlHODdtkSToIRFAXsA7KFAl2z6Owhpi5ogqaowbniE4skwE/fHm3Q4TJ2Hn50E1e+8Mrie4/qyfzgrY8+jXq13FYcg6Uf3GJ9+n0Vfh+JN0NLb1Yi8lLfril8jnm5d+PaxRM1JwrsaeTHJLBJKjBIBhZtV7TCbuWqgvhJ6l1d9jYS/iOnt7B9BD68JDdi8oqZ6J4WhmOEEAk+hMk/Z2v2wO7/N2g/EG9tftkwUzupc3GswYDjQQrlA4+0p2Gjnyw8bIz31dZB9MEjhnI08r+hAsKdwos1B9lHUfDx1s8unzWd+MUe05NODew+Pf4NHTwGiwBk1hFZIxRGLTJJO4y2dpMTlf/ynSpcYvA1wCbwm16TRwgK6Cb9tYgFxPGNdIHIYD0xgU6pVFcpvvXW7UcHFjmI 2wp81Hjh dlPUSDn6rNJ16BVSVT+5SOu17DOZhWbWPnukH9kGcFlBz32OcbDDTDSI0U2aJx9YcSXaftRui60IJXAZSdVb0ZNC97HqlN4Gk74A3AMx5IyLhMOHTaKKiuK/hup9p0HLRLRia9HyrRrHaTF6zjCQn/PCkqxGP1bdNDTaf4opjiF+EqgLtK28HjyyB6BclG4c/eDGh5CCV81vpfbwj1vskfscTFLWhdmkE5kWUx9LsbfJ2UG2pWQJP66evhojIz7bWV82FPQ6WFBOXp+aTsewcxhBE+m2c5D8FBr2S6UDDVa+VK+bcnAzTnPUeDrr9NpeajqF5i6+t+MlhyIkhSJj/1mRi2tSuphoaOD4vJY6mfHsNLtCz9v5k4x3r+sDeJNcezNhRC2n5L130xGCPsJWxjUgXHTOAiy0H2nCS9U/BqtMdndb8bdg0TRNnTVTWYJK5vy/qIMVMsE8JK6q4TY3sGEbnGWhPqpjla5p55Plq1abvUii35bageqRpo+hVT1NUnfjmohTZIQMP89LLiBiD1ZiE/uU3/yKZD9kwp6H7kX6jWfcZz4x4bC5l7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/31 01:53, Rik van Riel wrote: > Every pv_ops.mmu.tlb_remove_table call ends up calling tlb_remove_table. > > Get rid of the indirection by simply calling tlb_remove_table directly, > and not going through the paravirt function pointers. > > Signed-off-by: Rik van Riel > Suggested-by: Qi Zheng > --- > arch/x86/hyperv/mmu.c | 1 - > arch/x86/include/asm/paravirt.h | 5 ----- > arch/x86/include/asm/paravirt_types.h | 2 -- > arch/x86/kernel/kvm.c | 1 - > arch/x86/kernel/paravirt.c | 1 - > arch/x86/mm/pgtable.c | 16 ++++------------ > arch/x86/xen/mmu_pv.c | 1 - > 7 files changed, 4 insertions(+), 23 deletions(-) This change looks good to me. Thanks! In addition, since I also made relevant changes [1], there will be conflict when our code is merged into the linux-next branch. Of course, this is very easy to fix. ;) [1]. https://lore.kernel.org/all/0287d442a973150b0e1019cc406e6322d148277a.1733305182.git.zhengqi.arch@bytedance.com/ (This patch has been merged into the mm-unstable branch, and we can also see it in the linux-next: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=62e76fb4ff704945b5cf9411dda448fefb6618f9) Thanks, Qi