From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17E25CD11C2 for ; Fri, 5 Apr 2024 09:05:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A01116B0085; Fri, 5 Apr 2024 05:05:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B1856B0125; Fri, 5 Apr 2024 05:05:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 852526B0127; Fri, 5 Apr 2024 05:05:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6313A6B0085 for ; Fri, 5 Apr 2024 05:05:32 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2F7B5810E6 for ; Fri, 5 Apr 2024 09:05:32 +0000 (UTC) X-FDA: 81974894904.20.29B5184 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf30.hostedemail.com (Postfix) with ESMTP id E4E2880011 for ; Fri, 5 Apr 2024 09:05:28 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="y/rku7iD"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=j0m+EZfr; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DC20TCWk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=gTweOrRI; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712307930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uvDqRQyFPGXF7Bz9W7132BzzzPZTW1UfAhl4tRMlQFM=; b=Q6OqMpmWCy5mMFjymRJgX4lWMEZ5rR46HDKcIqy6rEIADuDV6UcxamNJkMdYacSy28TzpM Twc1R1t7aClrFYqxi+RLWJi7qFjShKzEyQfdIjjfi//AbS2jtoFH573JL7xbWPEWyAIO2i To39qWhmcgPYLgRIghy88fDLI0vwx5s= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="y/rku7iD"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=j0m+EZfr; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DC20TCWk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=gTweOrRI; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712307930; a=rsa-sha256; cv=none; b=oms+50ujv4/cWv5YA1/eJr5VukLx+abyxroMIQez2QotYIq1i+FZlfy5B4H+5CImGjwEbK /cYkIGiFxyvde43K/F2Hg5qnOuET2tVg8qaaGT2PGoG5SJ2nSflgqjCqdH5wx6PQqEPoLe 1Xe1b0ztrCNxArHpLljbNrE7NjK9E4w= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DF29D21A23; Fri, 5 Apr 2024 09:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712307927; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uvDqRQyFPGXF7Bz9W7132BzzzPZTW1UfAhl4tRMlQFM=; b=y/rku7iDgyEpyLaitFN447zxRdbp2cMmF8EIdhr4voUDfaBVr7AA+jtHXITSk8LaGfUgHG mcr9huYGel4gQD55UNSe4EvQyroFnf3PKD3G///C/xdzwwSqwUE9L2hrZtdXB3tBMJtVo4 GLv0yPl+3zOMtJDYHwbqL5BkowC8huo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712307927; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uvDqRQyFPGXF7Bz9W7132BzzzPZTW1UfAhl4tRMlQFM=; b=j0m+EZfrDOiW2/WPnzIPgQ9CUkfKVKvs6iIaa66Ddo8GCLZ8cyz8SJ4tqSTVHJFmeS7w/2 ssx55ngTxX8BW9CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712307926; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uvDqRQyFPGXF7Bz9W7132BzzzPZTW1UfAhl4tRMlQFM=; b=DC20TCWk1MEZTWzXEnL7oqbq80+RJp2D63I+mf/6TiaGnydUc8EdeHMH4G2zur+s560ZWk bVsdqsNQfF7aa+zsBgNhtqVa+5r1t8fQguW189neTZ2GxGnQTe1p0u4RWQ0zNqjyXzEbPl oXPODtRm2416fq6vLMvqx75xrycp8R0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712307926; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uvDqRQyFPGXF7Bz9W7132BzzzPZTW1UfAhl4tRMlQFM=; b=gTweOrRIrorxkA+XMFCvvb5T0XWuCRgsWS4hNitY2eI14XA98ycGmMfYLKWrMNJt+kDNTy SyVoGs/WQIefNhBQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id B935C139F1; Fri, 5 Apr 2024 09:05:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id yJrlLNa+D2a/TwAAn2gu4w (envelope-from ); Fri, 05 Apr 2024 09:05:26 +0000 Message-ID: <9f3466c7-509f-4982-a62b-ca47f1d91664@suse.cz> Date: Fri, 5 Apr 2024 11:05:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] slub: fix slub segmentation To: "Christoph Lameter (Ampere)" , Ming Yang Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhangliang5@huawei.com, wangzhigang17@huawei.com, liushixin2@huawei.com, alex.chen@huawei.com, pengyi.pengyi@huawei.com, xiqi2@huawei.com References: <20240402031025.1097-1-yangming73@huawei.com> <56193a2c-dadb-108d-4eaf-0a923fc4912b@linux.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <56193a2c-dadb-108d-4eaf-0a923fc4912b@linux.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Bar: / X-Rspamd-Action: no action X-Rspamd-Queue-Id: E4E2880011 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: udozygo6wigcb8cjcycr56qg7j7sxqt9 X-HE-Tag: 1712307928-545971 X-HE-Meta: U2FsdGVkX1/7bcVU6lz3Ueq5/+t0nB4oPc771GmGpDxem8EIJ31HbgU0TvsgN6G7MoEEgnTYGPWy96RlzUsmHak1ZHRkOzTnbuRUuG9tFvWEq4Lzc+qkRQXMCxrWLRkepVNt+DX1JaMkD0P//bV6DT/Eszwcgc1dO5pcwHNAKU8rcBvYSsbwJikSPEtnTREzEAphgPOQ72QafX+ih/96j4OIq6eUE8Di3VKx7OBZgFeGPPd7sHiidChorsltogXZ4m2TdJaCuMFRnA4mKjaAhfxMWJZkCjqgEG6PZmdnUHpN3q7PZNigD8KkysuDGrVeW+r6fJ3O6jeaaxorB9IEiKmeCe3bQhX9bWwj8ORLesvpPfmyQkPwWcaefkQDZwfz0HbDAa7QvDurrFKqV3phVh/DpC196F0QUsSDyny1TyjxACSmE6ym5htI78BS2Jy9RQ3i1eS5VN6dwnbgLkvTNBbWPPsHEC9qaPeMQbXo7ntZAAQY8P2Msa8ZvfVIH0X2m0psfZMyRC52vR1BYWB38rKkiEpbaHS+DJFOdIBWYFw9KXj2fIVb2kPgdODwe3touRXyEFP3mvfaUbfWVXpQ+SMA/f6kbPPh4EKJYuZgP4FR87sksk2SJSLDOlCGh2EE1Gb8JS3LNo8z4ohbRi6NIl/Xnd+gG6TPo66B5wU429JVAvMP9h9u5TCk6CmBSHB4Djc87Z30W4hjwYDfQn4JI0VH472laQ9LKRbEg9F2i55xB5GkQVIGvKDWWAcwI0KdKjvyJTCulayyUyu/YY5ZlnzZ2nSpc930Ge76P+2suQiK6+TLd+J5pL6AqfqaITm2Vp8JawHgijhYgzBuQS/W42c2W1zUEzoT4+4E2OIAKXW92d1vA5FwvPGLxRfaXLT1zBCgtCkQbI9FL0FPMCdX0XIi6A335D3s0RVKw+xevN6WenVmoijczqIZx6jeqWZb0MN+TT/48pWxgw2vcT4 aPbi5Zyp JBboWOeTjBDE5HOPFBq1tDUD+wfhmMPBLRP1E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/4/24 9:12 PM, Christoph Lameter (Ampere) wrote: > On Tue, 2 Apr 2024, Ming Yang wrote: > >> The key point of above allocation flow is: the slab should be alloced >> from the partial of other node first, instead of the buddy system of >> other node directly. > > > If you use GFP_THISNODE then you will trigger a reclaim pass on the remote > node. That could generate a performance regression. Note the alternative approach I merged doesn't have this issue because it uses GFP_NOWAIT for that __GFP_THISNODE attempt. https://lore.kernel.org/all/20240330082335.29710-1-chenjun102@huawei.com/ > We already support this kind of behavior via the node_reclaim / > zone_reclaiom setting in procfs. Please use that. > > The remote buildup of the partial pages can be addressed by changing the > remote_node_defrag_ratio in the slabs. This will make slub scan remote > nodes for partial slabs before going into the page allocator. > >