From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E72EC433EF for ; Tue, 15 Mar 2022 02:01:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E68D8D0002; Mon, 14 Mar 2022 22:01:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 394F78D0001; Mon, 14 Mar 2022 22:01:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E6FB8D0002; Mon, 14 Mar 2022 22:01:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 0CD688D0001 for ; Mon, 14 Mar 2022 22:01:40 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C2029207D3 for ; Tue, 15 Mar 2022 02:01:39 +0000 (UTC) X-FDA: 79244969118.09.AA614E4 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf13.hostedemail.com (Postfix) with ESMTP id 5719020005 for ; Tue, 15 Mar 2022 02:01:39 +0000 (UTC) Received: by mail-pl1-f171.google.com with SMTP id n2so15071204plf.4 for ; Mon, 14 Mar 2022 19:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iUfF+WCTjrbsCXHKV4lddJ1I8Kz2/BCoTPrTLSPUtRE=; b=W6w9vVrpMsMVWgQAqN/0jBMpWBeeJBo6DnfiJ0JUDQ1lPzXiu3u1xzHuAzdGmAgMiJ iVLyNEpnug2G4o04nIrkRREmr78O9X4p6b+7fDirOaE7EOkhY4fBBL7E8sxAmbRycO4t 3TPTa/F0XCcgsyXUMZjt2NYmLJt9fJsk2/aJuf+9ZAMB3Equxf+vhEy5ZdtsqwiT+dAX I+OT/fQvdE6pxndgzXuT+cnTkgBvOEEzwmqx7E2WxtKDN/pzrslAWd5nPxTBlZv+FZ/M yj7jjF4d9wq0g1Yvx8oUm2PEulp8X6iksKCKkdO1qjODFHnFjeG1mosEfivX3OOk76Zg Nhlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iUfF+WCTjrbsCXHKV4lddJ1I8Kz2/BCoTPrTLSPUtRE=; b=xgtmOWr8X4izENOd7gmoOOaTdT77okgXOc8WupL417HJo3bIcfAEx254gxYn+y+3JQ 11Qxo4wGN/mkVbty49BrroItkQZGcKxS1jYSJu/oty7P/PlMcr6wNu45xL77cUaCnYKJ G50tla7mZA3AcaAO077cWCmfPvJSX/4cGabpBCUdBKJbH0DEH4HJM0MJTRjKIySOPJD0 yk9Tjcmc3I3vjSemmLA3ECkKsAJJCIVjJj9FSMiXYl4pv5SIRyTqh7u3uW5xsg/8vJSh 8No1VJo2m93ZNB2wsrLSAv9u5VZk3kOJed+Kpjebaob8S7PHlumPyBG2wp4WrYemxdVE P4ZQ== X-Gm-Message-State: AOAM530KZnupheODgV6R7+s3w6pICfcDB9ZW6N+Uootl+kWUk8xb3Juq t0mMVEBgfRgbIeZ5wMwUE+38qg== X-Google-Smtp-Source: ABdhPJx8Z20U/6UQfFscmQ+wKverU190z3bXx6BwlzRY98FtPPk4dWoyYJ+bay1Jvs/oofjYjaD65A== X-Received: by 2002:a17:902:dac1:b0:151:952a:8821 with SMTP id q1-20020a170902dac100b00151952a8821mr25214435plx.11.1647309697794; Mon, 14 Mar 2022 19:01:37 -0700 (PDT) Received: from ?IPV6:2600:1700:38d4:55df:e6f2:9562:60a7:682a? ([2600:1700:38d4:55df:e6f2:9562:60a7:682a]) by smtp.gmail.com with ESMTPSA id i11-20020a63bf4b000000b00380d3454c38sm14837963pgo.13.2022.03.14.19.01.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Mar 2022 19:01:37 -0700 (PDT) Message-ID: <9f2f1226-f398-f132-06f4-c21a2a2d1033@google.com> Date: Mon, 14 Mar 2022 19:01:35 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [RFC PATCH 04/47] mm: asi: ASI support in interrupts/exceptions Content-Language: en-US To: Thomas Gleixner , linux-kernel@vger.kernel.org Cc: kvm@vger.kernel.org, pbonzini@redhat.com, jmattson@google.com, pjt@google.com, oweisse@google.com, alexandre.chartre@oracle.com, rppt@linux.ibm.com, dave.hansen@linux.intel.com, peterz@infradead.org, luto@kernel.org, linux-mm@kvack.org References: <20220223052223.1202152-1-junaids@google.com> <20220223052223.1202152-5-junaids@google.com> <87pmmofs83.ffs@tglx> From: Junaid Shahid In-Reply-To: <87pmmofs83.ffs@tglx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5719020005 X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=W6w9vVrp; spf=pass (imf13.hostedemail.com: domain of junaids@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=junaids@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: m1hc83f9iesu1muz71wsftmd89bdsp8m X-Rspamd-Server: rspam07 X-HE-Tag: 1647309699-942373 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000054, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/14/22 08:50, Thomas Gleixner wrote: > On Tue, Feb 22 2022 at 21:21, Junaid Shahid wrote: >> #define DEFINE_IDTENTRY_RAW(func) \ >> -__visible noinstr void func(struct pt_regs *regs) >> +static __always_inline void __##func(struct pt_regs *regs); \ >> + \ >> +__visible noinstr void func(struct pt_regs *regs) \ >> +{ \ >> + asi_intr_enter(); \ > > This is wrong. You cannot invoke arbitrary code within a noinstr > section. > > Please enable CONFIG_VMLINUX_VALIDATION and watch the build result with > and without your patches. > > Thanks, > > tglx Thank you for the pointer. It seems that marking asi_intr_enter/exit and asi_enter/exit, and the few functions that they in turn call, as noinstr would fix this, correct? (Along with removing the VM_BUG_ONs from those functions and using notrace/nodebug variants of a couple of functions). Thanks, Junaid