From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71749C25B76 for ; Wed, 5 Jun 2024 14:05:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B21666B007B; Wed, 5 Jun 2024 10:05:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD18D6B0082; Wed, 5 Jun 2024 10:05:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 972306B0083; Wed, 5 Jun 2024 10:05:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7C02B6B007B for ; Wed, 5 Jun 2024 10:05:35 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D204C120E5F for ; Wed, 5 Jun 2024 14:05:34 +0000 (UTC) X-FDA: 82197007788.20.94738D5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 96BFD160026 for ; Wed, 5 Jun 2024 14:05:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AeG2+CEp; spf=pass (imf08.hostedemail.com: domain of bristot@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bristot@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717596332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SnAjRPdPslLKR6RQzu2pBmXnTD4p4gc93G0q5GXgtK8=; b=tdUroEm77k9WqJIxTrmFPFq4zGTj61qULKSMKWjoV8VBiFWB5CohGnFUNvEtXKkmAk8XrO wUZabMQpN+9/Q6TA2OwGHBVfjRtAIrHV0ButgYDirivvxDmvCWRlQjbLdFt3hPV/cnUDP/ ej46l/2u8rrDdk32ZsOqkCHnUVz49Dk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AeG2+CEp; spf=pass (imf08.hostedemail.com: domain of bristot@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bristot@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717596332; a=rsa-sha256; cv=none; b=CB58KOiKhbX67jEjbomDQ7syfYBehWOtuKeAg3JIhYX1GOkP0gTW8ggS+OVqvjcfRuQYVZ MroSBDlDrP/aYf4iK//T1sWNiYdAIRMMToacPEyUgeDAjqZhQX6+dvqdvsDDx/+lL0TeOe w7BB0dvsnjeJdxu/k3Tc3+qZwPznc3w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717596331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SnAjRPdPslLKR6RQzu2pBmXnTD4p4gc93G0q5GXgtK8=; b=AeG2+CEprclHMnAwBkK2w2N+fGRFKAPSNQzBtt5HvYOns5i5D1k4WRT+YqGFYEUNdsT941 6OBTLeDfP+HTOZnKzknCBN3BGs2EK0QyQjSibmgxV/Ox7znune7JgmdGB54pdio/pYpi4L AU7Qy5A3WqNju6keqLPI5fEQt24qy8Q= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-lMuJ-6AsOAO496FRovzfKQ-1; Wed, 05 Jun 2024 10:05:30 -0400 X-MC-Unique: lMuJ-6AsOAO496FRovzfKQ-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-52b9267d9d6so3083010e87.2 for ; Wed, 05 Jun 2024 07:05:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717596325; x=1718201125; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SnAjRPdPslLKR6RQzu2pBmXnTD4p4gc93G0q5GXgtK8=; b=jD1jGF5TmuWFO3Njzx0nLe6fdeRY8Rs/vWPB6pYRXDdpIzoaeQCO58IxrjqiaOWs7B vrvSQBZHBlyZkpOWNW79EVc6rLPKMIg1URF3YAOeuOGJyYAZEImyvIEfribcen9Ndi/E SVLlIB8TxYxW0Lb7p41UHX3JS9DMlU3Si2lUjee4LH4MLr14r6egMXhFHlxG+bDMqHge brS05K/mTMSgweFhm6vE0pMEBQsYLwuB1zZhCG/m3G9gsqChvzp32AiXOzYtejiy52ti PeHQ/IgsI4djdVvavD57LvgIupg4yPHy0SZ6C0b5DqGHz3xO+AObCUIzKuuIdwgCOeZt klrg== X-Forwarded-Encrypted: i=1; AJvYcCUgT87LoXfSo0Bto5MbjcT6UlYdCPoD2hCEHE8ymxSI3AcMfruTEIeNHbFft1DAOSJoHkfCPIyZbp3u90igICPFEvc= X-Gm-Message-State: AOJu0YypD1Ak16ZwOonPZAGrNbWumXPJ3S9nXuCN/id4+HsYotYVkrkB 6V3AkKff/EzfzJa2u5TqUVxOeaQAs6pOjEDln38jymk3cAiFsSaSHrHOcaxb5ONT2zdfzzBG9tZ PBvxpiJo5dQruN3s3dV3bHRGOzn/Fjool8caaeXFVIX7KYHRv X-Received: by 2002:a05:6512:3e5:b0:52b:4ae8:46d9 with SMTP id 2adb3069b0e04-52bab4ca6d4mr1891859e87.5.1717596325740; Wed, 05 Jun 2024 07:05:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGC7EdqZjYrmyMx/USwVrnIBDKTdRMVW5oYpkXPFLx7eROHA0u1LtZeLxEwCYBnW4Z+lNhiRA== X-Received: by 2002:a05:6512:3e5:b0:52b:4ae8:46d9 with SMTP id 2adb3069b0e04-52bab4ca6d4mr1891750e87.5.1717596321944; Wed, 05 Jun 2024 07:05:21 -0700 (PDT) Received: from [192.168.0.161] (host-79-23-6-148.retail.telecomitalia.it. [79.23.6.148]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a681c4f2b6fsm777163266b.144.2024.06.05.07.05.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 07:05:21 -0700 (PDT) Message-ID: <9f21c8e5-1103-44fa-82bd-cf608f8a96f6@redhat.com> Date: Wed, 5 Jun 2024 16:05:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] sched/rt: Clean up usage of rt_task() To: Sebastian Andrzej Siewior Cc: Qais Yousef , Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt , Vincent Guittot , Thomas Gleixner , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , Metin Kaya , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Phil Auld References: <20240604144228.1356121-1-qyousef@layalina.io> <20240604144228.1356121-2-qyousef@layalina.io> <20240605093246.4h0kCR67@linutronix.de> From: Daniel Bristot de Oliveira In-Reply-To: <20240605093246.4h0kCR67@linutronix.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US, pt-BR, it-IT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 96BFD160026 X-Stat-Signature: jx8aa48redyy3wntozwt84ixk3ghwhzp X-Rspam-User: X-HE-Tag: 1717596332-667161 X-HE-Meta: U2FsdGVkX1/zalZzQeBcirPUbyt9DJBPDZ4A7HFoBZwIskHBfKxWgBk8ty4ef14t+9io4yH3+zKm8dr3n9vyGqtJuM96ZFiRwxqGq8nc3naM1E8wpGwJRSZdrSd8eJGiGcUCdD5amZhAMFA8igRlsEYF96FOWswnAW3Xd6Shln8Vg+JGMb8DAAdD7Za3jqWoLvSj6qFYrVqIsGqSqHMzzhBsTGZW5KJDXeYcCjzo0b1esKGLoKd86yqyvR14bTSv+S4ziyKZVWuZQKQNfFVFCyiFe8rJ1bKY3AfwefoIPmHTiGobEYyL9mBqVJPmRFl2SeCX9FeA2iosZqE1IrYOY0EERqtKouLjsQLUF1wiKwLce1nd5LFq/zs/W/HZjHSVZWxOCyxPG1/Cv+1h2jwDoqVXHKsDefNfDJrv8fAC20rYR4kQp24WIMLfdo1z1Oya+CJ2iuYEFenXFGh3ptyrxhBQ4g9g8bLneBxu3+NkLnRGe6xH1iOIDQ4Czwy53Bl6OboAHzEVgVzn8IhA9Oz4NItpnygCniuNy0olhIOVs3DK4C0HLNDWQrO2/blgkx3rul/LXiu9Jft/pf9i78/F+CMaJLakRQLFLmYNj138rfXcwFw4svYQcfTbs3E1TQ9m9NvLoX0w8Kkc3n/NjTSY6VR1x0PQFyAOf1+0By6Xi5bKPvBB6OLUX4Sm8fs1nYTnd15elyQL4ueL4+n/z8VmatF6aiXvvEwcxs6dFDsEVKdnpuVliTmakKrA+pUPpKAPgMnZ0z9YSlxOH1J7UwuQWae+1Vwkz5BR0fo84k5SFXdkr5x/S99xJW+OKeh1DGNVxSknXgef4vbbPtPUFZJeBN0L7MIIaIz1nqK+9tEXDCWqF/aLcV95rKVS3SX3I5OPTRBWVSZpY2TNhuJkA0sixO8O0HijYKRhUfIiti4AJBZT9uL0k38vxP9A+OR3Rf7dMa7X3az9pvBrYdGtSIo P7CzmNOC kc2TSP8E4LfhtHQz7kazo2wC7OJNXTHxtYW39qtBfhGE4iN1KqXF021ZspRWEqq4pR1TTh1KOimeEmppHbDXR68nz5xhvnwApvOhhO3TbTrWY2pflHKzsF8VJnLi33jVFRzSTiSwTbNgkQjBrgZyQ9SJFtTJtFH31nwCtxx0nhH+MyyGF4lwfghxI+9/Po7dNz76NlW/aSKRk6AP96B9IdPN8dUnByJ+pv35wvagGvzl8qpjiuZya/UrP6KDnHy1oY3/fFv1uY+oHKvwvPqPuryQPyb1rdEGR4R76x2+JppcuRRWTggr+xRF+YKqKSBdJIUXeNTkgQDnTEFCV6qXdbiPOChNoNk72HewGCstbEMvmdVo0qdN2xsb3NcngbdgiZ0glWjIgPNjsn4YLbe6MzQYoLlptnxZXk9XO5lI0Opn0vTR/nJ5kwceN7M7aoN2DjVRXP+ttbdHpvVinK5UYKl+621u3vPxdixM1KfTPOtl/bTYQJha8OQ6UcQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000102, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/5/24 11:32, Sebastian Andrzej Siewior wrote: > On 2024-06-04 17:57:46 [+0200], Daniel Bristot de Oliveira wrote: >> On 6/4/24 16:42, Qais Yousef wrote: >>> - (wakeup_rt && !dl_task(p) && !rt_task(p)) || >>> + (wakeup_rt && !realtime_task(p)) || >> >> I do not like bikeshedding, and no hard feelings... >> >> But rt is a shortened version of realtime, and so it is making *it less* >> clear that we also have DL here. > > Can SCHED_DL be considered a real-time scheduling class as in opposite > to SCHED_BATCH for instance? Due to its requirements it fits for a real > time scheduling class, right? > And RT (as in real time) already includes SCHED_RR and SCHED_FIFO. It is a real-time scheduler, but the problem is that FIFO and RR are in rt.c and they are called the "realtime" ones, so they are the first to come in mind. -- Daniel >> -- Daniel > > Sebastian >