From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7EC9C07E9D for ; Thu, 29 Sep 2022 08:43:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 117688D0002; Thu, 29 Sep 2022 04:43:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C7E28D0001; Thu, 29 Sep 2022 04:43:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF8B48D0002; Thu, 29 Sep 2022 04:43:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E04C28D0001 for ; Thu, 29 Sep 2022 04:43:05 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 81FC91411C7 for ; Thu, 29 Sep 2022 08:43:05 +0000 (UTC) X-FDA: 79964483130.13.35917DB Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf02.hostedemail.com (Postfix) with ESMTP id 488CA80012 for ; Thu, 29 Sep 2022 08:43:04 +0000 (UTC) Received: by mail-pg1-f180.google.com with SMTP id bh13so858782pgb.4 for ; Thu, 29 Sep 2022 01:43:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=zRUXeBGrdm+W4SozoFQNagGMSf3AZ/P7iSchvgplql8=; b=WVSWeyA4RyAyY7N4y8z+HOXHabqc29GlkKtm8nzDDXhhAbO9RcSn+Xs797/9MpRpjD KSchlx/85Bub0vCnBfZkQQgHzMPqnl1/syYuSeJhaNyL3HVZ2PbRajFKP1m1vxFvnqwg 93UCGCHRJfYcBXwzNJkRZ6JQ3o4RONDVcfpIIrXbXYZmNEOKN+vlLoAw7tn/QX0NQpWH +C6HOuaXSUMwZvMe5AZzO8ABmJ2H/a7ewr7FrziWSzJQTt1J9CngE4gtVpadXsNMVKoC 4eEcyl/UNcD8fN/W8r3AuYYAfxivOVHEirkQ3dbI1ba0WDg/xDKQhz2AI59it07rJGb7 /7rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=zRUXeBGrdm+W4SozoFQNagGMSf3AZ/P7iSchvgplql8=; b=cXieAKg/aN3bl/FjGT39gqYmEJYzJ6DBMhEJ6VDpqG6m9lVrCjYNYiLS8rfNSiSuKL eSEKPkthMWe3B0KsaPN8QctHLDWf6eKBYfbSA4KLDsLA30gsGRwspmKTcWg9Ek4sbRnl VU9Ydyu9X3I0Sk+rkz9sX0nzGQjsjbJzIZ68tx927ROw5bwCcmjZWB6j5nCBCz4GfC2j sBwTlnnmKtdlg2GzU6ohaRDK/cD8syN30ftWSD93PbOHoEB10+u/059wezklyufZYlu7 b75mERM48L4l/NNmxPNbna2fb8VWKBdgbj99Bi+QkDIGQG4CvfifLPv2W5kA6BHxZ5v2 60Gw== X-Gm-Message-State: ACrzQf2SX5kNvNyT4bzlAoyQiUTtF0eF2CeaJ0lMf/hmg4t9iTXYQPX6 ZfrmhCW/dYhZvybQsGR+494nmQ== X-Google-Smtp-Source: AMsMyM428aLUyX58p1hylfJa6MI23IYq3BQcDLSeiUXL5KM503hGet371RV08RU2bQdN1g7OukD0xQ== X-Received: by 2002:a63:8a43:0:b0:440:34f2:c3c4 with SMTP id y64-20020a638a43000000b0044034f2c3c4mr1962285pgd.408.1664440982814; Thu, 29 Sep 2022 01:43:02 -0700 (PDT) Received: from [10.4.189.225] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id c11-20020a17090a558b00b001fd76f7a0d1sm2872982pji.54.2022.09.29.01.42.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 01:43:02 -0700 (PDT) Message-ID: <9f1d5ffe-840b-f332-559f-81899faf242c@bytedance.com> Date: Thu, 29 Sep 2022 16:42:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] mm: use update_mmu_tlb() on the second thread Content-Language: en-US To: =?UTF-8?B?6ZmI5Y2O5omN?= , maobibo Cc: Qi Zheng , David Hildenbrand , akpm@linux-foundation.org, muchun.song@linux.dev, chris@zankel.net, jcmvbkbc@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song References: <20220926115621.13849-1-zhengqi.arch@bytedance.com> <24f6df23-82cc-1290-e015-cba2a284e060@loongson.cn> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=WVSWeyA4; spf=pass (imf02.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664440985; a=rsa-sha256; cv=none; b=tJgQCEiMN5FN5OtcZBcMbhEqfA5ihaHoZBUQX1uHS2l0fH5MwM8WtW8HzLQoXBSUKY7Shw QxuMveIVeZShzzBJKDDCKjbUV/HWLnIsQyH4CaSl6vk628BF6UpLjGuPP3omp16eqyNqBB zVaDsz5PY9brMA0eQJ3A7/s8msano+Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664440985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zRUXeBGrdm+W4SozoFQNagGMSf3AZ/P7iSchvgplql8=; b=mOF8y+ye8ZuUJbIat+CcZVDEorKs6Fj8PJDUmgP5DM0oiT16ICDfnmtZ5Bukms7atIpb57 A1FrJ/knbxg7yH8+T9sazVutoCyVXkbhKOL8VUb2SecXz4dXWnX9y3H/poxOGowAzE6CsW 7Tpk3HHYATYpyMEJ0M8uPsp9O00KQEs= X-Stat-Signature: bjensrz9d1sc8yf435cis6r4fphsfn1h X-Rspamd-Queue-Id: 488CA80012 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=WVSWeyA4; spf=pass (imf02.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1664440984-388518 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/29 16:38, 陈华才 wrote: > Hi, all, > > >> -----原始邮件----- >> 发件人: maobibo >> 发送时间:2022-09-29 12:05:33 (星期四) >> 收件人: "Qi Zheng" , "David Hildenbrand" , akpm@linux-foundation.org, muchun.song@linux.dev, "陈华才" >> 抄送: chris@zankel.net, jcmvbkbc@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Muchun Song" >> 主题: Re: [PATCH v2] mm: use update_mmu_tlb() on the second thread >> >> >> >> 在 2022/9/29 11:47, Qi Zheng 写道: >>> >>> >>> On 2022/9/29 11:27, maobibo wrote: >>>> 在 2022/9/29 11:07, Qi Zheng 写道: >>>>> >>>>> >>>>> On 2022/9/26 22:34, David Hildenbrand wrote: >>>>>> On 26.09.22 13:56, Qi Zheng wrote: >>>>>>> As message in commit 7df676974359 ("mm/memory.c: Update local TLB >>>>>>> if PTE entry exists") said, we should update local TLB only on the >>>>>>> second thread. So in the do_anonymous_page() here, we should use >>>>>>> update_mmu_tlb() instead of update_mmu_cache() on the second thread. >>>>>>> >>>>>>> Signed-off-by: Qi Zheng >>>>>>> Reviewed-by: Muchun Song >>>>>>> --- >>>>>>> v1: https://lore.kernel.org/lkml/20220924053239.91661-1-zhengqi.arch@bytedance.com/ >>>>>>> >>>>>>> Changelog in v1 -> v2: >>>>>>>    - change the subject and commit message (David) >>>>>>> >>>>>>>    mm/memory.c | 2 +- >>>>>>>    1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>> >>>>>>> diff --git a/mm/memory.c b/mm/memory.c >>>>>>> index 118e5f023597..9e11c783ba0e 100644 >>>>>>> --- a/mm/memory.c >>>>>>> +++ b/mm/memory.c >>>>>>> @@ -4122,7 +4122,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) >>>>>>>        vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address, >>>>>>>                &vmf->ptl); >>>>>>>        if (!pte_none(*vmf->pte)) { >>>>>>> -        update_mmu_cache(vma, vmf->address, vmf->pte); >>>>>>> +        update_mmu_tlb(vma, vmf->address, vmf->pte); >>>>>>>            goto release; >>>>>>>        } >>>>>> >>>>>> >>>>>> Staring at 7df676974359, it indeed looks like an accidental use [nothing else in that patch uses update_mmu_cache]. >>>>>> >>>>>> So it looks good to me, but a confirmation from Bibo Mao might be good. >>>>> >>>>> Thanks, and Hi Bibo, any comments here? :) >>>> >>>> update_mmu_tlb is defined as empty on loongarch, maybe some lines should >>>> be added in file arch/loongarch/include/asm/pgtable.h like this: >>> >>> Seems like a bug? Because there are many other places where >>> update_mmu_tlb() is called. >>> >>>> >>>> +#define __HAVE_ARCH_UPDATE_MMU_TLB >>>> +#define update_mmu_tlb  update_mmu_cache >>> >>> If so, I can make the above as a separate fix patch. >> It sounds good to me. >> >> Huacai, do you have any comments? > From my point of view, LoongArch need a fix for this. OK, will do it in the next version. Thanks. :) > > Huacai >> >> regards >> bibo, mao >>> >>> Thanks, >>> Qi >>> >>>> >>>> regards >>>> bibo mao >>>>> >>>>>> >>>>> >>>> >>> > > > 本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。 > This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it. -- Thanks, Qi