From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 246C5C432BE for ; Thu, 26 Aug 2021 04:21:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9311B61053 for ; Thu, 26 Aug 2021 04:21:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9311B61053 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 984298D0002; Thu, 26 Aug 2021 00:21:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 934338D0001; Thu, 26 Aug 2021 00:21:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 822918D0002; Thu, 26 Aug 2021 00:21:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id 6C0DB8D0001 for ; Thu, 26 Aug 2021 00:21:34 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EBA468249980 for ; Thu, 26 Aug 2021 04:21:33 +0000 (UTC) X-FDA: 78515932866.32.4B884C6 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf14.hostedemail.com (Postfix) with ESMTP id 14D5B600199A for ; Thu, 26 Aug 2021 04:21:32 +0000 (UTC) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Gw8gz44FJz8v71; Thu, 26 Aug 2021 12:17:19 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 26 Aug 2021 12:21:29 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 26 Aug 2021 12:21:28 +0800 Subject: Re: [PATCH] kfence: test: fail fast if disabled at boot To: Marco Elver , CC: , , , , References: <20210825105533.1247922-1-elver@google.com> From: Kefeng Wang Message-ID: <9f1ba12f-1126-46a1-a1ed-4f47ed5a5ffa@huawei.com> Date: Thu, 26 Aug 2021 12:21:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20210825105533.1247922-1-elver@google.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 14D5B600199A X-Stat-Signature: m5w7rd4foocijubxsgz7x3gzt97576wk X-HE-Tag: 1629951692-234297 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/8/25 18:55, Marco Elver wrote: > Fail kfence_test fast if KFENCE was disabled at boot, instead of each > test case trying several seconds to allocate from KFENCE and failing. > KUnit will fail all test cases if kunit_suite::init returns an error. > > Even if KFENCE was disabled, we still want the test to fail, so that CI > systems that parse KUnit output will alert on KFENCE being disabled > (accidentally or otherwise). > > Reported-by: Kefeng Wang > Signed-off-by: Marco Elver Finally find this, it's better, and tested, thanks