From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B517EC433DB for ; Thu, 11 Feb 2021 17:08:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 52D2864E15 for ; Thu, 11 Feb 2021 17:08:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52D2864E15 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C7F836B012F; Thu, 11 Feb 2021 12:08:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C2DE46B0130; Thu, 11 Feb 2021 12:08:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF7096B0131; Thu, 11 Feb 2021 12:08:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id 950C86B012F for ; Thu, 11 Feb 2021 12:08:17 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 442642C32 for ; Thu, 11 Feb 2021 17:08:17 +0000 (UTC) X-FDA: 77806620234.25.C78F4F1 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf11.hostedemail.com (Postfix) with ESMTP id B0A0120001EA for ; Thu, 11 Feb 2021 17:08:14 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id BCC23601FB; Thu, 11 Feb 2021 17:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613063295; bh=oa5xxkgHegTId186SifRj7R4Z6bmoEkTHDsq/mrrNyE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=HcIgB2MUR/bhcDgruLRPJqlLfXrXds21CReZVP1jGfGgiaUsNPs5/qBDnFD2+7z2a 3PBdFu31dEwl83bz/+a6rEF/f3s5Lz6/KjsQbkL55UT7Rwxne5lhUaegUldT6i18mh KZCk2191TEq3EM5rvk5fRAwynQGsG8dWliK7YaS7rIa8oN1Bwo40RWL2DH4e86oiu/ LTpL+ucmdCw5NJ+FmHRKLWzP0u3fyT5T4Zm50YWo+JnT/d6Kfs8eAPpR7bszHJkvt1 Jiq3Zfk0TJFB57NbL8OhHcRw2i88t492rdnOW7IZRUtALSjqc8Vo4jT1BQTLNvmbdK 8Tvxws7lwHzmw== Subject: Re: [PATCH 3/3] [v3] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed To: Pavel Machek Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Vlastimil Babka , Andy Shevchenko , Matthew Wilcox , akpm@linux-foundation.org, Linus Torvalds , roman.fietze@magna.com, Kees Cook , John Ogness , akinobu.mita@gmail.com, glider@google.com, Andrey Konovalov , Marco Elver , Rasmus Villemoes , Tetsuo Handa , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20210210213453.1504219-1-timur@kernel.org> <20210210213453.1504219-4-timur@kernel.org> <20210211123118.GB31708@amd> From: Timur Tabi Message-ID: <9f0c02d9-29d6-95ce-b9b7-27342aa70c6f@kernel.org> Date: Thu, 11 Feb 2021 11:08:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210211123118.GB31708@amd> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B0A0120001EA X-Stat-Signature: yuiiredmz8tjx5iqmahtx6611fh3ifar Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613063294-152698 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/11/21 6:31 AM, Pavel Machek wrote: > Can we make this something shorter? Clearly you don't want people > placing this in their grub config, so they'll be most likely typing > this a lot... > > debug_pointers or debug_ptrs would be better. dbg_unhash_ptrs? "debug_ptrs" is too vague IMHO, and I want to keep the word "hash" somewhere there to indicate exactly what's happening.