From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DDC9C3DA49 for ; Sat, 20 Jul 2024 03:42:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7C626B0082; Fri, 19 Jul 2024 23:42:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2CA26B0085; Fri, 19 Jul 2024 23:42:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF3446B0088; Fri, 19 Jul 2024 23:42:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AD63C6B0082 for ; Fri, 19 Jul 2024 23:42:00 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 311B280ADB for ; Sat, 20 Jul 2024 03:42:00 +0000 (UTC) X-FDA: 82358732400.26.68AFF2F Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf22.hostedemail.com (Postfix) with ESMTP id 6497CC0014 for ; Sat, 20 Jul 2024 03:41:58 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WCOhtYut; spf=pass (imf22.hostedemail.com: domain of rientjes@google.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721446898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hA28LeSjbZup5ALMxE294YbllnKvicLer46RDpBm6UA=; b=TT//t8N0ruterC3KMwsT/i9iM4m2ilD+qGDajQ7ksgnWA8QFgIEYsC+4A/7DKzPcvVs9CK Tb+YoJyhGg7Rlnvk229yblGsguPBRXnEDIoWUydvj41y4ts2okUAEMiW8QSvJGMCnbMFQR RvpJEzEV0ZxklYXjRQcnsLHw3LAcSlc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WCOhtYut; spf=pass (imf22.hostedemail.com: domain of rientjes@google.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721446898; a=rsa-sha256; cv=none; b=jMm4C8Ul0n0cnG8JWLfXpdN76lSWKqktdejjbDUHHS90eBDLqAUnr60w9JB1Nvqg6iaE4P XC2ikYr0JzkPOWbOzCJc5shGopnwGw/CD2OegRc4CCP8SYJ5wOYq76t94Ic+InHlza9ExH 8vwjohO0rqPaLYrbkOFVj8S3HXhmLuM= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1fd657c9199so270225ad.1 for ; Fri, 19 Jul 2024 20:41:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721446917; x=1722051717; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=hA28LeSjbZup5ALMxE294YbllnKvicLer46RDpBm6UA=; b=WCOhtYutc6bLhsl3p6CM4ywuOJFdYEC7Ku//wB+FcI+sdrAAwLGCcQbfFgUZyted04 Va+o7HnRT/L/WmzpuqBzv+8uG2Vg06oT9+XN7Q1mzB0Gpn6PYe4aSYq2WvcXlzgZR+v1 e02ZJ1tZvN5ziTpirrVoFHKX9+wrB8lYvIfG+DDq2pQdmIMhdH5CkL0B61qmnLM+k2xv E1pQo6W97+JCQuTNaIkxc4DFjHL+rXOgt1F/zsaWDpZ1t0ugOTCZiaueIcEHu8CzHSTo 41oTJGf4ILikmvhYf3sbkZNIyKsuC1Jo9S7LsQxz8873QrkNu1oUU/csbEBWMFS1vIX+ OEHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721446917; x=1722051717; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hA28LeSjbZup5ALMxE294YbllnKvicLer46RDpBm6UA=; b=Kb/S4ZaqVgvIuelDyQ5jmC/h640KET+5RA/q5gL0sKcKXcpMRY6lC8ABvrO1hP0R0Y FhVRQ6JUttirFCYroUcboYUv4dE2xiGe0VL7aN8FatdWvNr0ZKTbd9YSM6WAl8lERh8j +al7o+LwpNUps+t13tLuSREdWa7HEep1H5xHC1BV2FhQUjaR+OfT7o2LoOUO7Ehj5OUM TW31d5Ro5p2DhS1RwYU9BSHVjH8ag0GqfD4TBR4Sh+TyBuT6RzG1IZRgOipdVZKvsUm0 9QVCtrZSFugsw6WQ2r1tSJ4d5iseWNSt6fT2vBZKK4fGs/mjhcQ5I3gC3g2OOXG7x0mr 2p0A== X-Forwarded-Encrypted: i=1; AJvYcCURBLnb9GqN2drcvvaUvE+Q9Rm+HXGTV3AN08BOKRjSpenHBcm9PF8TJpP5E2hSp+T1m1fsipHYHhgnN7K1qNUucig= X-Gm-Message-State: AOJu0YwlgWjLhiJa71ULCHJVtLU+2j+NIOC2Oq0ghvispplCHwDBzoKr e3Rpp7QZ23koCcb4a+3urHE8JzZ7YnKZp7W9MTuzkwc4bQPV9UfX4zHH6MlzDg== X-Google-Smtp-Source: AGHT+IGV++E5gqPS9iW9+LLQOn6LEUwO0Bx+NPoKj6GsnOlt4C6jIAUZQTJVBE99ylc8GwERwxBKyA== X-Received: by 2002:a17:903:6c8:b0:1fc:6166:da4c with SMTP id d9443c01a7336-1fd7ff6667bmr49255ad.27.1721446916553; Fri, 19 Jul 2024 20:41:56 -0700 (PDT) Received: from [2620:0:1008:15:652e:fdf2:c177:d5b1] ([2620:0:1008:15:652e:fdf2:c177:d5b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fd6f316be5sm12318395ad.146.2024.07.19.20.41.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jul 2024 20:41:55 -0700 (PDT) Date: Fri, 19 Jul 2024 20:41:55 -0700 (PDT) From: David Rientjes To: Pasha Tatashin cc: Shakeel Butt , akpm@linux-foundation.org, jpoimboe@kernel.org, kent.overstreet@linux.dev, peterz@infradead.org, nphamcs@gmail.com, cerasuolodomenico@gmail.com, surenb@google.com, lizhijian@fujitsu.com, willy@infradead.org, vbabka@suse.cz, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] vmstat: Kernel stack usage histogram In-Reply-To: Message-ID: <9f044745-aa8f-5fff-66c6-4b24521967c8@google.com> References: <20240530170259.852088-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="2003064516-483020861-1721446915=:3457478" X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6497CC0014 X-Stat-Signature: 5g5y4qznmu5ssra7mt4zxeqdifa5xqtp X-HE-Tag: 1721446918-114729 X-HE-Meta: U2FsdGVkX19wPGL2O2ULt5StbHVdq/KqDVt+ZBVkX/mZVddB18qBhN2cmnIIOlwFWsTtb49gF45z4uPeBxMK5pYDaIqUSQwrwvAd/8DIiSCYDPz1GkI5e+l4ndVroEBtdbVlYESUw/h4IY6VtfeOSv7N2uVALAXuxpMYsPimw6OO9Rb0hF7bX1HPIkDGBqWKPH4lfEiaQkyd6/j1KSxlCWF4g+wKauFgeGo0kKuA8WZv9eCTDVlnBXBf6PePdxE77vsM5mdi2HeE8Zdsreb7a8RfB6Kno7KKMNcvY/3gVwROGD4r1vIzOskPrucunkvc+YYh2VRwDvNSrGzo+w8+666Hkfe/0C9ZWUGMewkXEy+AIFnskn2lKB+AJ7SsRwx84sMLicjLdAXtKXGOxg7vGSIha9drXhaWtc+aXpTMryaTorA86PhpDEeWu0dxcLI4lWIrgqdRJc869lVSEguCXldtvlQLjdfzPsTPSZmkuyM9OVILtgYHJJys4T5DRJ/e4i0yZI93uQtRc2fNCOHjgjmOjk+AIDYnLm14cEJnDKm13kxWku0YGmDr0w3lMpTA2tKgdUAX5x0+LKJSRYxzc2s8e6pyhXbV36E9QButM41tSKp10jIYjNaM519YWiO2QRKYlgJsldsBnuhihWRHYhAvtSlhVM17i7B2nqJ/5VOUiF2gl+izy5Xn2DZCI0MP/tAgvxOnK9ObN8MgvhK9PV7NYuN8Tnuxa0ilwTCw+lnA3wY6HgBaYU5SIrehGED0y1rFm1Q5gtsPXJQMumtlmpfBXKmVErpPZzvufN8+92TzJSs5LaEYn3kcccnxnUV+8AAkHQdvZIFJxaAIpEqtZAk1eK5g0SvUdiMzFXBxq4lIY/D7amZs18FB6yHj2vgTDVN++mcbqAUzEGzbh12043PINwWYuD1oQtS1YcbgXGwpN2CjB/+SK16d6DY8DoUBkr4BJzQTjYHd3LAuTPX 1+LBD/NC HmhDBQ5cLytI+oZ01rZh7vXeLft0/xmYoPCBs4cbugzIh0Q9x9xDh33Cy/yNI3RBvCH1GWJEwzj55CwIETnYlpVpboaj9W7N2quzWJOcCF+kmiie/b0LUTYM5XiPF0usPRFJr44yXhzUw04Y870U4uxw69g5+Q5WxCii1SecfUMM6IjATLYbeV1WQP+hWtfi2cKMKrm89aVTnpRJr1W5C6RG8u22js7lDJDIxLj+yA4KdcJ/tsKE083WAQLs9w10689FjaU2WPQvRYHqwh6L++yYOO2VR41qHKGUOMyX3SHeilBJsZVKhLtzXzulSXznuEuGN2jYR3lKxVpuADz/ryPD0BTuqEx2Q2SDhdlFS8d8MiWbxxwJ4voNZTo1APX54Pulv9ZZWA2zXpUM1b8x19XdZOsazrMU2F0WwlPJ+VjFloH0kzmAw63EgwgUHeClMepG4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.086837, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --2003064516-483020861-1721446915=:3457478 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 18 Jul 2024, Pasha Tatashin wrote: > On Thu, Jul 18, 2024 at 7:19 PM Shakeel Butt wrote: > > > > Hi Pasha, > > > > On Wed, Jul 17, 2024 at 12:50:00PM GMT, Pasha Tatashin wrote: > > > On Wed, Jun 12, 2024 at 2:50 PM Shakeel Butt wrote: > > > > > > [...] > > > > > > > > > > One more question: Is there any concern in making > > > > > CONFIG_DEBUG_STACK_USAGE not a debug feature i.e. enable in default > > > > > kernels instead of just debug kernels? > > > > > > We enabled it in Google ProdKernel. There is some overhead when > > > threads are exiting, because we are looking for the first non-zero > > > byte, but that is minimal. We haven't observed any performance impact > > > on our fleet. > > > > > > > So, you would support making CONFIG_DEBUG_STACK_USAGE enabled by > > default, right? > > Right, I see nothing wrong with having this enabled by default. > The benefits of enabling CONFIG_DEBUG_STACK_USAGE by default would certainly outweigh any theoretical performance downside, I strongly favor enabling it by default and was surprised to find it hidden behind debugging when I enabled it in Google's production fleet. --2003064516-483020861-1721446915=:3457478--