From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F8AFC48286 for ; Sun, 4 Feb 2024 16:26:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8583E6B0074; Sun, 4 Feb 2024 11:26:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8079F6B0075; Sun, 4 Feb 2024 11:26:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CEF36B0078; Sun, 4 Feb 2024 11:26:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5EDE36B0074 for ; Sun, 4 Feb 2024 11:26:53 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EFD49C07CA for ; Sun, 4 Feb 2024 16:26:52 +0000 (UTC) X-FDA: 81754650264.07.C4E8ACA Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf13.hostedemail.com (Postfix) with ESMTP id 3E70C20008 for ; Sun, 4 Feb 2024 16:26:49 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=aOpuzhH3; spf=pass (imf13.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707064010; a=rsa-sha256; cv=none; b=C7r01uFkvZMwWX3fdC8+VrQfib1Kf6hapxAIU6LWqaHVQTmbZSuiHJtvj10G0JxVjxiPTs FlXDXtiCAZh/5Im+9zlLiTr9DsoxJdtAeBcY1ObcHuOnN9WZ5UlLoi7jpaYhDq75+sooY+ gBg2aoDogKbQSpKuUgBwlm3RhqXdjfw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=aOpuzhH3; spf=pass (imf13.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707064010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4QsMafIxNnK2tT3E+d+X68HEoyZ0oqU7kYpJhvEviWU=; b=EfKk56U165AkTqPCQmYinRVn+Z8/zBifdZOS3/ToFMZp3ODmB6BWDHTnLzgPonAKSOfgjp X2uf6L5sOl7+JQVRfoaQLicDkWwfEABsVSQ/ty8hgs0KkJPpTnP7BxfXOBnKZ4wapeyW2o w3ihVeSd3uhr+bi04UBvletE2lUlLfE= Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5d862e8b163so1187755a12.1 for ; Sun, 04 Feb 2024 08:26:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1707064008; x=1707668808; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4QsMafIxNnK2tT3E+d+X68HEoyZ0oqU7kYpJhvEviWU=; b=aOpuzhH32wFKGBCx3Qy5fblO7P7c9TtwCVMBJRPJf54iEpBkQG327llhM2zmmDlU7d fHbdH+Wh6R+4YGSmyLXSOzF0SeL5kizaUbEKPiSix9NJUvFYcESIt3iwz/G/xqlv5car qd7X+ilL261XcImiDMR/R+n20r5Pa5GMJaLbYYfUguVlyXQ+H27NSUZeS79r0BL0Lxax 2nS5pvFu7GoctQl0InX4PjlQ+i4oeyN8wu49wD2vbqLkhOZza3u80IYvjn2JQiR54L9O RbULu5zCwtgBV5bzgAo2Euz0qZOnL4fz6j0r+S/FhYswNHOBAiy/D8/AjTLAsyOQY75R cLHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707064008; x=1707668808; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4QsMafIxNnK2tT3E+d+X68HEoyZ0oqU7kYpJhvEviWU=; b=GIBry2/N4MdODSnh8BNgc6fSfhTmsrhB27TLeyoBNW9LdQtDq2s+qk3n7B1t7q/5ry McDNhAHAeqN8PuQbSCwx/26pDIYk0zl0fm2tWhObCaGLhRzft55pfxpcHTgo0sXeYQmJ +7X01rWREkb5MxWEgioQ1reRW98z+dEyW9K/f6qI1GJe1nVDxEhSlNgQSBQPKytp37jx iLZ2i42lI1/TzyjtBSRWbsC2OCURyBEFNNT+HhM6gVBi1WqeOA/sFN4SNUUdbx5iGNqE 5wl3fGWUjhcJ7LEx19Z8PL7m1EwKcco9JW88z7AAnQfY0I2bIykN8GPfR8EBwPlJ8/ih p5RQ== X-Gm-Message-State: AOJu0Ywbtc2hXRbQP6InVsUVULT0MZAsPk+Gt30nOwW4wElQNuGmY5r6 LGplsZdMmZu4HXMcihfkWBKwc0BTQtigOF2TFKRK7xi1qw8nW5Y9zbWfsxtWEpw= X-Google-Smtp-Source: AGHT+IEdB6lRIkC8WPcW3s7wCnfJKQgWD9aaW6Yu/gYI+XGczVtWRxwYpKHIB5xk2H1n3y5Z+6xAqA== X-Received: by 2002:a05:6a00:1c96:b0:6e0:4576:f7e0 with SMTP id y22-20020a056a001c9600b006e04576f7e0mr370773pfw.2.1707064007870; Sun, 04 Feb 2024 08:26:47 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCU9qlQk1dly9VAoSOboZq8pD9fGdkndwUSu5KrIAO6PNtnP46oyJGHeHIyH+DvRKfTzIMJcU96Bx1CySYzoOBaXrFdAs2TALd7W+GPWDEbC489PvGofGEYv0UdJg8EEhDOQ9ncmUsiq2z+mwcxI/mOQ5qY24hPGhlBe31bPf1SlU2SNOZ05k+mzYfOHFZ+1TM56vqi3gYtxI05PClD7RAzdUXOl5gDx1pqzBgI9BpmiaE3GWerHCKo5mdp3d5u30tva/nghn9B92yuyZMdsQXfzLUQqiLo= Received: from [10.254.132.93] ([139.177.225.248]) by smtp.gmail.com with ESMTPSA id le10-20020a056a004fca00b006e02f222c2esm2331289pfb.30.2024.02.04.08.26.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Feb 2024 08:26:47 -0800 (PST) Message-ID: <9ef34638-a3e3-4e86-a96e-bc4694661adb@bytedance.com> Date: Mon, 5 Feb 2024 00:26:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: pgtable: add missing flag and statistics for kernel PTE page Content-Language: en-US To: Mike Rapoport , akpm@linux-foundation.org Cc: arnd@arndb.de, muchun.song@linux.dev, david@redhat.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org References: <3b7e9435-d78e-4430-98d1-f4a839899425@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3E70C20008 X-Stat-Signature: cej66hrjbdqkfrkprrpbc1n5otowubep X-Rspam-User: X-HE-Tag: 1707064009-403156 X-HE-Meta: U2FsdGVkX1/31QkpAH7XsBlpdd4WSMLM0rKPACIIcDAfZwEcBEHK/BjhCaJ6Lxjg0dv8EIgsLTYWBZVjIeFnW5bfJE0oe+SAf4JK+nx05LXx4LsqNythubRWoriOAtObbZmIBXZyTp/Cc70qtUdIO92o+XSZxjGvw7QyJ6hmpkB2VQdVR86YbiQF/3ZoU7OcfSPT1km7zVPtj8rgTlIe22pGeUfvVZBA7QIhmVnvcsj+09eoNm82+u20c51+qdcIN+zispcDil202XSHdZGbFNkCIXGyxRqf1rlV6h7h5ZRwKduFCtQhRh8vQqQ4tQBwqAW6ASddqFJ/ZGbsIR3MirJzBm+4IpylznUlz/fqc+Ohn3wfj7i2ShT8imOYZwh3OZp5uhfMGLDShatYPg7u+g/8I/x9Spll4J90PBWfbJTBXZv7qBnLFJe3BR0DUuNSb/kH7QWUPWohSVqDssJWGS0ytzk8y+1kxXCflLZqbQzuiGwZEgPBEwKHhmZETCJFct53JePuB3HRg7M1EjuuR3AG+supdqYAb99uqlbvmQfc1bFcWYk70H9gQcQoL0yya3GzVchhcR2D6SG5BDi7mCBeId3qP9ppxMuZoFHf3zJ7LmmchNqTb5MI2IKP5JUzmyquS+ygsh7i4zWL2E5Ik4vDySj+gyLlnXZfVbmWkUPpgiIGD3FGUJqs4002X1pIp1zM49lXn6O2iratpxn1C8BCkldFNJ3UKhcB3gLCWU4xeYfH/35mht8klRcX4xta5IEc96x7ZgiiY7uT8YVlUKRJv2GJfuQ1EIVuFFJ7KK2cympsb/y1qJhbKqWH/Ob5102Z8uNSZfUcNTB0C3L0Y8uIHEmb1qzqH34sSLTNNVMi/8BJBSvqqKP2BeaP+cuG59i5HphQKlPQuinQxMe7wkKcCpx3aO5VOIDe7cRVHlYJBeY89Aae/4uec3gb2CpuLRNOu+a3SGEGlBjcoTv fdmmonI6 zGARTV91SMOjyc8z2yQ63IzNX6STDO3m7BXGCxpjZWGwZXQE50LCqSiNKR3J06Tdv7H24nAMAy+f8Eiv9hAEvQHk/EhjODsjMx5jDjrRNlSBiY6bS4K6DGDGNL3zuiwb44Q6kntci4F5FyKAtUHAmAbHx+Z5Vxl2qD/bgOoD1MJchZu9UNv4pkZp4CtD2cMddEP8ER7ZmBCPCLtxAL/sRpAawo/g1CUI/BiVSym4WyeuYv1kQoPRn5hWV9CnrvmoxtrXJbs7u/z83GgaP51PWSKlhByFM49FB4jdFuVmtkXV9JjEhWYg3FPez03v4+dHB1BVi13WBDc0UDMFNbMR/3U5JQzJgwNr28+p/ds8RzZzvdFfiQdYJX3V/sEUuRRF4sxIJMkaTjruBv3+IKpS/nsCOGHFENgUDmdwGiD3/E8r55OgmxM0YijIua8I0rhH/lnVzQ8H6Vis/ohH20QxNGF4WqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/4 20:15, Mike Rapoport wrote: > On Sun, Feb 04, 2024 at 07:39:38PM +0800, Qi Zheng wrote: >> Hi Mike, >> >> On 2024/2/4 18:58, Mike Rapoport wrote: >>> On Thu, Feb 01, 2024 at 04:05:40PM +0800, Qi Zheng wrote: >>>> For kernel PTE page, we do not need to allocate and initialize its split >>>> ptlock, but as a page table page, it's still necessary to add PG_table >>>> flag and NR_PAGETABLE statistics for it. >>>> >>>> Signed-off-by: Qi Zheng >>>> --- >>>> include/asm-generic/pgalloc.h | 7 ++++++- >>>> include/linux/mm.h | 21 ++++++++++++++++----- >>>> 2 files changed, 22 insertions(+), 6 deletions(-) >>> >>> This should also update the architectures that define >>> __HAVE_ARCH_PTE_ALLOC_ONE_KERNEL, otherwise NR_PAGETABLE counts will get >>> wrong. >> >> Yes, this patchset only focuses on the generic implementation. For those >> architectures that define __HAVE_ARCH_PTE_ALLOC_ONE_KERNEL, some reuse >> the generic __pte_alloc_one_kernel(), but some have their own customized >> implementations, which indeed need to be fixed. >> >> I wasn't familiar with those architectures and didn't investigate why >> they couldn't reuse the generic __pte_alloc_one_kernel(), so I didn't >> fix them. > > But with your patch NR_PAGETABLE will underflow e.g. on arm and it'd be a > regression for no good reason. Oh, I see. In some architectures, they implement their own pte_alloc_one_kernel() and do not call generic __pte_alloc_one_kernel(), but still reuse generic pte_free_kernel(). So it needs to be fixed together. I will try to fix them and send the v2. But since I'm on vacation recently, updates may not be quick. Hi Andrew, please help to temporarily remove this patchset from the mm-unstable. Thanks! > >> It would be better if there are maintainers corresponding to >> the architecture who can help fix it. After all, they have a better >> understanding of the historical background and have a testing >> environment. ;) >