From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CB01E7719A for ; Wed, 8 Jan 2025 22:03:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDDD06B0085; Wed, 8 Jan 2025 17:03:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D8F266B0088; Wed, 8 Jan 2025 17:03:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C081B6B0089; Wed, 8 Jan 2025 17:03:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A598F6B0085 for ; Wed, 8 Jan 2025 17:03:08 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2CC6C1414FE for ; Wed, 8 Jan 2025 22:03:08 +0000 (UTC) X-FDA: 82985660856.09.56B32C1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 926501A000F for ; Wed, 8 Jan 2025 22:03:05 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WEfKCERr; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736373785; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kk6HPyiEBK0OVPGvkDK7PZ9JY8SSS471bf1iolkcmRc=; b=f/2SJwb4o/cwz4nFMASVNqEsGso3i8y4Zg3ozKGxFlo7fcR/zOUd5sLVA4t5WVkjIUViZe e2HFOeZQhH4Axil0xHPG9ToC/b8Rm2gI8uVGXLQSYIKOpHtbjCe8MgF5nch6Zl+wv3bP4B k4khAn2D2IAi9eV/pcog46bn0VNUOjk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736373785; a=rsa-sha256; cv=none; b=mmYvuGFdnDZJABaFvHLgZpewS3E6XDDtuKWpFWepczwGfyEbpW+hph1LG8Zdncstf8/KoU 9H8gLQpQreniLOkQ6HOSZQzC05YoRKf0G8c+DTJt3OMS2c3OVJ8TyildEXjwKI+0GBeqfI x0Km2RVanNw0e0J75S8s0jRkeZg2VKg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WEfKCERr; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736373784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Kk6HPyiEBK0OVPGvkDK7PZ9JY8SSS471bf1iolkcmRc=; b=WEfKCERrfAutJ2YScDQZD6lQQLZH04iXJaFFNM3xuzdCF5G0v4yO3v0CaZe7wkFqYQaU2n tknir7UVXJCbfGO/VkqMz1KR8qr28i362MC7cLAe5o0ZeTadGBUFIRlDCZI8LcvY2/gra3 WI8HerC2S0Tn8RUt6MzMikJXywuCALU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-1sVraIXUN9WQdkCoVVrgUQ-1; Wed, 08 Jan 2025 17:03:01 -0500 X-MC-Unique: 1sVraIXUN9WQdkCoVVrgUQ-1 X-Mimecast-MFC-AGG-ID: 1sVraIXUN9WQdkCoVVrgUQ Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4362b9c15d8so1259505e9.3 for ; Wed, 08 Jan 2025 14:03:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736373780; x=1736978580; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Kk6HPyiEBK0OVPGvkDK7PZ9JY8SSS471bf1iolkcmRc=; b=rFkAPTrhvbOyDVBSjH0oUM4DlKLhR+9y+AdbHWVDQ7z9Y1bEGKALaSKAFX7nVhn9Cl 1wxnZDAW3eeYNtI9ey4U0D8j/ml/4mLd/4CByzzjoH7N0kZH3gnv1AbzTQTWS14wZmEV 2sWpoYboviTzTj8wwBENfMwC0O34/HvGEnO1JHcj29M580PrCrl1WW5dSGExdcoTTiR3 9gVhQWNyc0DEm4RVT3nHfZvTot9ksp/IfDRHnHxSi+bxwHiMuWYsMgfY80d3y/tg0tZP WDQmtJg6uBiXE/GQXAm7ZWOxWJ34OxSRLWO7iOZYDk/ClVFA4XtN2tFWUF4yeccBOWBL izAA== X-Forwarded-Encrypted: i=1; AJvYcCUitEmGRKOs8Iycp2gjDVcYn2GCCbpVjhfY4Sgg4aIJlrf8Rwwjxshn5lYQLnx9bAlmFrshLLcxwQ==@kvack.org X-Gm-Message-State: AOJu0YzzdKt3lpKCpBp73UnY6dTXYTs3lqBcYPghXsyY/9QnbERAJU0w UfRMqoU+031qobmgR/3urnq6wFsaIiLHUUlrnFjtMgS5q0H26l3amLdkVZTRdFuWvGXlQ3h76fK 75PKyP+Nay2/d2ZtuLvdB0T+zqTXapjCANhRDmHIZlX076/bV X-Gm-Gg: ASbGncu43ZZ1TdBXbq0PMauelUA4hjHWoNVXUHAsEW866woP8bC3NbyLS648snYtQY0 b1BRyrPI8+I1WRNzferk1qF4odG5DDEu8mDtaiiZf55nQC+9cbG/yCSOzDK5yQ4xGB8SS4mSNDC 050FvaYoe15dOb+6u10BoarjQN2Fa/AR9yw1VjPYybps+rg3yk2/9GnYZepNGtp1DqLc9exwhGW IWoWGw4HJ0jqdnQmROn6CWR5jDyhwFYIqy6cwfkAWr4nC6SL0+yQ58FC3ccFBvalJZOvhhoeUpg 2kWWpH3HxahJ0ozRahLKJffa1xF0t+9hAFo25/b6/7iloi97TPViqk89RPWBq1kwX3fAwufdnOJ HH1+6mg== X-Received: by 2002:a05:6000:4601:b0:385:d7f9:f166 with SMTP id ffacd0b85a97d-38a87303f71mr3583622f8f.17.1736373779999; Wed, 08 Jan 2025 14:02:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IE153c4lxErMIOibHpB/I8wjRh0VGwff0OREF8gpiOBXYUx5D380ZnYjP9k1hzGjIWnUd5U8w== X-Received: by 2002:a05:6000:4601:b0:385:d7f9:f166 with SMTP id ffacd0b85a97d-38a87303f71mr3583606f8f.17.1736373779662; Wed, 08 Jan 2025 14:02:59 -0800 (PST) Received: from ?IPV6:2003:cb:c70d:3a00:d73c:6a8:ca9f:1df7? (p200300cbc70d3a00d73c06a8ca9f1df7.dip0.t-ipconnect.de. [2003:cb:c70d:3a00:d73c:6a8:ca9f:1df7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436dcceb374sm51192615e9.0.2025.01.08.14.02.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 14:02:58 -0800 (PST) Message-ID: <9ef12649-7e82-4b5a-8090-e0645ffbf3dc@redhat.com> Date: Wed, 8 Jan 2025 23:02:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 3/3] fb_defio: do not use deprecated page->mapping, index fields To: Matthew Wilcox Cc: Lorenzo Stoakes , Andrew Morton , Jaya Kumar , Simona Vetter , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <1e452b5b65f15a9a5d0c2ed3f5f812fdd1367603.1736352361.git.lorenzo.stoakes@oracle.com> <34ad8349-c4c3-4370-a662-324fa91b32b1@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AHcqX9fJtGAEoTMn1kse5vmdmwdpSQrBa4o2oyKorgA_1736373780 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: i7ohno5q65psa43xxj847kqnx3fo1cmd X-Rspamd-Queue-Id: 926501A000F X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736373785-988772 X-HE-Meta: U2FsdGVkX1+T+qflqQFTZFX1Yu/2+rlRdJ3Tnz9X7SiaM47DnMXjejkkC7ax5zRY5wWp2u9+wiYS+8UfSQtsdQxPdAk72XEi96k1RtQBJMco9FdJEq39yTYb9iB986K7BqXmbvSnZWef1fwGY4FLhO/eC6ZbH1DuuryTHK6wbwZxwZE8TU8i0OctfrwPuooNNKfpcJeDfUPufRKyNkwVFxU+l6WSAYyjeg8I/4hgU8JTC5C+MseJPOhbzg/KyIp1ZV5s3NUgb8+OIGvzKUGMpqoLCacw7/SkZUwxK2ConuPDgYjs19xcPKO4n2jIAxHWcciZfI3beZarHW3KIsRjiLpLqD1fOi3hl3mnwPAa3FfRD3wTAl9ln+wqE0blnjtpEEnd+lqVeEmhJyeoMM/gV4DvsvC0AfTngRp5qF2KtcMwzijk/RbzsKiY1ZuiSjTspy0QHP7u9FFXozltA9V+8ci2TF3NVOybGgXnpyNNuu7B2NdzqIbMPIMEpKzMG5m6zuvb/1XtC1hTAaNiZ+ZOq9efSm4QdB3im6sxV5riliD6vvStaoRENJmMb9eMdeyeJ8Y3vGGnCxx/SYvMVRvNGED3HDwXFZ4nuPk19SDQwdrADex1lg4s1v9Te2ftFJ+GXyyabm43GaHCho58Zd6o9HEp9nSLBnQ+GlivLuS9Jh/VcP+Ers2l8wVzg2MOqd0/ugGmB94GJR2xqc1nj1R2xNdsURUk6kGc3ghRR1Pi/u8p4A2NRTgwT91jX0TlrqMIQMW4en5+jHKozYkSkyaUODj3SFR9etq4b4IIIWmtnHXTFMr7dHY0uT0OBnZoJ3T7lQM9ZNM6kFKlvNn9daBipUEud531ASD79dtVPFh6GfN9Aez0Xb9sIevRIJ9nba6akl+UXnTyu7DRcLG10zmbhe3NtEEVaJEZsENHDa/UlVT0fTifUhyAH+YJyN7LNHHaqtOEFnWONxwuAzAoMPW NlGRRgK3 P1ppYjVWxnhqftMQFj8ORuTSMVigPD73QTxaeWNvuL+TNjQhXyxB+5PAt8TI6grjNtFE4lzdR2IGPhHVboaKaSzbiFadjjE/ZBKjL9aFEgNkmw+yLIilQbq9dfsPksSxmtI8gflvKmgW9wShmS1EwRNa+QeA/4nNdQ1CcuvWfU/ihWx1avowxAWC6NTprvGazLs+GmobaqLDIGcVZtr2m4tFY3DEUCgrMxSg+7QXpbX5PuMgvwQFBW9wlZcF/YbcQ+d9LP3sWgqdV+YAqrk5to0xlSghOy467EUbJyPz+i2wyUv3y7DUM+50IRsdRvtvD2MsE7qbEKxvm5Aha1PzRJs9QYgWI5BAg4mGebFTzVd7rxlv1rqUBiOv67zu0hQppfECVjPAObqgWgsPlKnxOF5SY+bhx3ss9ZEHiHc5Kzy4K8cYmcRWr3vCqYZAkp8O8D2+N X-Bogosity: Ham, tests=bogofilter, spamicity=0.000367, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.01.25 22:55, Matthew Wilcox wrote: > On Wed, Jan 08, 2025 at 10:12:36PM +0100, David Hildenbrand wrote: >> On 08.01.25 21:54, Matthew Wilcox wrote: >>> Not necessarily! We already do that (since 2022) for DAX (see >>> 6a8e0596f004). rmap lets you find every place that a given range >>> of a file is mapped into user address spaces; but that file might be a >>> device file, and so it's not just pagecache but also (in this case) >>> fb memory, and whatever else device drivers decide to mmap. >> >> Yes, that part I remember. >> >> I thought we would be passing in a page into rmap_wrprotect_file_page(), and >> was wondering what we would do to "struct page" that won't be a folio in >> there. >> >> Probably, because the "_page" in rmap_wrprotect_file_page() is misleading :) >> >> ... should it be "file_range" ? (but we also pass the pfn ... ) > > I don't think it's unprecedented for us to identify a page by its pfn. > After all, the acronym stands for "page frame number". That said, for > the one caller of this, it has the struct page and passes in the result > from page_to_pfn(). So no harm in passing in the struct page directly. > > I would not like to see this function called "rmap_wrprotect_file_pfn". > Files don't have pfns, so that's a bad name. Agreed. (it's too late in the evening for me to give any good suggestions :) ) -- Cheers, David / dhildenb